Re: Review Request 38579: Refactored registry client: split large methods.

2015-11-05 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38579/ --- (Updated Nov. 5, 2015, 5:57 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 38579: Refactored registry client: split large methods.

2015-11-05 Thread Jojy Varghese
> On Nov. 5, 2015, 5:54 p.m., Timothy Chen wrote: > > Can you update the title to something more specific of what this patch does? updated. - Jojy --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 38579: Refactored registry client: split large methods.

2015-11-05 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38579/ --- (Updated Nov. 5, 2015, 7:17 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 38579: Refactored registry client: split large methods.

2015-11-05 Thread Timothy Chen
> On Nov. 6, 2015, 2:54 a.m., Timothy Chen wrote: > > src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp, line > > 529 > > > > > > Can you use the new .status == http::Status::OK and simliar

Re: Review Request 38579: Refactored registry client: split large methods.

2015-11-05 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38579/ --- (Updated Nov. 6, 2015, 6:57 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 38579: Refactored registry client: split large methods.

2015-11-05 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38579/#review105352 ---