Re: Review Request 38900: Update command executor to support rootfs.

2015-11-04 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38900/#review105142 --- Ship it! src/slave/slave.cpp (line 3343)

Re: Review Request 38900: Update command executor to support rootfs.

2015-11-04 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38900/ --- (Updated Nov. 4, 2015, 8:59 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 38900: Update command executor to support rootfs.

2015-11-02 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38900/ --- (Updated Nov. 2, 2015, 7:02 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 38900: Update command executor to support rootfs.

2015-10-31 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38900/ --- (Updated Oct. 31, 2015, 5:57 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 38900: Update command executor to support rootfs.

2015-10-31 Thread Timothy Chen
> On Oct. 14, 2015, 7:23 p.m., Jie Yu wrote: > > src/slave/slave.cpp, lines 3390-3393 > > > > > > Hum... Does that mean that if the user task does not specify a user > > (e.g., rely on framework.user), we are

Re: Review Request 38900: Update command executor to support rootfs.

2015-10-14 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38900/#review102682 --- Only one issue (regarding user). See my detailed comments below.

Re: Review Request 38900: Update command executor to support rootfs.

2015-10-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38900/#review101431 --- Patch looks great! Reviews applied: [38900] All tests passed. -

Re: Review Request 38900: Update command executor to support rootfs.

2015-10-03 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38900/ --- (Updated Oct. 4, 2015, 5:35 a.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 38900: Update command executor to support rootfs.

2015-10-03 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38900/#review101430 --- src/slave/slave.cpp (line 3312)

Re: Review Request 38900: Update command executor to support rootfs.

2015-10-02 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38900/#review101350 --- src/launcher/executor.cpp (line 97)

Re: Review Request 38900: Update command executor to support rootfs.

2015-10-01 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38900/ --- (Updated Oct. 2, 2015, 12:16 a.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 38900: Update command executor to support rootfs.

2015-10-01 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38900/ --- (Updated Oct. 2, 2015, 12:16 a.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 38900: Update command executor to support rootfs.

2015-09-30 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38900/#review101141 --- Patch looks great! Reviews applied: [38900] All tests passed. -

Review Request 38900: Update command executor to support rootfs.

2015-09-30 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38900/ --- Review request for mesos, Jie Yu and Jiang Yan Xu. Repository: mesos