Re: Review Request 39016: RegistryClient refactor: refactored lambdas

2015-11-05 Thread Timothy Chen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39016/#review105354
---

Ship it!


Ship It!

- Timothy Chen


On Nov. 5, 2015, 7:16 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39016/
> ---
> 
> (Updated Nov. 5, 2015, 7:16 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> RegistryClient refactor: refactored lambdas as per review comments.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
> e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c 
> 
> Diff: https://reviews.apache.org/r/39016/diff/
> 
> 
> Testing
> ---
> 
> Make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 39016: RegistryClient refactor: refactored lambdas

2015-11-05 Thread Jojy Varghese 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39016/
---

(Updated Nov. 5, 2015, 7:16 p.m.)


Review request for mesos, Ben Mahler and Timothy Chen.


Changes
---

rebased


Repository: mesos


Description
---

RegistryClient refactor: refactored lambdas as per review comments.


Diffs (updated)
-

  src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c 

Diff: https://reviews.apache.org/r/39016/diff/


Testing
---

Make check.


Thanks,

Jojy Varghese

Re: Review Request 39016: RegistryClient refactor: refactored lambdas

2015-11-05 Thread Jojy Varghese 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39016/#review105277
---



src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp (line 629)


These are completely refactored in subsequent patches where we replaced it 
with streaming writes. So first, i dnt see anything wrong with the lambda. 
Secondly, the effort would be waste because of reason mentioned above.


- Jojy Varghese


On Nov. 5, 2015, 4 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39016/
> ---
> 
> (Updated Nov. 5, 2015, 4 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> RegistryClient refactor: refactored lambdas as per review comments.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
> e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c 
> 
> Diff: https://reviews.apache.org/r/39016/diff/
> 
> 
> Testing
> ---
> 
> Make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 39016: RegistryClient refactor: refactored lambdas

2015-11-05 Thread Timothy Chen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39016/#review105276
---



src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp (line 629)


How about these?


- Timothy Chen


On Nov. 5, 2015, 4 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39016/
> ---
> 
> (Updated Nov. 5, 2015, 4 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> RegistryClient refactor: refactored lambdas as per review comments.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
> e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c 
> 
> Diff: https://reviews.apache.org/r/39016/diff/
> 
> 
> Testing
> ---
> 
> Make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 39016: RegistryClient refactor: refactored lambdas

2015-11-05 Thread Jojy Varghese 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39016/
---

(Updated Nov. 5, 2015, 4 p.m.)


Review request for mesos, Ben Mahler and Timothy Chen.


Changes
---

rebased


Repository: mesos


Description
---

RegistryClient refactor: refactored lambdas as per review comments.


Diffs (updated)
-

  src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c 

Diff: https://reviews.apache.org/r/39016/diff/


Testing
---

Make check.


Thanks,

Jojy Varghese

Re: Review Request 39016: RegistryClient refactor: refactored lambdas

2015-11-04 Thread Jojy Varghese 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39016/#review105212
---



src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp (line 243)


This is a c++ idiom for the case of insertion. Please see effective STL, 
Item 24 by Scott Meyers.


- Jojy Varghese


On Nov. 4, 2015, 11:46 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39016/
> ---
> 
> (Updated Nov. 4, 2015, 11:46 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> RegistryClient refactor: refactored lambdas as per review comments.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
> e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c 
> 
> Diff: https://reviews.apache.org/r/39016/diff/
> 
> 
> Testing
> ---
> 
> Make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 39016: RegistryClient refactor: refactored lambdas

2015-11-04 Thread Ben Mahler 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39016/#review105184
---



src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp (line 243)


Why are you using insert instead of the `[]` operator? Fairly unusual for 
in our codebase.

Also, strings::pairs will simplify your life here, it performs the double 
tokenization and key-ing that you want.


- Ben Mahler


On Nov. 4, 2015, 11:46 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39016/
> ---
> 
> (Updated Nov. 4, 2015, 11:46 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> RegistryClient refactor: refactored lambdas as per review comments.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
> e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c 
> 
> Diff: https://reviews.apache.org/r/39016/diff/
> 
> 
> Testing
> ---
> 
> Make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 39016: RegistryClient refactor: refactored lambdas

2015-11-04 Thread Jojy Varghese 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39016/
---

(Updated Nov. 4, 2015, 11:23 p.m.)


Review request for mesos and Ben Mahler.


Changes
---

rebased


Repository: mesos


Description
---

RegistryClient refactor: refactored lambdas as per review comments.


Diffs (updated)
-

  src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c 

Diff: https://reviews.apache.org/r/39016/diff/


Testing
---

Make check.


Thanks,

Jojy Varghese

Re: Review Request 39016: RegistryClient refactor: refactored lambdas

2015-11-01 Thread Jojy Varghese 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39016/
---

(Updated Nov. 1, 2015, 3:30 p.m.)


Review request for mesos and Ben Mahler.


Changes
---

rebased.


Repository: mesos


Description
---

RegistryClient refactor: refactored lambdas as per review comments.


Diffs (updated)
-

  src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c 

Diff: https://reviews.apache.org/r/39016/diff/


Testing
---

Make check.


Thanks,

Jojy Varghese

Re: Review Request 39016: RegistryClient refactor: refactored lambdas

2015-10-13 Thread Jojy Varghese 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39016/
---

(Updated Oct. 13, 2015, 7:16 p.m.)


Review request for mesos and Ben Mahler.


Changes
---

rebased


Repository: mesos


Description
---

RegistryClient refactor: refactored lambdas as per review comments.


Diffs (updated)
-

  src/slave/containerizer/provisioner/docker/registry_client.cpp 
4931ae8869a697b1e9d8d4cbc0a871e7cd506285 

Diff: https://reviews.apache.org/r/39016/diff/


Testing
---

Make check.


Thanks,

Jojy Varghese

Re: Review Request 39016: RegistryClient refactor: refactored lambdas

2015-10-06 Thread Jojy Varghese 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39016/
---

(Updated Oct. 7, 2015, 12:41 a.m.)


Review request for mesos and Ben Mahler.


Changes
---

rebased after updating patches.


Repository: mesos


Description
---

RegistryClient refactor: refactored lambdas as per review comments.


Diffs (updated)
-

  src/slave/containerizer/provisioner/docker/registry_client.cpp 
4931ae8869a697b1e9d8d4cbc0a871e7cd506285 

Diff: https://reviews.apache.org/r/39016/diff/


Testing
---

Make check.


Thanks,

Jojy Varghese

Review Request 39016: RegistryClient refactor: refactored lambdas

2015-10-05 Thread Jojy Varghese 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39016/
---

Review request for mesos and Ben Mahler.


Repository: mesos


Description
---

RegistryClient refactor: refactored lambdas as per review comments.


Diffs
-

  src/slave/containerizer/provisioner/docker/registry_client.cpp 
c2040b48ea43fdb29766994c244273d3fa9ee3cd 

Diff: https://reviews.apache.org/r/39016/diff/


Testing
---

Make check.


Thanks,

Jojy Varghese