Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39420/#review105755 --- Can you split this into 2 reviews? one adding --parent option and

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39420/#review105685 --- Bad patch! Reviews applied: [38705, 38883, 39410] Failed

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39420/ --- (Updated Nov. 9, 2015, 7:31 a.m.) Review request for mesos, Joris Van

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39420/ --- (Updated Nov. 9, 2015, 7:31 a.m.) Review request for mesos, Joris Van

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39420/ --- (Updated Nov. 9, 2015, 11:57 p.m.) Review request for mesos, Joris Van

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39420/ --- (Updated Nov. 9, 2015, 11:56 p.m.) Review request for mesos, Joris Van

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39420/ --- (Updated Nov. 9, 2015, 2:58 a.m.) Review request for mesos, Joris Van

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39420/#review105664 --- Bad patch! Reviews applied: [38705, 38883, 39410, 39420] Failed

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39420/ --- (Updated Nov. 9, 2015, 12:30 a.m.) Review request for mesos, Joris Van

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39420/#review105662 --- Bad patch! Reviews applied: [38705, 38883, 39410, 39420] Failed

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39420/ --- (Updated Nov. 4, 2015, 3:01 p.m.) Review request for mesos, Joris Van

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39420/ --- (Updated Nov. 4, 2015, 2:45 p.m.) Review request for mesos, Joris Van

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39420/#review105179 --- Bad patch! Reviews applied: [38705, 38883] Failed command:

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39420/ --- (Updated Oct. 30, 2015, 1:56 a.m.) Review request for mesos, Joris Van

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39420/#review104549 --- Patch looks great! Reviews applied: [38705, 38883, 39410, 39420]

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39420/ --- (Updated Oct. 28, 2015, 3:10 p.m.) Review request for mesos, Joris Van

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39420/#review103779 --- Ship it! Thanks for the "Better Bash" :) - Marco Massenzio On

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39420/ --- (Updated Oct. 22, 2015, 11:19 p.m.) Review request for mesos, Joris Van

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39420/ --- (Updated Oct. 22, 2015, 11:58 p.m.) Review request for mesos, Joris Van

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

> On Oct. 22, 2015, 11:48 p.m., Marco Massenzio wrote: > > Looks good - I'd still be happier with "Better Bash" :) would you mind > > "fixing" apply-review.sh? > > > > Thanks! Done. - Artem --- This is an automatically generated

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39420/#review103729 --- Ship it! Looks good - I'd still be happier with "Better Bash" :)

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39420/#review103742 --- Patch looks great! Reviews applied: [38705, 38883, 39410, 39420]

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39420/#review103388 --- Patch looks great! Reviews applied: [38705, 38883, 39410, 39420]

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

> On Oct. 20, 2015, 2:55 p.m., Marco Massenzio wrote: > > support/apply-review.sh, line 3 > > > > > > I really dislike this style of conditional running stuff in bash (it > > also violates Google's style, but that's

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39420/ --- (Updated Oct. 20, 2015, 11:04 p.m.) Review request for mesos, Joris Van

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39420/ --- (Updated Oct. 20, 2015, 12:45 a.m.) Review request for mesos, Joris Van

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39420/#review103312 --- Ship it! I guess you want to retain apply-reviews.sh for backward

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

> On Oct. 18, 2015, 7:14 a.m., Guangya Liu wrote: > > Why not make this as a default option? I think that we need to apply the > > whole chain of patch for development, thoughts? Thanks. It will break the verification script that ASF Jenkins currently uses. - Artem

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39420/#review103080 --- Patch looks great! Reviews applied: [38705, 38883, 39410, 39420]

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39420/ --- (Updated Oct. 18, 2015, 3:33 p.m.) Review request for mesos, Joris Van

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

> On Oct. 18, 2015, 7:14 a.m., Guangya Liu wrote: > > support/apply-reviews.py, lines 272-274 > > > > > > Tab or blank space? If Tab, we should switch to blank space Thanks for spotting this! My editor was sneaking

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39420/#review103082 --- Ship it! Ship It! - Guangya Liu On 十月 18, 2015, 10:33 p.m.,

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39420/#review103056 --- Why not make this as a default option? I think that we need to