Re: Review Request 39497: Fixed quotation of interpolated variables in log messages.

[Joris Van Remoortere]

> On Oct. 20, 2015, 10:35 p.m., Greg Mann wrote:
> >

The executor id now has a stream operator that takes care of this formatting.


- Joris


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39497/#review103320
---


On Oct. 21, 2015, 2:37 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39497/
> ---
> 
> (Updated Oct. 21, 2015, 2:37 a.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3772
> https://issues.apache.org/jira/browse/MESOS-3772
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Specifically, we should always quote executor IDs (because they are
> user-supplied and might contain whitespace), but we don't need to quote
> framework IDs. There's a bunch more work we could do here (e.g., escaping
> punctuation), but this is a start.
> 
> Also fix a few style issues with usage of "<<" operators.
> 
> 
> Diffs
> -
> 
>   src/exec/exec.cpp c99dc073f5ed5f635a41393ecb38ec13f21739d4 
>   src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 
>   src/master/master.cpp 2cc814721a8c85b330a402b0ec54491a0b0db5aa 
>   src/slave/containerizer/isolators/network/port_mapping.cpp 
> e6bb75e6f5ba48a0c4cf6dd8f353e5f5843d0eef 
>   src/slave/slave.cpp 652697688fd9e9a6d064ef01fb032393412307b3 
>   src/slave/state.cpp 81c4b96d879f974f0dfba3fb977184122eab 
>   src/tests/containerizer.cpp 451c7be0bfd668ccd3325964cafcc4cbac941a94 
> 
> Diff: https://reviews.apache.org/r/39497/diff/
> 
> 
> Testing
> ---
> 
> make check, visual inspection.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 39497: Fixed quotation of interpolated variables in log messages.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39497/#review104101
---

Ship it!


minus the removal of taskid quotations.

- Joris Van Remoortere


On Oct. 21, 2015, 2:37 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39497/
> ---
> 
> (Updated Oct. 21, 2015, 2:37 a.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3772
> https://issues.apache.org/jira/browse/MESOS-3772
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Specifically, we should always quote executor IDs (because they are
> user-supplied and might contain whitespace), but we don't need to quote
> framework IDs. There's a bunch more work we could do here (e.g., escaping
> punctuation), but this is a start.
> 
> Also fix a few style issues with usage of "<<" operators.
> 
> 
> Diffs
> -
> 
>   src/exec/exec.cpp c99dc073f5ed5f635a41393ecb38ec13f21739d4 
>   src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 
>   src/master/master.cpp 2cc814721a8c85b330a402b0ec54491a0b0db5aa 
>   src/slave/containerizer/isolators/network/port_mapping.cpp 
> e6bb75e6f5ba48a0c4cf6dd8f353e5f5843d0eef 
>   src/slave/slave.cpp 652697688fd9e9a6d064ef01fb032393412307b3 
>   src/slave/state.cpp 81c4b96d879f974f0dfba3fb977184122eab 
>   src/tests/containerizer.cpp 451c7be0bfd668ccd3325964cafcc4cbac941a94 
> 
> Diff: https://reviews.apache.org/r/39497/diff/
> 
> 
> Testing
> ---
> 
> make check, visual inspection.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 39497: Fixed quotation of interpolated variables in log messages.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39497/#review103437
---

Ship it!


Ship It!

- Greg Mann


On Oct. 21, 2015, 2:37 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39497/
> ---
> 
> (Updated Oct. 21, 2015, 2:37 a.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3772
> https://issues.apache.org/jira/browse/MESOS-3772
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Specifically, we should always quote executor IDs (because they are
> user-supplied and might contain whitespace), but we don't need to quote
> framework IDs. There's a bunch more work we could do here (e.g., escaping
> punctuation), but this is a start.
> 
> Also fix a few style issues with usage of "<<" operators.
> 
> 
> Diffs
> -
> 
>   src/exec/exec.cpp c99dc073f5ed5f635a41393ecb38ec13f21739d4 
>   src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 
>   src/master/master.cpp 2cc814721a8c85b330a402b0ec54491a0b0db5aa 
>   src/slave/containerizer/isolators/network/port_mapping.cpp 
> e6bb75e6f5ba48a0c4cf6dd8f353e5f5843d0eef 
>   src/slave/slave.cpp 652697688fd9e9a6d064ef01fb032393412307b3 
>   src/slave/state.cpp 81c4b96d879f974f0dfba3fb977184122eab 
>   src/tests/containerizer.cpp 451c7be0bfd668ccd3325964cafcc4cbac941a94 
> 
> Diff: https://reviews.apache.org/r/39497/diff/
> 
> 
> Testing
> ---
> 
> make check, visual inspection.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 39497: Fixed quotation of interpolated variables in log messages.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39497/#review103366
---


Patch looks great!

Reviews applied: [39497]

All tests passed.

- Mesos ReviewBot


On Oct. 21, 2015, 2:37 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39497/
> ---
> 
> (Updated Oct. 21, 2015, 2:37 a.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3772
> https://issues.apache.org/jira/browse/MESOS-3772
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Specifically, we should always quote executor IDs (because they are
> user-supplied and might contain whitespace), but we don't need to quote
> framework IDs. There's a bunch more work we could do here (e.g., escaping
> punctuation), but this is a start.
> 
> Also fix a few style issues with usage of "<<" operators.
> 
> 
> Diffs
> -
> 
>   src/exec/exec.cpp c99dc073f5ed5f635a41393ecb38ec13f21739d4 
>   src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 
>   src/master/master.cpp 2cc814721a8c85b330a402b0ec54491a0b0db5aa 
>   src/slave/containerizer/isolators/network/port_mapping.cpp 
> e6bb75e6f5ba48a0c4cf6dd8f353e5f5843d0eef 
>   src/slave/slave.cpp 652697688fd9e9a6d064ef01fb032393412307b3 
>   src/slave/state.cpp 81c4b96d879f974f0dfba3fb977184122eab 
>   src/tests/containerizer.cpp 451c7be0bfd668ccd3325964cafcc4cbac941a94 
> 
> Diff: https://reviews.apache.org/r/39497/diff/
> 
> 
> Testing
> ---
> 
> make check, visual inspection.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 39497: Fixed quotation of interpolated variables in log messages.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39497/#review103320
---



src/slave/slave.cpp (line 1938)


Should this executor ID be quoted as well?



src/slave/slave.cpp (line 1941)


Should this executor ID be quoted as well?



src/slave/slave.cpp (line 1955)


This one too?



src/slave/slave.cpp (line 1988)


Should this executor ID be quoted as well? Also, could you remove the 
extraneous space at the beginning of this error message?



src/slave/slave.cpp (lines 2121 - 2122)


Two single quotes before `executorId`, none after.



src/slave/slave.cpp (lines 2136 - 2137)


Two single quotes before executorId, none after.



src/slave/slave.cpp (line 3460)


Could you also remove the period at the end of this error message?



src/slave/slave.cpp (line 3506)


Could you also remove the extraneous space at the beginning of this error 
message?


- Greg Mann


On Oct. 20, 2015, 10:04 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39497/
> ---
> 
> (Updated Oct. 20, 2015, 10:04 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3772
> https://issues.apache.org/jira/browse/MESOS-3772
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Specifically, we should always quote executor IDs (because they are
> user-supplied and might contain whitespace), but we don't need to quote
> framework IDs. There's a bunch more work we could do here (e.g., escaping
> punctuation), but this is a start.
> 
> Also fix a few style issues with usage of "<<" operators.
> 
> 
> Diffs
> -
> 
>   src/exec/exec.cpp c99dc073f5ed5f635a41393ecb38ec13f21739d4 
>   src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 
>   src/slave/containerizer/isolators/network/port_mapping.cpp 
> e6bb75e6f5ba48a0c4cf6dd8f353e5f5843d0eef 
>   src/slave/slave.cpp 652697688fd9e9a6d064ef01fb032393412307b3 
>   src/slave/state.cpp 81c4b96d879f974f0dfba3fb977184122eab 
> 
> Diff: https://reviews.apache.org/r/39497/diff/
> 
> 
> Testing
> ---
> 
> make check, visual inspection.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Review Request 39497: Fixed quotation of interpolated variables in log messages.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39497/
---

Review request for mesos and Joris Van Remoortere.


Bugs: MESOS-3772
https://issues.apache.org/jira/browse/MESOS-3772


Repository: mesos


Description
---

Specifically, we should always quote executor IDs (because they are
user-supplied and might contain whitespace), but we don't need to quote
framework IDs. There's a bunch more work we could do here (e.g., escaping
punctuation), but this is a start.

Also fix a few style issues with usage of "<<" operators.


Diffs
-

  src/exec/exec.cpp c99dc073f5ed5f635a41393ecb38ec13f21739d4 
  src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 
  src/slave/containerizer/isolators/network/port_mapping.cpp 
e6bb75e6f5ba48a0c4cf6dd8f353e5f5843d0eef 
  src/slave/slave.cpp 652697688fd9e9a6d064ef01fb032393412307b3 
  src/slave/state.cpp 81c4b96d879f974f0dfba3fb977184122eab 

Diff: https://reviews.apache.org/r/39497/diff/


Testing
---

make check, visual inspection.


Thanks,

Neil Conway