Re: Review Request 39539: Windows: Moved `os::mktemp` to its own file, `stout/os/mktemp.hpp`.

2015-10-28 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39539/#review104052 --- Ship it! 3rdparty/libprocess/3rdparty/stout/include/Makefile.am

Re: Review Request 39539: Windows: Moved `os::mktemp` to its own file, `stout/os/mktemp.hpp`.

2015-10-27 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39539/ --- (Updated Oct. 27, 2015, 6:32 a.m.) Review request for mesos, Artem

Re: Review Request 39539: Windows: Moved `os::mktemp` to its own file, `stout/os/mktemp.hpp`.

2015-10-26 Thread Joris Van Remoortere
> On Oct. 23, 2015, 4:49 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp, lines 270-274 > > > > > > Do you need this one? There are some uses of `os::mktemp` in the

Re: Review Request 39539: Windows: Moved `os::mktemp` to its own file, `stout/os/mktemp.hpp`.

2015-10-23 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39539/#review103793 --- Confirmed that mktemp logic was unchanged.

Review Request 39539: Windows: Moved `os::mktemp` to its own file, `stout/os/mktemp.hpp`.

2015-10-21 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39539/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph

Re: Review Request 39539: Windows: Moved `os::mktemp` to its own file, `stout/os/mktemp.hpp`.

2015-10-21 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39539/#review103521 --- 3rdparty/libprocess/3rdparty/stout/include/stout/os/mktemp.hpp