Re: Review Request 40291: Added the stye guideline for blank line after line-wrapping.

2015-11-22 Thread Joerg Schad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40291/
---

(Updated Nov. 22, 2015, 11:52 a.m.)


Review request for mesos, Bernd Mathiske and Neil Conway.


Changes
---

Updated example


Repository: mesos


Description
---

Added the stye guideline for blank line after line-wrapping.


Diffs (updated)
-

  docs/c++-style-guide.md 0b6189174a4f0f1815625f68fb1a743b04a9cdad 

Diff: https://reviews.apache.org/r/40291/diff/


Testing
---

viewed rendered doc.


Thanks,

Joerg Schad

Re: Review Request 40291: Added the stye guideline for blank line after line-wrapping.

2015-11-20 Thread Joerg Schad 


> On Nov. 19, 2015, 7:06 p.m., Neil Conway wrote:
> > docs/c++-style-guide.md, line 118
> > 
> >
> > The point is that the for loop condition should be defined over 
> > multiple lines, right?

Yes


> On Nov. 19, 2015, 7:06 p.m., Neil Conway wrote:
> > docs/c++-style-guide.md, line 114
> > 
> >
> > Why the <> in  ?

It is just to indicate that it is a ver long line


- Joerg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40291/#review107223
---


On Nov. 16, 2015, 5:32 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40291/
> ---
> 
> (Updated Nov. 16, 2015, 5:32 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added the stye guideline for blank line after line-wrapping.
> 
> 
> Diffs
> -
> 
>   docs/c++-style-guide.md 0b6189174a4f0f1815625f68fb1a743b04a9cdad 
> 
> Diff: https://reviews.apache.org/r/40291/diff/
> 
> 
> Testing
> ---
> 
> viewed rendered doc.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 40291: Added the stye guideline for blank line after line-wrapping.

2015-11-20 Thread Joerg Schad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40291/
---

(Updated Nov. 20, 2015, 4:55 p.m.)


Review request for mesos, Bernd Mathiske and Neil Conway.


Repository: mesos


Description
---

Added the stye guideline for blank line after line-wrapping.


Diffs (updated)
-

  docs/c++-style-guide.md 0b6189174a4f0f1815625f68fb1a743b04a9cdad 

Diff: https://reviews.apache.org/r/40291/diff/


Testing
---

viewed rendered doc.


Thanks,

Joerg Schad

Re: Review Request 40291: Added the stye guideline for blank line after line-wrapping.

2015-11-19 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40291/#review107223
---

Ship it!


We might want to clarify that if you have a multi-line statement that is 
immediately followed by a closing brace, you don't need a newline before the 
brace.


docs/c++-style-guide.md (line 114)


Why the <> in  ?



docs/c++-style-guide.md (line 118)


The point is that the for loop condition should be defined over multiple 
lines, right?


- Neil Conway


On Nov. 16, 2015, 5:32 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40291/
> ---
> 
> (Updated Nov. 16, 2015, 5:32 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added the stye guideline for blank line after line-wrapping.
> 
> 
> Diffs
> -
> 
>   docs/c++-style-guide.md 0b6189174a4f0f1815625f68fb1a743b04a9cdad 
> 
> Diff: https://reviews.apache.org/r/40291/diff/
> 
> 
> Testing
> ---
> 
> viewed rendered doc.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 40291: Added the stye guideline for blank line after line-wrapping.

2015-11-19 Thread Bernd Mathiske 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40291/#review107199
---

Ship it!


Ship It!

- Bernd Mathiske


On Nov. 16, 2015, 9:32 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40291/
> ---
> 
> (Updated Nov. 16, 2015, 9:32 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added the stye guideline for blank line after line-wrapping.
> 
> 
> Diffs
> -
> 
>   docs/c++-style-guide.md 0b6189174a4f0f1815625f68fb1a743b04a9cdad 
> 
> Diff: https://reviews.apache.org/r/40291/diff/
> 
> 
> Testing
> ---
> 
> viewed rendered doc.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>