Re: Review Request 40379: [WIP] MESOS-3930: Set resource type as USAGE_SLACK for Oversubscription

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40379/#review107924
---


As we discussed, since we already resolved the compatibility issue, so we can 
evaluate if we need to udpate this file or not. ;-)

- Guangya Liu


On 十一月 24, 2015, 11:02 a.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40379/
> ---
> 
> (Updated 十一月 24, 2015, 11:02 a.m.)
> 
> 
> Review request for mesos and Guangya Liu.
> 
> 
> Bugs: MESOS-3930
> https://issues.apache.org/jira/browse/MESOS-3930
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In Optimistic Offer Phase 1, it introduce `RevocableInfo::type`: USAGE_SLACK 
> for Oversubscription and ALLOCATION_SLACK for Optimistic Offer. Slave helps 
> to update `RevocableInfo::type` for Oversubscription.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp 9055f2a 
> 
> Diff: https://reviews.apache.org/r/40379/diff/
> 
> 
> Testing
> ---
> 
> make (make check is on-going)
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 40379: [WIP] MESOS-3930: Set resource type as USAGE_SLACK for Oversubscription

[Klaus Ma]

> On Nov. 23, 2015, 8:58 a.m., Guangya Liu wrote:
> > src/slave/slave.cpp, line 4419
> > 
> >
> > I think that the oversubscribable resources should always 
> > has_revocable()? For which case does the oversubscribable resource do not 
> > has_revocable()? Caused by a bad resource estimitator? For such case, can 
> > we let slave throw exception?

Should we keep the compatitility?


- Klaus


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40379/#review107527
---


On Nov. 24, 2015, 7:02 p.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40379/
> ---
> 
> (Updated Nov. 24, 2015, 7:02 p.m.)
> 
> 
> Review request for mesos and Guangya Liu.
> 
> 
> Bugs: MESOS-3930
> https://issues.apache.org/jira/browse/MESOS-3930
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In Optimistic Offer Phase 1, it introduce `RevocableInfo::type`: USAGE_SLACK 
> for Oversubscription and ALLOCATION_SLACK for Optimistic Offer. Slave helps 
> to update `RevocableInfo::type` for Oversubscription.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp 9055f2a 
> 
> Diff: https://reviews.apache.org/r/40379/diff/
> 
> 
> Testing
> ---
> 
> make (make check is on-going)
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 40379: [WIP] MESOS-3930: Set resource type as USAGE_SLACK for Oversubscription

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40379/
---

(Updated Nov. 24, 2015, 7:02 p.m.)


Review request for mesos and Guangya Liu.


Changes
---

Address comments


Bugs: MESOS-3930
https://issues.apache.org/jira/browse/MESOS-3930


Repository: mesos


Description
---

In Optimistic Offer Phase 1, it introduce `RevocableInfo::type`: USAGE_SLACK 
for Oversubscription and ALLOCATION_SLACK for Optimistic Offer. Slave helps to 
update `RevocableInfo::type` for Oversubscription.


Diffs (updated)
-

  src/slave/slave.cpp 9055f2a 

Diff: https://reviews.apache.org/r/40379/diff/


Testing
---

make (make check is on-going)


Thanks,

Klaus Ma

Re: Review Request 40379: [WIP] MESOS-3930: Set resource type as USAGE_SLACK for Oversubscription

[Klaus Ma]

> On Nov. 24, 2015, 10:25 p.m., Guangya Liu wrote:
> > Seems the rebase caused some problem for your patch, some files are lost.

There's only file for this patch; if still issue, please ping me online.


> On Nov. 24, 2015, 10:25 p.m., Guangya Liu wrote:
> > src/slave/slave.cpp, line 4460
> > 
> >
> > s/allocations/usage slack?

Used comments in `mesos.proto`


- Klaus


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40379/#review107786
---


On Nov. 24, 2015, 7:02 p.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40379/
> ---
> 
> (Updated Nov. 24, 2015, 7:02 p.m.)
> 
> 
> Review request for mesos and Guangya Liu.
> 
> 
> Bugs: MESOS-3930
> https://issues.apache.org/jira/browse/MESOS-3930
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In Optimistic Offer Phase 1, it introduce `RevocableInfo::type`: USAGE_SLACK 
> for Oversubscription and ALLOCATION_SLACK for Optimistic Offer. Slave helps 
> to update `RevocableInfo::type` for Oversubscription.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp 9055f2a 
> 
> Diff: https://reviews.apache.org/r/40379/diff/
> 
> 
> Testing
> ---
> 
> make (make check is on-going)
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 40379: [WIP] MESOS-3930: Set resource type as USAGE_SLACK for Oversubscription

[Guangya Liu]

> On 十一月 23, 2015, 12:58 a.m., Guangya Liu wrote:
> > src/slave/slave.cpp, line 4419
> > 
> >
> > I think that the oversubscribable resources should always 
> > has_revocable()? For which case does the oversubscribable resource do not 
> > has_revocable()? Caused by a bad resource estimitator? For such case, can 
> > we let slave throw exception?
> 
> Klaus Ma wrote:
> Should we keep the compatitility?

Yes, we should keep compatibility. But the problem is that all of the revocable 
resources no matter usage_slack or allocation_slack should has_revocable()? 
Comments?


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40379/#review107527
---


On 十一月 24, 2015, 11:02 a.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40379/
> ---
> 
> (Updated 十一月 24, 2015, 11:02 a.m.)
> 
> 
> Review request for mesos and Guangya Liu.
> 
> 
> Bugs: MESOS-3930
> https://issues.apache.org/jira/browse/MESOS-3930
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In Optimistic Offer Phase 1, it introduce `RevocableInfo::type`: USAGE_SLACK 
> for Oversubscription and ALLOCATION_SLACK for Optimistic Offer. Slave helps 
> to update `RevocableInfo::type` for Oversubscription.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp 9055f2a 
> 
> Diff: https://reviews.apache.org/r/40379/diff/
> 
> 
> Testing
> ---
> 
> make (make check is on-going)
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 40379: [WIP] MESOS-3930: Set resource type as USAGE_SLACK for Oversubscription

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40379/#review107786
---


Seems the rebase caused some problem for your patch, some files are lost.


src/slave/slave.cpp (line 4460)


s/allocations/usage slack?


- Guangya Liu


On 十一月 24, 2015, 11:02 a.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40379/
> ---
> 
> (Updated 十一月 24, 2015, 11:02 a.m.)
> 
> 
> Review request for mesos and Guangya Liu.
> 
> 
> Bugs: MESOS-3930
> https://issues.apache.org/jira/browse/MESOS-3930
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In Optimistic Offer Phase 1, it introduce `RevocableInfo::type`: USAGE_SLACK 
> for Oversubscription and ALLOCATION_SLACK for Optimistic Offer. Slave helps 
> to update `RevocableInfo::type` for Oversubscription.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp 9055f2a 
> 
> Diff: https://reviews.apache.org/r/40379/diff/
> 
> 
> Testing
> ---
> 
> make (make check is on-going)
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 40379: [WIP] MESOS-3930: Set resource type as USAGE_SLACK for Oversubscription

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40379/#review107527
---



src/slave/slave.cpp (line 4417)


s/oversubscribable/USAGE_SLACK oversubscribable



src/slave/slave.cpp (line 4419)


I think that the oversubscribable resources should always has_revocable()? 
For which case does the oversubscribable resource do not has_revocable()? 
Caused by a bad resource estimitator? For such case, can we let slave throw 
exception?


- Guangya Liu


On 十一月 21, 2015, 11:26 a.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40379/
> ---
> 
> (Updated 十一月 21, 2015, 11:26 a.m.)
> 
> 
> Review request for mesos and Guangya Liu.
> 
> 
> Bugs: MESOS-3930
> https://issues.apache.org/jira/browse/MESOS-3930
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In Optimistic Offer Phase 1, it introduce `RevocableInfo::type`: USAGE_SLACK 
> for Oversubscription and ALLOCATION_SLACK for Optimistic Offer. Slave helps 
> to update `RevocableInfo::type` for Oversubscription.
> 
> 
> Diffs
> -
> 
>   src/slave/resource_estimators/fixed.cpp 305664c 
>   src/slave/slave.cpp d1126f0 
>   src/tests/oversubscription_tests.cpp 0d0bf7e 
> 
> Diff: https://reviews.apache.org/r/40379/diff/
> 
> 
> Testing
> ---
> 
> make (make check is on-going)
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 40379: [WIP] MESOS-3930: Set resource type as USAGE_SLACK for Oversubscription

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40379/#review107491
---



src/slave/resource_estimators/fixed.cpp (line 77)


This will introduce compatibility issue, I'd like to resolve this task 
(MESOS-3930) in document.


- Klaus Ma


On Nov. 21, 2015, 7:26 p.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40379/
> ---
> 
> (Updated Nov. 21, 2015, 7:26 p.m.)
> 
> 
> Review request for mesos and Guangya Liu.
> 
> 
> Bugs: MESOS-3930
> https://issues.apache.org/jira/browse/MESOS-3930
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In Optimistic Offer Phase 1, it introduce `RevocableInfo::type`: USAGE_SLACK 
> for Oversubscription and ALLOCATION_SLACK for Optimistic Offer. Slave helps 
> to update `RevocableInfo::type` for Oversubscription.
> 
> 
> Diffs
> -
> 
>   src/slave/resource_estimators/fixed.cpp 305664c 
>   src/slave/slave.cpp d1126f0 
>   src/tests/oversubscription_tests.cpp 0d0bf7e 
> 
> Diff: https://reviews.apache.org/r/40379/diff/
> 
> 
> Testing
> ---
> 
> make (make check is on-going)
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 40379: [WIP] MESOS-3930: Set resource type as USAGE_SLACK for Oversubscription

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40379/
---

(Updated Nov. 21, 2015, 7:26 p.m.)


Review request for mesos and Guangya Liu.


Changes
---

Update the diff passed `make check`


Bugs: MESOS-3930
https://issues.apache.org/jira/browse/MESOS-3930


Repository: mesos


Description
---

In Optimistic Offer Phase 1, it introduce `RevocableInfo::type`: USAGE_SLACK 
for Oversubscription and ALLOCATION_SLACK for Optimistic Offer. Slave helps to 
update `RevocableInfo::type` for Oversubscription.


Diffs (updated)
-

  src/slave/resource_estimators/fixed.cpp 305664c 
  src/slave/slave.cpp d1126f0 
  src/tests/oversubscription_tests.cpp 0d0bf7e 

Diff: https://reviews.apache.org/r/40379/diff/


Testing
---

make (make check is on-going)


Thanks,

Klaus Ma

Re: Review Request 40379: [WIP] MESOS-3930: Set resource type as USAGE_SLACK for Oversubscription

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40379/#review107492
---


Patch looks great!

Reviews applied: [40375, 40379]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Nov. 21, 2015, 11:26 a.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40379/
> ---
> 
> (Updated Nov. 21, 2015, 11:26 a.m.)
> 
> 
> Review request for mesos and Guangya Liu.
> 
> 
> Bugs: MESOS-3930
> https://issues.apache.org/jira/browse/MESOS-3930
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In Optimistic Offer Phase 1, it introduce `RevocableInfo::type`: USAGE_SLACK 
> for Oversubscription and ALLOCATION_SLACK for Optimistic Offer. Slave helps 
> to update `RevocableInfo::type` for Oversubscription.
> 
> 
> Diffs
> -
> 
>   src/slave/resource_estimators/fixed.cpp 305664c 
>   src/slave/slave.cpp d1126f0 
>   src/tests/oversubscription_tests.cpp 0d0bf7e 
> 
> Diff: https://reviews.apache.org/r/40379/diff/
> 
> 
> Testing
> ---
> 
> make (make check is on-going)
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 40379: [WIP] MESOS-3930: Set resource type as USAGE_SLACK for Oversubscription

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40379/#review107001
---



src/slave/slave.cpp (lines 4419 - 4427)


Suggest to add some comments for these newly added code, e.g., why do we 
set type as USAGE_SLACK? This will help other devs better understand this 
feature.


- Qian Zhang


On Nov. 17, 2015, 4:41 p.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40379/
> ---
> 
> (Updated Nov. 17, 2015, 4:41 p.m.)
> 
> 
> Review request for mesos and Guangya Liu.
> 
> 
> Bugs: MESOS-3930
> https://issues.apache.org/jira/browse/MESOS-3930
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In Optimistic Offer Phase 1, it introduce `RevocableInfo::type`: USAGE_SLACK 
> for Oversubscription and ALLOCATION_SLACK for Optimistic Offer. Slave helps 
> to update `RevocableInfo::type` for Oversubscription.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp d1126f00d947fdb4823b0c495335b743254ac7ee 
> 
> Diff: https://reviews.apache.org/r/40379/diff/
> 
> 
> Testing
> ---
> 
> make (make check is on-going)
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 40379: [WIP] MESOS-3930: Set resource type as USAGE_SLACK for Oversubscription

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40379/#review106811
---


Bad review!

Reviews applied: []

Error:
 No reviewers specified. Please find a reviewer by asking on JIRA or the 
mailing list.

- Mesos ReviewBot


On Nov. 17, 2015, 6:27 a.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40379/
> ---
> 
> (Updated Nov. 17, 2015, 6:27 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-3930
> https://issues.apache.org/jira/browse/MESOS-3930
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In Optimistic Offer Phase 1, it introduce `RevocableInfo::type`: USAGE_SLACK 
> for Oversubscription and ALLOCATION_SLACK for Optimistic Offer. Slave helps 
> to update `RevocableInfo::type` for Oversubscription.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp d1126f00d947fdb4823b0c495335b743254ac7ee 
> 
> Diff: https://reviews.apache.org/r/40379/diff/
> 
> 
> Testing
> ---
> 
> make (make check is on-going)
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Review Request 40379: [WIP] MESOS-3930: Set resource type as USAGE_SLACK for Oversubscription

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40379/
---

Review request for mesos.


Bugs: MESOS-3930
https://issues.apache.org/jira/browse/MESOS-3930


Repository: mesos


Description
---

In Optimistic Offer Phase 1, it introduce `RevocableInfo::type`: USAGE_SLACK 
for Oversubscription and ALLOCATION_SLACK for Optimistic Offer. Slave helps to 
update `RevocableInfo::type` for Oversubscription.


Diffs
-

  src/slave/slave.cpp d1126f00d947fdb4823b0c495335b743254ac7ee 

Diff: https://reviews.apache.org/r/40379/diff/


Testing
---

make (make check is on-going)


Thanks,

Klaus Ma