Re: Review Request 40413: Libprocess Reinit: Move ReaperProcess instantiation into process.cpp.

2016-10-12 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40413/
---

(Updated Oct. 12, 2016, 2:25 p.m.)


Review request for mesos, Greg Mann, Artem Harutyunyan, Joris Van Remoortere, 
and Vinod Kone.


Changes
---

Renamed `reaper_singleton` to `reaper`.  Some whitespace tweaks.


Bugs: MESOS-3934
https://issues.apache.org/jira/browse/MESOS-3934


Repository: mesos


Description
---

The reaper singleton must be unified with `process::initialize` so 
that it also falls under the scope of reinitialization.  The singleton 
must also not be guarded by `Once`.


Diffs (updated)
-

  3rdparty/libprocess/include/process/reap.hpp 
d7e0fa381df63a9ca7d438d5cea0631e1b0ec7ee 
  3rdparty/libprocess/src/process.cpp f1d746c52cfe659f5cd7da4b7a6424ff585619a3 
  3rdparty/libprocess/src/reap.cpp 5fc2a4d67a3a6fe56005fc2c2d16d4983d53b83a 

Diff: https://reviews.apache.org/r/40413/diff/


Testing
---

Tests done in a subsequent review.


Thanks,

Joseph Wu

Re: Review Request 40413: Libprocess Reinit: Move ReaperProcess instantiation into process.cpp.

2016-10-10 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40413/#review152048
---


Fix it, then Ship it!





3rdparty/libprocess/include/process/reap.hpp (line 54)


s/reaper_singleton/reaper/



3rdparty/libprocess/include/process/reap.hpp (line 57)


new line.



3rdparty/libprocess/src/reap.cpp (line 150)


new line.



3rdparty/libprocess/src/reap.cpp (line 154)


you do initilialize here but not in metrics process?


- Vinod Kone


On Aug. 10, 2016, 8:17 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40413/
> ---
> 
> (Updated Aug. 10, 2016, 8:17 p.m.)
> 
> 
> Review request for mesos, Greg Mann, Artem Harutyunyan, Joris Van Remoortere, 
> and Vinod Kone.
> 
> 
> Bugs: MESOS-3934
> https://issues.apache.org/jira/browse/MESOS-3934
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The reaper singleton must be unified with `process::initialize` so 
> that it also falls under the scope of reinitialization.  The singleton 
> must also not be guarded by `Once`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/reap.hpp 
> d7e0fa381df63a9ca7d438d5cea0631e1b0ec7ee 
>   3rdparty/libprocess/src/process.cpp 
> 629f1644bc0a263972ec9efc41890c33f9406a34 
>   3rdparty/libprocess/src/reap.cpp 5fc2a4d67a3a6fe56005fc2c2d16d4983d53b83a 
> 
> Diff: https://reviews.apache.org/r/40413/diff/
> 
> 
> Testing
> ---
> 
> Tests done in a subsequent review.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 40413: Libprocess Reinit: Move ReaperProcess instantiation into process.cpp.

2016-09-22 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40413/#review149998
---


Fix it, then Ship it!





3rdparty/libprocess/include/process/reap.hpp (line 53)


Single space between sentences?



3rdparty/libprocess/src/reap.cpp (line 118)


Is there a reason to have spaces in `> > >` here? We generally do not use 
spaces AFAICT.


- Greg Mann


On Aug. 10, 2016, 8:17 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40413/
> ---
> 
> (Updated Aug. 10, 2016, 8:17 p.m.)
> 
> 
> Review request for mesos, Greg Mann, Artem Harutyunyan, Joris Van Remoortere, 
> and Vinod Kone.
> 
> 
> Bugs: MESOS-3934
> https://issues.apache.org/jira/browse/MESOS-3934
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The reaper singleton must be unified with `process::initialize` so 
> that it also falls under the scope of reinitialization.  The singleton 
> must also not be guarded by `Once`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/reap.hpp 
> d7e0fa381df63a9ca7d438d5cea0631e1b0ec7ee 
>   3rdparty/libprocess/src/process.cpp 
> 629f1644bc0a263972ec9efc41890c33f9406a34 
>   3rdparty/libprocess/src/reap.cpp 5fc2a4d67a3a6fe56005fc2c2d16d4983d53b83a 
> 
> Diff: https://reviews.apache.org/r/40413/diff/
> 
> 
> Testing
> ---
> 
> Tests done in a subsequent review.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 40413: Libprocess Reinit: Move ReaperProcess instantiation into process.cpp.

2016-08-10 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40413/
---

(Updated Aug. 10, 2016, 1:17 p.m.)


Review request for mesos, Greg Mann, Artem Harutyunyan, Joris Van Remoortere, 
and Vinod Kone.


Changes
---

Rebase on whitespace change.


Bugs: MESOS-3934
https://issues.apache.org/jira/browse/MESOS-3934


Repository: mesos


Description
---

The reaper singleton must be unified with `process::initialize` so 
that it also falls under the scope of reinitialization.  The singleton 
must also not be guarded by `Once`.


Diffs (updated)
-

  3rdparty/libprocess/include/process/reap.hpp 
d7e0fa381df63a9ca7d438d5cea0631e1b0ec7ee 
  3rdparty/libprocess/src/process.cpp 629f1644bc0a263972ec9efc41890c33f9406a34 
  3rdparty/libprocess/src/reap.cpp 5fc2a4d67a3a6fe56005fc2c2d16d4983d53b83a 

Diff: https://reviews.apache.org/r/40413/diff/


Testing
---

Tests done in a subsequent review.


Thanks,

Joseph Wu

Re: Review Request 40413: Libprocess Reinit: Move ReaperProcess instantiation into process.cpp.

2016-08-08 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40413/
---

(Updated Aug. 8, 2016, 6:07 p.m.)


Review request for mesos, Greg Mann, Artem Harutyunyan, Joris Van Remoortere, 
and Vinod Kone.


Changes
---

Rebased on the Process ID change by Gaston.


Bugs: MESOS-3934
https://issues.apache.org/jira/browse/MESOS-3934


Repository: mesos


Description
---

The reaper singleton must be unified with `process::initialize` so 
that it also falls under the scope of reinitialization.  The singleton 
must also not be guarded by `Once`.


Diffs (updated)
-

  3rdparty/libprocess/include/process/reap.hpp 
1a9709c618c5ddc9d2b7492cc1855a11f1fc4fb9 
  3rdparty/libprocess/src/process.cpp 629f1644bc0a263972ec9efc41890c33f9406a34 
  3rdparty/libprocess/src/reap.cpp f8d2fdc3449744cfd6a974170484b676e8f3ac7b 

Diff: https://reviews.apache.org/r/40413/diff/


Testing
---

Tests done in a subsequent review.


Thanks,

Joseph Wu

Re: Review Request 40413: Libprocess Reinit: Move ReaperProcess instantiation into process.cpp.

2016-07-29 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40413/
---

(Updated July 29, 2016, 4:58 p.m.)


Review request for mesos, Greg Mann, Artem Harutyunyan, Joris Van Remoortere, 
and Vinod Kone.


Changes
---

Header update.


Bugs: MESOS-3934
https://issues.apache.org/jira/browse/MESOS-3934


Repository: mesos


Description
---

The reaper singleton must be unified with `process::initialize` so 
that it also falls under the scope of reinitialization.  The singleton 
must also not be guarded by `Once`.


Diffs (updated)
-

  3rdparty/libprocess/include/process/reap.hpp 
1a9709c618c5ddc9d2b7492cc1855a11f1fc4fb9 
  3rdparty/libprocess/src/process.cpp 7f331b812de2f0437838f48e0959441c8e04c358 
  3rdparty/libprocess/src/reap.cpp ac60c6d769076912293950432266c956d6c7e705 

Diff: https://reviews.apache.org/r/40413/diff/


Testing
---

Tests done in a subsequent review.


Thanks,

Joseph Wu

Re: Review Request 40413: Libprocess Reinit: Move ReaperProcess instantiation into process.cpp.

2016-07-28 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40413/#review143875
---




3rdparty/libprocess/include/process/reap.hpp (line 22)


I tend to prefer leaving includes when we explicitly make use of the type, 
as is the case with `Option` here. What do you think?


- Greg Mann


On July 14, 2016, 12:21 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40413/
> ---
> 
> (Updated July 14, 2016, 12:21 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3934
> https://issues.apache.org/jira/browse/MESOS-3934
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The reaper singleton must be unified with `process::initialize` so 
> that it also falls under the scope of reinitialization.  The singleton 
> must also not be guarded by `Once`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/reap.hpp 
> 1a9709c618c5ddc9d2b7492cc1855a11f1fc4fb9 
>   3rdparty/libprocess/src/process.cpp 
> 9661386afd4fddd1877d55941fa403afc9230280 
>   3rdparty/libprocess/src/reap.cpp ac60c6d769076912293950432266c956d6c7e705 
> 
> Diff: https://reviews.apache.org/r/40413/diff/
> 
> 
> Testing
> ---
> 
> Tests done in a subsequent review.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 40413: Libprocess Reinit: Move ReaperProcess instantiation into process.cpp.

2016-04-14 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40413/
---

(Updated April 14, 2016, 1:28 p.m.)


Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.


Changes
---

Reviving this chain...


Summary (updated)
-

Libprocess Reinit: Move ReaperProcess instantiation into process.cpp.


Bugs: MESOS-3934
https://issues.apache.org/jira/browse/MESOS-3934


Repository: mesos


Description (updated)
---

The reaper singleton must be unified with `process::initialize` so 
that it also falls under the scope of reinitialization.  The singleton 
must also not be guarded by `Once`.


Diffs (updated)
-

  3rdparty/libprocess/include/process/reap.hpp 
1a9709c618c5ddc9d2b7492cc1855a11f1fc4fb9 
  3rdparty/libprocess/src/process.cpp afeddec20495bb9621c3e26b0d425c9419654739 
  3rdparty/libprocess/src/reap.cpp 110386842d5eeccfbc4e48bfca88d79a9d087fb0 

Diff: https://reviews.apache.org/r/40413/diff/


Testing
---

Tests done in a subsequent review.


Thanks,

Joseph Wu