Re: Review Request 40469: Update Allocator interface to support dynamic roles

2015-12-10 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40469/#review109706 --- This looks like just the interface change; where's the

Re: Review Request 40469: Update Allocator interface to support dynamic roles

2015-12-10 Thread Yongqiao Wang
> On Dec. 10, 2015, 10:46 a.m., Adam B wrote: > > This looks like just the interface change; where's the (default/reference) > > implementation? > > Justify/delete the removeRole call. > > Consider (the lack of) backwards-compatibility for your allocator module > > API change. Refer to some

Re: Review Request 40469: Update Allocator interface to support dynamic roles

2015-12-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40469/#review109297 --- Patch looks great! Reviews applied: [40431, 40469] Passed

Re: Review Request 40469: Update Allocator interface to support dynamic roles

2015-12-07 Thread Yong Qiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40469/ --- (Updated Dec. 7, 2015, 10:12 a.m.) Review request for mesos, Adam B, Guangya

Re: Review Request 40469: Update Allocator interface to support dynamic roles

2015-12-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40469/#review109238 --- Bad patch! Reviews applied: [40431] Failed command:

Re: Review Request 40469: Update Allocator interface to support dynamic roles

2015-12-07 Thread Yong Qiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40469/ --- (Updated Dec. 8, 2015, 5:20 a.m.) Review request for mesos, Adam B, Guangya

Re: Review Request 40469: Update Allocator interface to support dynamic roles

2015-11-25 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40469/#review108079 --- I'm thinking we are going to build a RoleManager as I comments in

Re: Review Request 40469: Update Allocator interface to support dynamic roles

2015-11-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40469/#review107345 --- Patch looks great! Reviews applied: [40431, 40469] Passed

Re: Review Request 40469: Update Allocator interface to support dynamic roles

2015-11-19 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40469/#review107225 --- include/mesos/master/allocator.hpp (line 401)

Re: Review Request 40469: Update Allocator interface to support dynamic roles

2015-11-19 Thread Yong Qiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40469/ --- (Updated Nov. 20, 2015, 2:02 a.m.) Review request for mesos, Adam B, Guangya

Re: Review Request 40469: Update Allocator interface to support dynamic roles

2015-11-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40469/#review107162 --- Patch looks great! Reviews applied: [40431, 40469] Passed

Review Request 40469: Update Allocator interface to support dynamic roles

2015-11-18 Thread Yong Qiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40469/ --- Review request for mesos. Repository: mesos Description --- Update

Re: Review Request 40469: Update Allocator interface to support dynamic roles

2015-11-18 Thread Yong Qiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40469/ --- (Updated Nov. 19, 2015, 6:48 a.m.) Review request for mesos, Adam B and Qian