Re: Review Request 40469: Update Allocator interface to support dynamic roles

2015-12-10 Thread Adam B 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40469/#review109706
---


This looks like just the interface change; where's the (default/reference) 
implementation?
Justify/delete the removeRole call.
Consider (the lack of) backwards-compatibility for your allocator module API 
change.


include/mesos/master/allocator.hpp (line 409)


When is removeRole necessary? There aren't likely to be so many roles that 
we need to worry about saving memory by clearing out inactive roles.
If there are no frameworks registered with this role, it is inactive and 
won't affect allocator decisions.
If an admin wants to unspecify a weight for this user, they could just set 
it back to the default '1.0'



include/mesos/master/allocator.hpp (lines 412 - 418)


This is a breaking API change for the allocator, and any implementers of 
allocator modules will not only have to recompile their modules against the 
newer version, but will also have to implement this new function.

I wonder if it would be better to not make this a pure virtual function and 
instead have a default noop implementation, so module authors can recompile 
without error, and add dynamic role support to their own allocator at their 
leisure.

Either way, we'll need to make an announcement to the dev@ list and put a 
note in the upgrades doc.



src/master/allocator/mesos/hierarchical.cpp (lines 1057 - 1058)


Seems like there's a lot more missing here. Which subsequent review 
actually implements the new functions? Perhaps that patch should be merged into 
this one so we have a functional patch to commit at once.


- Adam B


On Dec. 7, 2015, 9:20 p.m., Yong Qiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40469/
> ---
> 
> (Updated Dec. 7, 2015, 9:20 p.m.)
> 
> 
> Review request for mesos, Adam B, Guangya Liu, Qian Zhang, and Jian Qiu.
> 
> 
> Bugs: MESOS-3956
> https://issues.apache.org/jira/browse/MESOS-3956
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Update Allocator interface to support dynamic roles
> 
> 
> Diffs
> -
> 
>   include/mesos/master/allocator.hpp 619ef01c3a7d640560653cfc1838dd09046d1da0 
>   src/master/allocator/mesos/allocator.hpp 
> 97ee80726ad155917811265a983258b0165d3451 
>   src/master/allocator/mesos/hierarchical.hpp 
> 99c742906874c30c39c159e58a65277ade3c07fd 
>   src/master/allocator/mesos/hierarchical.cpp 
> 5da825a1d578a9ee40b4985378fddb3c5fb3b416 
>   src/tests/allocator.hpp c7670525765491fe931a4ee38446fa7e9d79af42 
> 
> Diff: https://reviews.apache.org/r/40469/diff/
> 
> 
> Testing
> ---
> 
> Make check successfully.
> 
> 
> Thanks,
> 
> Yong Qiao Wang
> 
>

Re: Review Request 40469: Update Allocator interface to support dynamic roles

2015-12-10 Thread Yongqiao Wang 


> On Dec. 10, 2015, 10:46 a.m., Adam B wrote:
> > This looks like just the interface change; where's the (default/reference) 
> > implementation?
> > Justify/delete the removeRole call.
> > Consider (the lack of) backwards-compatibility for your allocator module 
> > API change.

Refer to some other Epic(such as quota), they always split the changes into 
some smaller bits, so I also follow up them and want to implement these 
functions in another sepratated JIRA MESOS-3943, I think it is easier to 
reivew. I will post another patch for the implementation, is it OK?

For backwards-compatibility, I have considered this issue before, but I think 
Mesos does not reach to 1.0 so interfaces changes is resonable, and also refer 
to the quota implementation, the functions setQuota()/removeQuota() also be 
defined to pure virtual functions. I think we should keep consistence.


> On Dec. 10, 2015, 10:46 a.m., Adam B wrote:
> > include/mesos/master/allocator.hpp, line 409
> > 
> >
> > When is removeRole necessary? There aren't likely to be so many roles 
> > that we need to worry about saving memory by clearing out inactive roles.
> > If there are no frameworks registered with this role, it is inactive 
> > and won't affect allocator decisions.
> > If an admin wants to unspecify a weight for this user, they could just 
> > set it back to the default '1.0'

For Dynamic Roles, I think it is make sence to provide a way to let cluster 
operator to remove a role due to the corresponding way is provided to add a 
role by /roles endpoint. But for Implicit Roles, this is non-necessary, I will 
update this patch to remove this function.


> On Dec. 10, 2015, 10:46 a.m., Adam B wrote:
> > include/mesos/master/allocator.hpp, lines 412-418
> > 
> >
> > This is a breaking API change for the allocator, and any implementers 
> > of allocator modules will not only have to recompile their modules against 
> > the newer version, but will also have to implement this new function.
> > 
> > I wonder if it would be better to not make this a pure virtual function 
> > and instead have a default noop implementation, so module authors can 
> > recompile without error, and add dynamic role support to their own 
> > allocator at their leisure.
> > 
> > Either way, we'll need to make an announcement to the dev@ list and put 
> > a note in the upgrades doc.

I suggest to make this funciton as a pure virtual function and let some other 
allocator to implement it, my reasons as below:
1. Mesos does not reach to 1.0, so the interface changes are resonable.
2. Like quota configuration(those functions are also be defined as pure virtual 
funcs in allocator.hpp), Weight dynamic update also is an important functions, 
I think it should be required for any mesos cluster.


Of couse, It is great to define this function with a default noop 
implementation for backwards-compatibility, I just confused for the consistence 
like quota done(setQuota()/removeQuota()). OK, let me know your further comment.


> On Dec. 10, 2015, 10:46 a.m., Adam B wrote:
> > src/master/allocator/mesos/hierarchical.cpp, lines 1057-1058
> > 
> >
> > Seems like there's a lot more missing here. Which subsequent review 
> > actually implements the new functions? Perhaps that patch should be merged 
> > into this one so we have a functional patch to commit at once.

I plan to implement these functions in JIRA MESOS-3943, If you think we should 
merge them together, I am happy to do that.


- Yongqiao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40469/#review109706
---


On Dec. 8, 2015, 5:20 a.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40469/
> ---
> 
> (Updated Dec. 8, 2015, 5:20 a.m.)
> 
> 
> Review request for mesos, Adam B, Guangya Liu, Qian Zhang, and Jian Qiu.
> 
> 
> Bugs: MESOS-3956
> https://issues.apache.org/jira/browse/MESOS-3956
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Update Allocator interface to support dynamic roles
> 
> 
> Diffs
> -
> 
>   include/mesos/master/allocator.hpp 619ef01c3a7d640560653cfc1838dd09046d1da0 
>   src/master/allocator/mesos/allocator.hpp 
> 97ee80726ad155917811265a983258b0165d3451 
>   src/master/allocator/mesos/hierarchical.hpp 
> 99c742906874c30c39c159e58a65277ade3c07fd 
>   src/master/allocator/mesos/hierarchical.cpp 
> 5da825a1d578a9ee40b4985378fddb3c5fb3b416 
>   src/tests/allocator.hpp

Re: Review Request 40469: Update Allocator interface to support dynamic roles

2015-12-08 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40469/#review109297
---


Patch looks great!

Reviews applied: [40431, 40469]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 8, 2015, 5:20 a.m., Yong Qiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40469/
> ---
> 
> (Updated Dec. 8, 2015, 5:20 a.m.)
> 
> 
> Review request for mesos, Adam B, Guangya Liu, Qian Zhang, and Jian Qiu.
> 
> 
> Bugs: MESOS-3956
> https://issues.apache.org/jira/browse/MESOS-3956
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Update Allocator interface to support dynamic roles
> 
> 
> Diffs
> -
> 
>   include/mesos/master/allocator.hpp 619ef01c3a7d640560653cfc1838dd09046d1da0 
>   src/master/allocator/mesos/allocator.hpp 
> 97ee80726ad155917811265a983258b0165d3451 
>   src/master/allocator/mesos/hierarchical.hpp 
> 99c742906874c30c39c159e58a65277ade3c07fd 
>   src/master/allocator/mesos/hierarchical.cpp 
> 5da825a1d578a9ee40b4985378fddb3c5fb3b416 
>   src/tests/allocator.hpp c7670525765491fe931a4ee38446fa7e9d79af42 
> 
> Diff: https://reviews.apache.org/r/40469/diff/
> 
> 
> Testing
> ---
> 
> Make check successfully.
> 
> 
> Thanks,
> 
> Yong Qiao Wang
> 
>

Re: Review Request 40469: Update Allocator interface to support dynamic roles

2015-12-07 Thread Yong Qiao Wang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40469/
---

(Updated Dec. 7, 2015, 10:12 a.m.)


Review request for mesos, Adam B, Guangya Liu, Qian Zhang, and Jian Qiu.


Bugs: MESOS-3956
https://issues.apache.org/jira/browse/MESOS-3956


Repository: mesos


Description
---

Update Allocator interface to support dynamic roles


Diffs (updated)
-

  include/mesos/master/allocator.hpp 619ef01c3a7d640560653cfc1838dd09046d1da0 
  src/master/allocator/mesos/allocator.hpp 
97ee80726ad155917811265a983258b0165d3451 
  src/master/allocator/mesos/hierarchical.hpp 
99c742906874c30c39c159e58a65277ade3c07fd 
  src/master/allocator/mesos/hierarchical.cpp 
5da825a1d578a9ee40b4985378fddb3c5fb3b416 
  src/tests/allocator.hpp c7670525765491fe931a4ee38446fa7e9d79af42 

Diff: https://reviews.apache.org/r/40469/diff/


Testing
---

Make check successfully.


Thanks,

Yong Qiao Wang

Re: Review Request 40469: Update Allocator interface to support dynamic roles

2015-12-07 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40469/#review109238
---


Bad patch!

Reviews applied: [40431]

Failed command: ./support/apply-review.sh -n -r 40431

Error:
 2015-12-08 01:04:32 URL:https://reviews.apache.org/r/40431/diff/raw/ 
[12531/12531] -> "40431.patch" [1]
Successfully applied: Move RoleInfo message out of allocator.proto

Currently role protobuf is defined in allocator.proto due to only the 
traditional DRF allocator uses roles as it’s first level of hierarchy, I think 
we should move it out and define it in a separated file as quota had in dynamic 
roles project, because role protobuf will also be used by master to persist.


Review: https://reviews.apache.org/r/40431
include/mesos/role/role.hpp:1:  A license header should appear on the file's  
first line starting with '// Licensed'.: /**
Total errors found: 1
Checking 9 files
Failed to commit patch

- Mesos ReviewBot


On Dec. 7, 2015, 10:12 a.m., Yong Qiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40469/
> ---
> 
> (Updated Dec. 7, 2015, 10:12 a.m.)
> 
> 
> Review request for mesos, Adam B, Guangya Liu, Qian Zhang, and Jian Qiu.
> 
> 
> Bugs: MESOS-3956
> https://issues.apache.org/jira/browse/MESOS-3956
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Update Allocator interface to support dynamic roles
> 
> 
> Diffs
> -
> 
>   include/mesos/master/allocator.hpp 619ef01c3a7d640560653cfc1838dd09046d1da0 
>   src/master/allocator/mesos/allocator.hpp 
> 97ee80726ad155917811265a983258b0165d3451 
>   src/master/allocator/mesos/hierarchical.hpp 
> 99c742906874c30c39c159e58a65277ade3c07fd 
>   src/master/allocator/mesos/hierarchical.cpp 
> 5da825a1d578a9ee40b4985378fddb3c5fb3b416 
>   src/tests/allocator.hpp c7670525765491fe931a4ee38446fa7e9d79af42 
> 
> Diff: https://reviews.apache.org/r/40469/diff/
> 
> 
> Testing
> ---
> 
> Make check successfully.
> 
> 
> Thanks,
> 
> Yong Qiao Wang
> 
>

Re: Review Request 40469: Update Allocator interface to support dynamic roles

2015-12-07 Thread Yong Qiao Wang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40469/
---

(Updated Dec. 8, 2015, 5:20 a.m.)


Review request for mesos, Adam B, Guangya Liu, Qian Zhang, and Jian Qiu.


Bugs: MESOS-3956
https://issues.apache.org/jira/browse/MESOS-3956


Repository: mesos


Description
---

Update Allocator interface to support dynamic roles


Diffs (updated)
-

  include/mesos/master/allocator.hpp 619ef01c3a7d640560653cfc1838dd09046d1da0 
  src/master/allocator/mesos/allocator.hpp 
97ee80726ad155917811265a983258b0165d3451 
  src/master/allocator/mesos/hierarchical.hpp 
99c742906874c30c39c159e58a65277ade3c07fd 
  src/master/allocator/mesos/hierarchical.cpp 
5da825a1d578a9ee40b4985378fddb3c5fb3b416 
  src/tests/allocator.hpp c7670525765491fe931a4ee38446fa7e9d79af42 

Diff: https://reviews.apache.org/r/40469/diff/


Testing
---

Make check successfully.


Thanks,

Yong Qiao Wang

Re: Review Request 40469: Update Allocator interface to support dynamic roles

2015-11-25 Thread Klaus Ma 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40469/#review108079
---


I'm thinking we are going to build a RoleManager as I comments in design doc; 
so only RoleManager will pass to allocator. Honestly, I did not want allocator 
to take so many responsiblity, it should focus on resource allocation. For the 
role management, I'd like to delegate it to RoleManager. And recently, there's 
a EPIC on implic role, RoleManager will also help to it. I have add a comment 
to its design doc to propose a role manager plugin.

- Klaus Ma


On Nov. 24, 2015, 10:39 a.m., Yong Qiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40469/
> ---
> 
> (Updated Nov. 24, 2015, 10:39 a.m.)
> 
> 
> Review request for mesos, Adam B, Guangya Liu, Qian Zhang, and Jian Qiu.
> 
> 
> Bugs: MESOS-3956
> https://issues.apache.org/jira/browse/MESOS-3956
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Update Allocator interface to support dynamic roles
> 
> 
> Diffs
> -
> 
>   include/mesos/master/allocator.hpp f76118bbf028610c330cebe937d81457fc67a6f3 
>   src/master/allocator/mesos/allocator.hpp 
> d2d32af227d66c4030becd4cd64b907a70d25f49 
>   src/master/allocator/mesos/hierarchical.hpp 
> 64ccf4164197e59d93d739fa2afbdee2cc2a1d23 
>   src/master/allocator/mesos/hierarchical.cpp 
> f2e3b639f210eb06c70584ee7294609d9fd978ad 
>   src/tests/allocator.hpp e0cb2e75e6cac41ae8d8ed1608f1d64e7c533e34 
> 
> Diff: https://reviews.apache.org/r/40469/diff/
> 
> 
> Testing
> ---
> 
> Make check successfully.
> 
> 
> Thanks,
> 
> Yong Qiao Wang
> 
>

Re: Review Request 40469: Update Allocator interface to support dynamic roles

2015-11-20 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40469/#review107345
---


Patch looks great!

Reviews applied: [40431, 40469]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Nov. 20, 2015, 2:02 a.m., Yong Qiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40469/
> ---
> 
> (Updated Nov. 20, 2015, 2:02 a.m.)
> 
> 
> Review request for mesos, Adam B, Guangya Liu, and Qian Zhang.
> 
> 
> Bugs: MESOS-3956
> https://issues.apache.org/jira/browse/MESOS-3956
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Update Allocator interface to support dynamic roles
> 
> 
> Diffs
> -
> 
>   include/mesos/master/allocator.hpp f76118bbf028610c330cebe937d81457fc67a6f3 
>   src/master/allocator/mesos/allocator.hpp 
> d2d32af227d66c4030becd4cd64b907a70d25f49 
>   src/master/allocator/mesos/hierarchical.hpp 
> 64ccf4164197e59d93d739fa2afbdee2cc2a1d23 
>   src/master/allocator/mesos/hierarchical.cpp 
> f2e3b639f210eb06c70584ee7294609d9fd978ad 
>   src/tests/allocator.hpp e0cb2e75e6cac41ae8d8ed1608f1d64e7c533e34 
> 
> Diff: https://reviews.apache.org/r/40469/diff/
> 
> 
> Testing
> ---
> 
> Make check successfully.
> 
> 
> Thanks,
> 
> Yong Qiao Wang
> 
>

Re: Review Request 40469: Update Allocator interface to support dynamic roles

2015-11-19 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40469/#review107225
---



include/mesos/master/allocator.hpp (line 401)


Second sentence seems redundant with the first.



include/mesos/master/allocator.hpp (line 409)


Redundant.


- Neil Conway


On Nov. 19, 2015, 6:54 a.m., Yong Qiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40469/
> ---
> 
> (Updated Nov. 19, 2015, 6:54 a.m.)
> 
> 
> Review request for mesos, Adam B, Guangya Liu, and Qian Zhang.
> 
> 
> Bugs: MESOS-3956
> https://issues.apache.org/jira/browse/MESOS-3956
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Update Allocator interface to support dynamic roles
> 
> 
> Diffs
> -
> 
>   include/mesos/master/allocator.hpp f76118bbf028610c330cebe937d81457fc67a6f3 
>   src/master/allocator/mesos/allocator.hpp 
> d2d32af227d66c4030becd4cd64b907a70d25f49 
>   src/master/allocator/mesos/hierarchical.hpp 
> 64ccf4164197e59d93d739fa2afbdee2cc2a1d23 
>   src/master/allocator/mesos/hierarchical.cpp 
> f2e3b639f210eb06c70584ee7294609d9fd978ad 
>   src/tests/allocator.hpp e0cb2e75e6cac41ae8d8ed1608f1d64e7c533e34 
> 
> Diff: https://reviews.apache.org/r/40469/diff/
> 
> 
> Testing
> ---
> 
> Make check successfully.
> 
> 
> Thanks,
> 
> Yong Qiao Wang
> 
>

Re: Review Request 40469: Update Allocator interface to support dynamic roles

2015-11-19 Thread Yong Qiao Wang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40469/
---

(Updated Nov. 20, 2015, 2:02 a.m.)


Review request for mesos, Adam B, Guangya Liu, and Qian Zhang.


Bugs: MESOS-3956
https://issues.apache.org/jira/browse/MESOS-3956


Repository: mesos


Description
---

Update Allocator interface to support dynamic roles


Diffs (updated)
-

  include/mesos/master/allocator.hpp f76118bbf028610c330cebe937d81457fc67a6f3 
  src/master/allocator/mesos/allocator.hpp 
d2d32af227d66c4030becd4cd64b907a70d25f49 
  src/master/allocator/mesos/hierarchical.hpp 
64ccf4164197e59d93d739fa2afbdee2cc2a1d23 
  src/master/allocator/mesos/hierarchical.cpp 
f2e3b639f210eb06c70584ee7294609d9fd978ad 
  src/tests/allocator.hpp e0cb2e75e6cac41ae8d8ed1608f1d64e7c533e34 

Diff: https://reviews.apache.org/r/40469/diff/


Testing
---

Make check successfully.


Thanks,

Yong Qiao Wang

Re: Review Request 40469: Update Allocator interface to support dynamic roles

2015-11-19 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40469/#review107162
---


Patch looks great!

Reviews applied: [40431, 40469]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Nov. 19, 2015, 6:54 a.m., Yong Qiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40469/
> ---
> 
> (Updated Nov. 19, 2015, 6:54 a.m.)
> 
> 
> Review request for mesos, Adam B, Guangya Liu, and Qian Zhang.
> 
> 
> Bugs: MESOS-3956
> https://issues.apache.org/jira/browse/MESOS-3956
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Update Allocator interface to support dynamic roles
> 
> 
> Diffs
> -
> 
>   include/mesos/master/allocator.hpp f76118bbf028610c330cebe937d81457fc67a6f3 
>   src/master/allocator/mesos/allocator.hpp 
> d2d32af227d66c4030becd4cd64b907a70d25f49 
>   src/master/allocator/mesos/hierarchical.hpp 
> 64ccf4164197e59d93d739fa2afbdee2cc2a1d23 
>   src/master/allocator/mesos/hierarchical.cpp 
> f2e3b639f210eb06c70584ee7294609d9fd978ad 
>   src/tests/allocator.hpp e0cb2e75e6cac41ae8d8ed1608f1d64e7c533e34 
> 
> Diff: https://reviews.apache.org/r/40469/diff/
> 
> 
> Testing
> ---
> 
> Make check successfully.
> 
> 
> Thanks,
> 
> Yong Qiao Wang
> 
>

Review Request 40469: Update Allocator interface to support dynamic roles

2015-11-18 Thread Yong Qiao Wang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40469/
---

Review request for mesos.


Repository: mesos


Description
---

Update Allocator interface to support dynamic roles


Diffs
-

  include/mesos/master/allocator.hpp f76118bbf028610c330cebe937d81457fc67a6f3 
  src/master/allocator/mesos/allocator.hpp 
d2d32af227d66c4030becd4cd64b907a70d25f49 
  src/master/allocator/mesos/hierarchical.hpp 
64ccf4164197e59d93d739fa2afbdee2cc2a1d23 
  src/master/allocator/mesos/hierarchical.cpp 
f2e3b639f210eb06c70584ee7294609d9fd978ad 
  src/tests/allocator.hpp e0cb2e75e6cac41ae8d8ed1608f1d64e7c533e34 

Diff: https://reviews.apache.org/r/40469/diff/


Testing
---


Thanks,

Yong Qiao Wang

Re: Review Request 40469: Update Allocator interface to support dynamic roles

2015-11-18 Thread Yong Qiao Wang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40469/
---

(Updated Nov. 19, 2015, 6:48 a.m.)


Review request for mesos, Adam B and Qian Zhang.


Bugs: MESOS-3956
https://issues.apache.org/jira/browse/MESOS-3956


Repository: mesos


Description
---

Update Allocator interface to support dynamic roles


Diffs
-

  include/mesos/master/allocator.hpp f76118bbf028610c330cebe937d81457fc67a6f3 
  src/master/allocator/mesos/allocator.hpp 
d2d32af227d66c4030becd4cd64b907a70d25f49 
  src/master/allocator/mesos/hierarchical.hpp 
64ccf4164197e59d93d739fa2afbdee2cc2a1d23 
  src/master/allocator/mesos/hierarchical.cpp 
f2e3b639f210eb06c70584ee7294609d9fd978ad 
  src/tests/allocator.hpp e0cb2e75e6cac41ae8d8ed1608f1d64e7c533e34 

Diff: https://reviews.apache.org/r/40469/diff/


Testing (updated)
---

Make check successfully.


Thanks,

Yong Qiao Wang