Re: Review Request 40936: Windows: Unified POSIX and Windows implementation of `shell.hpp`.

2016-01-28 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40936/#review116912 --- Ship it! Ship It! - Michael Park On Jan. 29, 2016, 12:04 a.m

Re: Review Request 40936: Windows: Unified POSIX and Windows implementation of `shell.hpp`.

2016-01-28 Thread Michael Park
> On Jan. 28, 2016, 10:41 a.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/shell.hpp, > > lines 41-55 > > > > > > I'm curious as to whether this struct is meant to be widely u

Re: Review Request 40936: Windows: Unified POSIX and Windows implementation of `shell.hpp`.

2016-01-28 Thread Michael Park
> On Jan. 28, 2016, 10:41 a.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/shell.hpp, > > lines 41-55 > > > > > > I'm curious as to whether this struct is meant to be widely u

Re: Review Request 40936: Windows: Unified POSIX and Windows implementation of `shell.hpp`.

2016-01-28 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40936/ --- (Updated Jan. 29, 2016, 12:04 a.m.) Review request for mesos, Alex Naparu, Alex

Re: Review Request 40936: Windows: Unified POSIX and Windows implementation of shell.hpp

2016-01-14 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40936/ --- (Updated Jan. 14, 2016, 6:31 p.m.) Review request for mesos, Alex Naparu, Alex

Re: Review Request 40936: Windows: Unified POSIX and Windows implementation of shell.hpp

2016-01-13 Thread Daniel Pravat
> On Jan. 6, 2016, 2:23 a.m., Alex Clemmer wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/shell.hpp, line > > 73 > > > > > > How semantically similar is this to the POSIX code? If it's very >

Re: Review Request 40936: Windows: Unified POSIX and Windows implementation of shell.hpp

2016-01-13 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40936/ --- (Updated Jan. 13, 2016, 7:14 p.m.) Review request for mesos, Alex Naparu, Alex

Re: Review Request 40936: Windows: Unified POSIX and Windows implementation of shell.hpp

2015-12-22 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40936/ --- (Updated Dec. 23, 2015, 7:17 a.m.) Review request for mesos, Alex Naparu, Alex

Re: Review Request 40936: Windows: Unified POSIX and Windows implementation of shell.hpp

2015-12-21 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40936/ --- (Updated Dec. 22, 2015, 2:32 a.m.) Review request for mesos, Alex Naparu, Alex