Re: Review Request 41003: Logger Module: Add the SandboxContainerLogger, the default ContainerLogger implementation.

2015-12-29 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41003/#review112200 --- Ship it! I'll fix the indents and commit, thanks! src/slave/cont

Re: Review Request 41003: Logger Module: Add the SandboxContainerLogger, the default ContainerLogger implementation.

2015-12-21 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41003/ --- (Updated Dec. 21, 2015, 4:49 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 41003: Logger Module: Add the SandboxContainerLogger, the default ContainerLogger implementation.

2015-12-20 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41003/ --- (Updated Dec. 20, 2015, 4:39 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 41003: Logger Module: Add the SandboxContainerLogger, the default ContainerLogger implementation.

2015-12-17 Thread Joseph Wu
> On Dec. 16, 2015, 5:23 p.m., Benjamin Hindman wrote: > > src/slave/container_loggers/sandbox.cpp, line 55 > > > > > > Is this comment useful? Is there something else here you want to > > capture? Removed this comm

Re: Review Request 41003: Logger Module: Add the SandboxContainerLogger, the default ContainerLogger implementation.

2015-12-17 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41003/ --- (Updated Dec. 17, 2015, 12:14 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 41003: Logger Module: Add the SandboxContainerLogger, the default ContainerLogger implementation.

2015-12-16 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41003/#review110827 --- Ship it! src/slave/container_loggers/sandbox.hpp (line 44)

Re: Review Request 41003: Logger Module: Add the SandboxContainerLogger, the default ContainerLogger implementation.

2015-12-15 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41003/ --- (Updated Dec. 15, 2015, 12:39 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 41003: Logger Module: Add the SandboxContainerLogger, the default ContainerLogger implementation.

2015-12-15 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41003/ --- (Updated Dec. 15, 2015, 11:25 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 41003: Logger Module: Add the SandboxContainerLogger, the default ContainerLogger implementation.

2015-12-14 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41003/ --- (Updated Dec. 14, 2015, 3:46 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 41003: Logger Module: Add the SandboxContainerLogger, the default ContainerLogger implementation.

2015-12-11 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41003/ --- (Updated Dec. 11, 2015, 4:39 p.m.) Review request for mesos, Benjamin Hindman,