Re: Review Request 41111: Logger Module: Add test for default executor/task stdout/stderr logging behavior (to sandbox).

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4/
---

(Updated Dec. 22, 2015, 1:09 p.m.)


Review request for mesos, Benjamin Hindman and Artem Harutyunyan.


Changes
---

Rebase.


Bugs: MESOS-4087
https://issues.apache.org/jira/browse/MESOS-4087


Repository: mesos


Description
---

`ContainerLoggerTest.DefaultToSandbox` is a regression test which checks the 
existing logging behavior, prior to introducing/using the `ContainerLogger` 
module.  As of this patch, the `ContainerLogger` is not actually being tested.


Diffs (updated)
-

  src/Makefile.am cf7f950c0c320a6c8e956409a35a7f47d905f71d 
  src/tests/container_logger_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/4/diff/


Testing
---

make check


Thanks,

Joseph Wu

Re: Review Request 41111: Logger Module: Add test for default executor/task stdout/stderr logging behavior (to sandbox).

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4/
---

(Updated Dec. 17, 2015, 12:14 p.m.)


Review request for mesos, Benjamin Hindman and Artem Harutyunyan.


Changes
---

Renamed some test variables.


Bugs: MESOS-4087
https://issues.apache.org/jira/browse/MESOS-4087


Repository: mesos


Description
---

`ContainerLoggerTest.DefaultToSandbox` is a regression test which checks the 
existing logging behavior, prior to introducing/using the `ContainerLogger` 
module.  As of this patch, the `ContainerLogger` is not actually being tested.


Diffs (updated)
-

  src/Makefile.am e6d48dc16135b5d147d036e851422686eff7d5ef 
  src/tests/container_logger_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/4/diff/


Testing
---

make check


Thanks,

Joseph Wu

Re: Review Request 41111: Logger Module: Add test for default executor/task stdout/stderr logging behavior (to sandbox).

[Benjamin Hindman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4/#review110847
---

Ship it!



src/tests/container_logger_tests.cpp (line 78)


s/agent_flags/flags/



src/tests/container_logger_tests.cpp (line 87)


s/agent/slave/



src/tests/container_logger_tests.cpp (lines 114 - 116)


This fits on one line, copy paste bug?



src/tests/container_logger_tests.cpp (line 129)


s/sandboxPath/sandboxDirectory/


- Benjamin Hindman


On Dec. 12, 2015, 12:39 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4/
> ---
> 
> (Updated Dec. 12, 2015, 12:39 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Artem Harutyunyan.
> 
> 
> Bugs: MESOS-4087
> https://issues.apache.org/jira/browse/MESOS-4087
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> `ContainerLoggerTest.DefaultToSandbox` is a regression test which checks the 
> existing logging behavior, prior to introducing/using the `ContainerLogger` 
> module.  As of this patch, the `ContainerLogger` is not actually being tested.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 9762f8567e32d70b8df2d694a1fef5c692fc730e 
>   src/tests/container_logger_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/4/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 41111: Logger Module: Add test for default executor/task stdout/stderr logging behavior (to sandbox).

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4/
---

(Updated Dec. 11, 2015, 4:39 p.m.)


Review request for mesos, Benjamin Hindman and Artem Harutyunyan.


Changes
---

Rename from ExecutorLogger to ContainerLogger.


Bugs: MESOS-4087
https://issues.apache.org/jira/browse/MESOS-4087


Repository: mesos


Description (updated)
---

`ContainerLoggerTest.DefaultToSandbox` is a regression test which checks the 
existing logging behavior, prior to introducing/using the `ContainerLogger` 
module.  As of this patch, the `ContainerLogger` is not actually being tested.


Diffs (updated)
-

  src/Makefile.am 9762f8567e32d70b8df2d694a1fef5c692fc730e 
  src/tests/container_logger_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/4/diff/


Testing
---

make check


Thanks,

Joseph Wu