Re: Review Request 41789: Add put method for http PUT request.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41789/ --- (Updated Jan. 4, 2016, 11:22 a.m.) Review request for mesos, Adam B, Joerg Schad, Joris Van Remoortere, Neil Conway, and Qian Zhang. Changes --- Rebase. Bugs: MESOS-4200 https://issues.apache.org/jira/browse/MESOS-4200 Repository: mesos Description --- Add put method for http PUT request. Note: This is a tempory, and only created for #41681 dependency. The same patch https://reviews.apache.org/r/39466/ has be posted, I have talked with Joerg owner of that RR to speed up that ticket. After that RR commit, then we can discard this. Diffs (updated) - 3rdparty/libprocess/include/process/http.hpp 404770f2d1d0cb8ab43fcdd25e64d0f955c9e3de 3rdparty/libprocess/src/http.cpp 2893d914c9092d7f03d3fd35f3118a78e2c6b9f7 Diff: https://reviews.apache.org/r/41789/diff/ Testing --- Make & Make check successfully. Thanks, Yongqiao Wang
Re: Review Request 41789: Add put method for http PUT request.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41789/ --- (Updated Jan. 4, 2016, 1:53 p.m.) Review request for mesos, Adam B, Joerg Schad, Joris Van Remoortere, Neil Conway, and Qian Zhang. Changes --- Rebase. Bugs: MESOS-4200 https://issues.apache.org/jira/browse/MESOS-4200 Repository: mesos Description --- Add put method for http PUT request. Note: This is a tempory, and only created for #41681 dependency. The same patch https://reviews.apache.org/r/39466/ has be posted, I have talked with Joerg owner of that RR to speed up that ticket. After that RR commit, then we can discard this. Diffs (updated) - 3rdparty/libprocess/include/process/http.hpp ed708fe4b0006782a19f9c61603f152e32a02e8e 3rdparty/libprocess/src/http.cpp 06231d96c6c99cada0cd46d6ef1e3f64039215c2 Diff: https://reviews.apache.org/r/41789/diff/ Testing --- Make & Make check successfully. Thanks, Yongqiao Wang
Re: Review Request 41789: Add put method for http PUT request.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41789/ --- (Updated Jan. 4, 2016, 1:50 a.m.) Review request for mesos, Adam B, Joerg Schad, Joris Van Remoortere, Neil Conway, and Qian Zhang. Bugs: MESOS-4200 https://issues.apache.org/jira/browse/MESOS-4200 Repository: mesos Description (updated) --- Add put method for http PUT request. Note: This is a tempory, and only created for #41681 dependency. The same patch https://reviews.apache.org/r/39466/ has be posted, I have talked with Joerg owner of that RR to speed up that ticket. After that RR commit, then we can discard this. Diffs - 3rdparty/libprocess/include/process/http.hpp f0666f0fa48c4f3a98332d12066561a02a715236 3rdparty/libprocess/src/http.cpp e937df6875c8024ea9c178833b9faceede990969 Diff: https://reviews.apache.org/r/41789/diff/ Testing --- Make & Make check successfully. Thanks, Yongqiao Wang
Re: Review Request 41789: Add put method for http PUT request.
> On Jan. 3, 2016, 10:48 a.m., Joerg Schad wrote: > > This pretty much duplicates https://reviews.apache.org/r/39466/ (except > > also has a test case). Even though the long term approach should be to > > replace all the individual http method call with a general one (accepting a > > Request object), we should decide which of these reviews we want to > > commit/focus on right now. > > Joerg Schad wrote: > Ah saw just above comment about this being tempory, would be good to add > that in the description . Thanks :-). Thank Joerg for your comments. I think for the short term we should commit https://reviews.apache.org/r/39466/ firstly, because current there is an urgent test case needs it. After that, we can consider to replace all the individual http method call with a general one. - Yongqiao --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41789/#review112445 --- On Jan. 4, 2016, 1:50 a.m., Yongqiao Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41789/ > --- > > (Updated Jan. 4, 2016, 1:50 a.m.) > > > Review request for mesos, Adam B, Joerg Schad, Joris Van Remoortere, Neil > Conway, and Qian Zhang. > > > Bugs: MESOS-4200 > https://issues.apache.org/jira/browse/MESOS-4200 > > > Repository: mesos > > > Description > --- > > Add put method for http PUT request. > > Note: This is a tempory, and only created for #41681 dependency. The same > patch https://reviews.apache.org/r/39466/ has be posted, I have talked with > Joerg owner of that RR to speed up that ticket. After that RR commit, then we > can discard this. > > > Diffs > - > > 3rdparty/libprocess/include/process/http.hpp > f0666f0fa48c4f3a98332d12066561a02a715236 > 3rdparty/libprocess/src/http.cpp e937df6875c8024ea9c178833b9faceede990969 > > Diff: https://reviews.apache.org/r/41789/diff/ > > > Testing > --- > > Make & Make check successfully. > > > Thanks, > > Yongqiao Wang > >
Re: Review Request 41789: Add put method for http PUT request.
> On Jan. 3, 2016, 10:48 a.m., Joerg Schad wrote: > > This pretty much duplicates https://reviews.apache.org/r/39466/ (except > > also has a test case). Even though the long term approach should be to > > replace all the individual http method call with a general one (accepting a > > Request object), we should decide which of these reviews we want to > > commit/focus on right now. Ah saw just above comment about this being tempory, would be good to add that in the description . Thanks :-). - Joerg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41789/#review112445 --- On Jan. 3, 2016, 10:38 a.m., Yongqiao Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41789/ > --- > > (Updated Jan. 3, 2016, 10:38 a.m.) > > > Review request for mesos, Adam B, Joerg Schad, Joris Van Remoortere, Neil > Conway, and Qian Zhang. > > > Bugs: MESOS-4200 > https://issues.apache.org/jira/browse/MESOS-4200 > > > Repository: mesos > > > Description > --- > > Add put method for http PUT request. > > > Diffs > - > > 3rdparty/libprocess/include/process/http.hpp > f0666f0fa48c4f3a98332d12066561a02a715236 > 3rdparty/libprocess/src/http.cpp e937df6875c8024ea9c178833b9faceede990969 > > Diff: https://reviews.apache.org/r/41789/diff/ > > > Testing > --- > > Make & Make check successfully. > > > Thanks, > > Yongqiao Wang > >
Re: Review Request 41789: Add put method for http PUT request.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41789/#review112445 --- This pretty much duplicates https://reviews.apache.org/r/39466/ (except also has a test case). Even though the long term approach should be to replace all the individual http method call with a general one (accepting a Request object), we should decide which of these reviews we want to commit/focus on right now. - Joerg Schad On Jan. 3, 2016, 10:38 a.m., Yongqiao Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41789/ > --- > > (Updated Jan. 3, 2016, 10:38 a.m.) > > > Review request for mesos, Adam B, Joerg Schad, Joris Van Remoortere, Neil > Conway, and Qian Zhang. > > > Bugs: MESOS-4200 > https://issues.apache.org/jira/browse/MESOS-4200 > > > Repository: mesos > > > Description > --- > > Add put method for http PUT request. > > > Diffs > - > > 3rdparty/libprocess/include/process/http.hpp > f0666f0fa48c4f3a98332d12066561a02a715236 > 3rdparty/libprocess/src/http.cpp e937df6875c8024ea9c178833b9faceede990969 > > Diff: https://reviews.apache.org/r/41789/diff/ > > > Testing > --- > > Make & Make check successfully. > > > Thanks, > > Yongqiao Wang > >
Review Request 41789: Add put method for http PUT request.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41789/ --- Review request for mesos, Adam B, Neil Conway, and Qian Zhang. Bugs: MESOS-4200 https://issues.apache.org/jira/browse/MESOS-4200 Repository: mesos Description --- Add put method for http PUT request. Diffs - 3rdparty/libprocess/include/process/http.hpp f0666f0fa48c4f3a98332d12066561a02a715236 3rdparty/libprocess/src/http.cpp e937df6875c8024ea9c178833b9faceede990969 Diff: https://reviews.apache.org/r/41789/diff/ Testing --- Make & Make check successfully. Thanks, Yongqiao Wang
Re: Review Request 41789: Add put method for http PUT request.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41789/#review112293 --- May need to refer to https://issues.apache.org/jira/browse/MESOS-3763 - Jian Qiu On 十二月 30, 2015, 8:08 a.m., Yongqiao Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41789/ > --- > > (Updated 十二月 30, 2015, 8:08 a.m.) > > > Review request for mesos, Adam B, Neil Conway, and Qian Zhang. > > > Bugs: MESOS-4200 > https://issues.apache.org/jira/browse/MESOS-4200 > > > Repository: mesos > > > Description > --- > > Add put method for http PUT request. > > > Diffs > - > > 3rdparty/libprocess/include/process/http.hpp > f0666f0fa48c4f3a98332d12066561a02a715236 > 3rdparty/libprocess/src/http.cpp e937df6875c8024ea9c178833b9faceede990969 > > Diff: https://reviews.apache.org/r/41789/diff/ > > > Testing > --- > > Make & Make check successfully. > > > Thanks, > > Yongqiao Wang > >
Re: Review Request 41789: Add put method for http PUT request.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41789/ --- (Updated Dec. 30, 2015, 11:55 a.m.) Review request for mesos, Adam B, Neil Conway, and Qian Zhang. Changes --- Rebase. Bugs: MESOS-4200 https://issues.apache.org/jira/browse/MESOS-4200 Repository: mesos Description --- Add put method for http PUT request. Diffs (updated) - 3rdparty/libprocess/include/process/http.hpp f0666f0fa48c4f3a98332d12066561a02a715236 3rdparty/libprocess/src/http.cpp e937df6875c8024ea9c178833b9faceede990969 Diff: https://reviews.apache.org/r/41789/diff/ Testing --- Make & Make check successfully. Thanks, Yongqiao Wang
Re: Review Request 41789: Add put method for http PUT request.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41789/#review112294 --- Patch looks great! Reviews applied: [41597, 41681, 41789] Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh - Mesos ReviewBot On Dec. 30, 2015, 8:34 a.m., Yongqiao Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41789/ > --- > > (Updated Dec. 30, 2015, 8:34 a.m.) > > > Review request for mesos, Adam B, Neil Conway, and Qian Zhang. > > > Bugs: MESOS-4200 > https://issues.apache.org/jira/browse/MESOS-4200 > > > Repository: mesos > > > Description > --- > > Add put method for http PUT request. > > > Diffs > - > > 3rdparty/libprocess/include/process/http.hpp > f0666f0fa48c4f3a98332d12066561a02a715236 > 3rdparty/libprocess/src/http.cpp e937df6875c8024ea9c178833b9faceede990969 > > Diff: https://reviews.apache.org/r/41789/diff/ > > > Testing > --- > > Make & Make check successfully. > > > Thanks, > > Yongqiao Wang > >
Re: Review Request 41789: Add put method for http PUT request.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41789/ --- (Updated Dec. 30, 2015, 8:34 a.m.) Review request for mesos, Adam B, Neil Conway, and Qian Zhang. Changes --- Rebase. Bugs: MESOS-4200 https://issues.apache.org/jira/browse/MESOS-4200 Repository: mesos Description --- Add put method for http PUT request. Diffs (updated) - 3rdparty/libprocess/include/process/http.hpp f0666f0fa48c4f3a98332d12066561a02a715236 3rdparty/libprocess/src/http.cpp e937df6875c8024ea9c178833b9faceede990969 Diff: https://reviews.apache.org/r/41789/diff/ Testing --- Make & Make check successfully. Thanks, Yongqiao Wang
Re: Review Request 41789: Add put method for http PUT request.
> On Dec. 30, 2015, 8:17 a.m., Jian Qiu wrote: > > May need to refer to https://issues.apache.org/jira/browse/MESOS-3763 Yes, I have noticed that ticket, but I found that patch does not work now, so I post a new patch to contiue my test coding. I have email to the owner of that ticket, and after he addressed and committed that ticket, I will depend on that issue rather than this RR. - Yongqiao --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41789/#review112293 --- On Dec. 30, 2015, 11:55 a.m., Yongqiao Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41789/ > --- > > (Updated Dec. 30, 2015, 11:55 a.m.) > > > Review request for mesos, Adam B, Neil Conway, and Qian Zhang. > > > Bugs: MESOS-4200 > https://issues.apache.org/jira/browse/MESOS-4200 > > > Repository: mesos > > > Description > --- > > Add put method for http PUT request. > > > Diffs > - > > 3rdparty/libprocess/include/process/http.hpp > f0666f0fa48c4f3a98332d12066561a02a715236 > 3rdparty/libprocess/src/http.cpp e937df6875c8024ea9c178833b9faceede990969 > > Diff: https://reviews.apache.org/r/41789/diff/ > > > Testing > --- > > Make & Make check successfully. > > > Thanks, > > Yongqiao Wang > >
