Re: Review Request 41857: Got evictable executors.

2016-03-10 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41857/ --- (Updated March 11, 2016, 2:52 p.m.) Review request for mesos, Ben Mahler, Guang

Re: Review Request 41857: Got evictable executors.

2016-01-11 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41857/ --- (Updated Jan. 11, 2016, 8:18 p.m.) Review request for mesos, Ben Mahler, Guangy

Re: Review Request 41857: Got evictable executors.

2016-01-09 Thread Klaus Ma
> On Jan. 4, 2016, 4:21 p.m., Guangya Liu wrote: > > src/slave/slave.cpp, line 3954 > > > > > > Here should be requested.stateless().reserved() Using `allocationSlackable` for `stateless().reserved()`. > On Jan.

Re: Review Request 41857: Got evictable executors.

2016-01-09 Thread Klaus Ma
> On Jan. 8, 2016, 4:36 p.m., Jian Qiu wrote: > > src/slave/slave.cpp, line 3985 > > > > > > I am not sure whether this situation will happen, because it means a > > task using allocation slack and is waiting for e

Re: Review Request 41857: Got evictable executors.

2016-01-09 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41857/ --- (Updated Jan. 9, 2016, 5:06 p.m.) Review request for mesos, Ben Mahler, Guangya

Re: Review Request 41857: Got evictable executors.

2016-01-08 Thread Klaus Ma
> On Jan. 8, 2016, 4:36 p.m., Jian Qiu wrote: > > src/slave/slave.cpp, line 3967 > > > > > > this check may not be necessary because resources cannot be negative? Yes; it won't be negative, but it'll return first r

Re: Review Request 41857: Got evictable executors.

2016-01-08 Thread Jian Qiu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41857/#review113430 --- src/slave/slave.cpp (line 3963)

Re: Review Request 41857: Got evictable executors.

2016-01-07 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41857/ --- (Updated Jan. 8, 2016, 2:54 p.m.) Review request for mesos, Ben Mahler, Guangya