Re: Review Request 42342: Added a new test cases for revive offer.

2016-04-13 Thread Guangya Liu
> On 四月 13, 2016, 7:37 a.m., Alexander Rukletsov wrote: > > Thanks Alex, I create a patch here https://reviews.apache.org/r/46140/ - Guangya --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42

Re: Review Request 42342: Added a new test cases for revive offer.

2016-04-13 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42342/#review128627 --- src/tests/hierarchical_allocator_tests.cpp (line 3040)

Re: Review Request 42342: Added a new test cases for revive offer.

2016-04-12 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42342/#review128511 --- Ship it! Ship It! - Vinod Kone On April 10, 2016, 1:18 p.m.,

Re: Review Request 42342: Added a new test cases for revive offer.

2016-04-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42342/#review128044 --- Patch looks great! Reviews applied: [39628, 42342] Passed comman

Re: Review Request 42342: Added a new test cases for revive offer.

2016-04-10 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42342/ --- (Updated 四月 10, 2016, 1:18 p.m.) Review request for mesos, Alexander Rukletsov,

Re: Review Request 42342: Added a new test cases for revive offer.

2016-02-10 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42342/#review118646 --- Ship it! Ship It! - haosdent huang On Feb. 10, 2016, 5:09 a.

Re: Review Request 42342: Added a new test cases for revive offer.

2016-02-10 Thread Guangya Liu
> On 二月 10, 2016, 11:32 a.m., haosdent huang wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 2409 > > > > > > should we settle before `advance` I think it should be OK as long as the `settle` is before

Re: Review Request 42342: Added a new test cases for revive offer.

2016-02-10 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42342/#review118627 --- src/tests/hierarchical_allocator_tests.cpp (line 2409)

Re: Review Request 42342: Added a new test cases for revive offer.

2016-02-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42342/#review118626 --- Patch looks great! Reviews applied: [39628, 42342] Passed comman

Re: Review Request 42342: Added a new test cases for revive offer.

2016-02-09 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42342/ --- (Updated 二月 10, 2016, 5:09 a.m.) Review request for mesos, Ben Mahler and Vinod

Re: Review Request 42342: Added a new test cases for revive offer.

2016-01-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42342/#review114844 --- Patch looks great! Reviews applied: [39628, 42342] Passed command

Re: Review Request 42342: Added a new test cases for revive offer.

2016-01-15 Thread Guangya Liu
> On 一月 15, 2016, 6:46 p.m., Vinod Kone wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 1933 > > > > > > s/filter1000s/filters/ I want to hightlight that this is a 1000s filter as I saw that we also hav

Re: Review Request 42342: Added a new test cases for revive offer.

2016-01-15 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42342/ --- (Updated 一月 16, 2016, 2:52 a.m.) Review request for mesos, Ben Mahler and Vinod

Re: Review Request 42342: Added a new test cases for revive offer.

2016-01-15 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42342/#review114747 --- src/tests/hierarchical_allocator_tests.cpp (line 1906)

Re: Review Request 42342: Added a new test cases for revive offer.

2016-01-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42342/#review114698 --- Patch looks great! Reviews applied: [39628, 42342] Passed command

Review Request 42342: Added a new test cases for revive offer.

2016-01-14 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42342/ --- Review request for mesos, Ben Mahler and Vinod Kone. Bugs: MESOS-4387 https