Re: Review Request 42589: Added test case for allocator recover with Quota.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42589/#review119138 --- Patch looks great! Reviews applied: [42535, 42589] Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Feb. 13, 2016, 3:15 a.m., Klaus Ma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42589/ > --- > > (Updated Feb. 13, 2016, 3:15 a.m.) > > > Review request for mesos, Alexander Rukletsov, Ben Mahler, and Joris Van > Remoortere. > > > Repository: mesos > > > Description > --- > > Added test case for allocator recover with Quota. > > > Diffs > - > > src/tests/hierarchical_allocator_tests.cpp > 990f3723d52dfeaa19d5eb0603c0fc7eb2b362c7 > > Diff: https://reviews.apache.org/r/42589/diff/ > > > Testing > --- > > make > make check GTEST_FILTER="HierarchicalAllocatorTest.RecoverWithQuota" (CHECK() > failed without fix) > > > Thanks, > > Klaus Ma > >
Re: Review Request 42589: Added test case for allocator recover with Quota.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42589/ --- (Updated Feb. 13, 2016, 11:15 a.m.) Review request for mesos, Alexander Rukletsov, Ben Mahler, and Joris Van Remoortere. Changes --- rebase and address comments. Repository: mesos Description --- Added test case for allocator recover with Quota. Diffs (updated) - src/tests/hierarchical_allocator_tests.cpp 990f3723d52dfeaa19d5eb0603c0fc7eb2b362c7 Diff: https://reviews.apache.org/r/42589/diff/ Testing --- make make check GTEST_FILTER="HierarchicalAllocatorTest.RecoverWithQuota" (CHECK() failed without fix) Thanks, Klaus Ma
Re: Review Request 42589: Added test case for allocator recover with Quota.
> On Feb. 1, 2016, 7:57 p.m., Alexander Rukletsov wrote: > > What is the use case you want to test here? Specifically, why do you test > > *both* resume paths simulataneously? Will the outcome of the test change if > > you remove one of those? This is the test case for https://reviews.apache.org/r/42535 ; without r42535, this test will crash. - Klaus --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42589/#review117197 --- On Jan. 21, 2016, 2:27 p.m., Klaus Ma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42589/ > --- > > (Updated Jan. 21, 2016, 2:27 p.m.) > > > Review request for mesos, Alexander Rukletsov, Ben Mahler, and Joris Van > Remoortere. > > > Repository: mesos > > > Description > --- > > Added test case for allocator recover with Quota. > > > Diffs > - > > src/tests/hierarchical_allocator_tests.cpp > 953712149bd951789beb29c72779c4ac65aa48dc > > Diff: https://reviews.apache.org/r/42589/diff/ > > > Testing > --- > > make > make check GTEST_FILTER="HierarchicalAllocatorTest.RecoverWithQuota" (CHECK() > failed without fix) > > > Thanks, > > Klaus Ma > >
Re: Review Request 42589: Added test case for allocator recover with Quota.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42589/#review116725 --- ping AlexR/Joris, can you help to review this test case for allocator recover with Quota? - Klaus Ma On Jan. 21, 2016, 2:27 p.m., Klaus Ma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42589/ > --- > > (Updated Jan. 21, 2016, 2:27 p.m.) > > > Review request for mesos, Alexander Rukletsov, Ben Mahler, and Joris Van > Remoortere. > > > Repository: mesos > > > Description > --- > > Added test case for allocator recover with Quota. > > > Diffs > - > > src/tests/hierarchical_allocator_tests.cpp > 953712149bd951789beb29c72779c4ac65aa48dc > > Diff: https://reviews.apache.org/r/42589/diff/ > > > Testing > --- > > make > make check GTEST_FILTER="HierarchicalAllocatorTest.RecoverWithQuota" (CHECK() > failed without fix) > > > Thanks, > > Klaus Ma > >
Review Request 42589: Added test case for allocator recover with Quota.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42589/ --- Review request for mesos, Alexander Rukletsov, Ben Mahler, and Joris Van Remoortere. Repository: mesos Description --- Added test case for allocator recover with Quota. Diffs - src/tests/hierarchical_allocator_tests.cpp 953712149bd951789beb29c72779c4ac65aa48dc Diff: https://reviews.apache.org/r/42589/diff/ Testing --- make make check GTEST_FILTER="HierarchicalAllocatorTest.RecoverWithQuota" Thanks, Klaus Ma
Re: Review Request 42589: Added test case for allocator recover with Quota.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42589/ --- (Updated Jan. 21, 2016, 2:27 p.m.) Review request for mesos, Alexander Rukletsov, Ben Mahler, and Joris Van Remoortere. Changes --- Add description on testing. Repository: mesos Description --- Added test case for allocator recover with Quota. Diffs - src/tests/hierarchical_allocator_tests.cpp 953712149bd951789beb29c72779c4ac65aa48dc Diff: https://reviews.apache.org/r/42589/diff/ Testing (updated) --- make make check GTEST_FILTER="HierarchicalAllocatorTest.RecoverWithQuota" (CHECK() failed without fix) Thanks, Klaus Ma
Re: Review Request 42589: Added test case for allocator recover with Quota.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42589/#review115588 --- Patch looks great! Reviews applied: [42535, 42589] Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh - Mesos ReviewBot On Jan. 21, 2016, 6:27 a.m., Klaus Ma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42589/ > --- > > (Updated Jan. 21, 2016, 6:27 a.m.) > > > Review request for mesos, Alexander Rukletsov, Ben Mahler, and Joris Van > Remoortere. > > > Repository: mesos > > > Description > --- > > Added test case for allocator recover with Quota. > > > Diffs > - > > src/tests/hierarchical_allocator_tests.cpp > 953712149bd951789beb29c72779c4ac65aa48dc > > Diff: https://reviews.apache.org/r/42589/diff/ > > > Testing > --- > > make > make check GTEST_FILTER="HierarchicalAllocatorTest.RecoverWithQuota" (CHECK() > failed without fix) > > > Thanks, > > Klaus Ma > >
