Re: Review Request 43200: Updated role documentation.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43200/#review118449
---




docs/roles.md (line 130)


"Principals are used to identify a framework." is a bit vague to me. How 
about "A principal identifies an entity that interacts with Mesos; principals 
are similar to user names. For example, frameworks supply a principal when they 
register with the Mesos master, and operators provide a principal when using 
the operator HTTP endpoints."



docs/roles.md (line 139)


Doesn't seem useful to have the caveat about multi-role frameworks, IMO.



docs/roles.md (line 143)


Last sentence can probably be cut.


- Neil Conway


On Feb. 8, 2016, 6:56 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43200/
> ---
> 
> (Updated Feb. 8, 2016, 6:56 p.m.)
> 
> 
> Review request for mesos, Neil Conway and Vinod Kone.
> 
> 
> Bugs: MESOS-4452
> https://issues.apache.org/jira/browse/MESOS-4452
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated role documentation.
> 
> Added information on the distinction between roles and principals.
> 
> 
> Diffs
> -
> 
>   docs/roles.md c84a483259922be01d1686befd01b7b1c4005bbd 
> 
> Diff: https://reviews.apache.org/r/43200/diff/
> 
> 
> Testing
> ---
> 
> Viewed in the mesos website container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 43200: Updated role documentation.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43200/#review118465
---


Fix it, then Ship it!





docs/roles.md (line 129)


I'm not sure it is useful to say that "principals are associated with 
frameworks." Principals are used by frameworks, slaves (`--credential` flag), 
and operators.


- Neil Conway


On Feb. 9, 2016, 11:18 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43200/
> ---
> 
> (Updated Feb. 9, 2016, 11:18 p.m.)
> 
> 
> Review request for mesos, Neil Conway and Vinod Kone.
> 
> 
> Bugs: MESOS-4452
> https://issues.apache.org/jira/browse/MESOS-4452
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated role documentation.
> 
> Added information on the distinction between roles and principals.
> 
> 
> Diffs
> -
> 
>   docs/roles.md c84a483259922be01d1686befd01b7b1c4005bbd 
> 
> Diff: https://reviews.apache.org/r/43200/diff/
> 
> 
> Testing
> ---
> 
> Viewed in the mesos website container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 43200: Updated role documentation.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43200/
---

(Updated Feb. 10, 2016, 12:41 a.m.)


Review request for mesos, Neil Conway and Vinod Kone.


Changes
---

Removed unnecessary text from "Role vs. Principal".


Bugs: MESOS-4452
https://issues.apache.org/jira/browse/MESOS-4452


Repository: mesos


Description
---

Updated role documentation.

Added information on the distinction between roles and principals.


Diffs (updated)
-

  docs/roles.md c84a483259922be01d1686befd01b7b1c4005bbd 

Diff: https://reviews.apache.org/r/43200/diff/


Testing
---

Viewed in the mesos website container: 
https://github.com/mesosphere/mesos-website-container


Thanks,

Greg Mann

Re: Review Request 43200: Updated role documentation.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43200/
---

(Updated Feb. 9, 2016, 11:18 p.m.)


Review request for mesos, Neil Conway and Vinod Kone.


Bugs: MESOS-4452
https://issues.apache.org/jira/browse/MESOS-4452


Repository: mesos


Description
---

Updated role documentation.

Added information on the distinction between roles and principals.


Diffs (updated)
-

  docs/roles.md c84a483259922be01d1686befd01b7b1c4005bbd 

Diff: https://reviews.apache.org/r/43200/diff/


Testing
---

Viewed in the mesos website container: 
https://github.com/mesosphere/mesos-website-container


Thanks,

Greg Mann

Re: Review Request 43200: Updated role documentation.

[Adam B]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43200/#review118606
---


Ship it!




Ship It!

- Adam B


On Feb. 9, 2016, 4:41 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43200/
> ---
> 
> (Updated Feb. 9, 2016, 4:41 p.m.)
> 
> 
> Review request for mesos, Neil Conway and Vinod Kone.
> 
> 
> Bugs: MESOS-4452
> https://issues.apache.org/jira/browse/MESOS-4452
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated role documentation.
> 
> Added information on the distinction between roles and principals.
> 
> 
> Diffs
> -
> 
>   docs/roles.md c84a483259922be01d1686befd01b7b1c4005bbd 
> 
> Diff: https://reviews.apache.org/r/43200/diff/
> 
> 
> Testing
> ---
> 
> Viewed in the mesos website container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 43200: Updated role documentation.

[Greg Mann]

> On Feb. 6, 2016, 4:14 a.m., Guangya Liu wrote:
> > docs/roles.md, line 132
> > 
> >
> > I think that the principals does not related to the operator of http 
> > endpoint?

The principals specified in the ACLs are used to authorize both framework 
operations, as well as operations through the operator HTTP endpoints.


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43200/#review118136
---


On Feb. 8, 2016, 6:56 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43200/
> ---
> 
> (Updated Feb. 8, 2016, 6:56 p.m.)
> 
> 
> Review request for mesos, Neil Conway and Vinod Kone.
> 
> 
> Bugs: MESOS-4452
> https://issues.apache.org/jira/browse/MESOS-4452
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated role documentation.
> 
> Added information on the distinction between roles and principals.
> 
> 
> Diffs
> -
> 
>   docs/roles.md c84a483259922be01d1686befd01b7b1c4005bbd 
> 
> Diff: https://reviews.apache.org/r/43200/diff/
> 
> 
> Testing
> ---
> 
> Viewed in the mesos website container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 43200: Updated role documentation.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43200/
---

(Updated Feb. 8, 2016, 6:56 p.m.)


Review request for mesos, Neil Conway and Vinod Kone.


Changes
---

Added reference to multi-role work.


Bugs: MESOS-4452
https://issues.apache.org/jira/browse/MESOS-4452


Repository: mesos


Description
---

Updated role documentation.

Added information on the distinction between roles and principals.


Diffs (updated)
-

  docs/roles.md c84a483259922be01d1686befd01b7b1c4005bbd 

Diff: https://reviews.apache.org/r/43200/diff/


Testing
---

Viewed in the mesos website container: 
https://github.com/mesosphere/mesos-website-container


Thanks,

Greg Mann

Re: Review Request 43200: Updated role documentation.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43200/#review118282
---



Patch looks great!

Reviews applied: [43199, 43200]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 8, 2016, 6:56 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43200/
> ---
> 
> (Updated Feb. 8, 2016, 6:56 p.m.)
> 
> 
> Review request for mesos, Neil Conway and Vinod Kone.
> 
> 
> Bugs: MESOS-4452
> https://issues.apache.org/jira/browse/MESOS-4452
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated role documentation.
> 
> Added information on the distinction between roles and principals.
> 
> 
> Diffs
> -
> 
>   docs/roles.md c84a483259922be01d1686befd01b7b1c4005bbd 
> 
> Diff: https://reviews.apache.org/r/43200/diff/
> 
> 
> Testing
> ---
> 
> Viewed in the mesos website container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 43200: Updated role documentation.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43200/#review118335
---


Ship it!




Ship It!

- Guangya Liu


On 二月 8, 2016, 6:56 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43200/
> ---
> 
> (Updated 二月 8, 2016, 6:56 p.m.)
> 
> 
> Review request for mesos, Neil Conway and Vinod Kone.
> 
> 
> Bugs: MESOS-4452
> https://issues.apache.org/jira/browse/MESOS-4452
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated role documentation.
> 
> Added information on the distinction between roles and principals.
> 
> 
> Diffs
> -
> 
>   docs/roles.md c84a483259922be01d1686befd01b7b1c4005bbd 
> 
> Diff: https://reviews.apache.org/r/43200/diff/
> 
> 
> Testing
> ---
> 
> Viewed in the mesos website container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 43200: Updated role documentation.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43200/#review118327
---


Ship it!




Ship It!

- Vinod Kone


On Feb. 8, 2016, 6:56 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43200/
> ---
> 
> (Updated Feb. 8, 2016, 6:56 p.m.)
> 
> 
> Review request for mesos, Neil Conway and Vinod Kone.
> 
> 
> Bugs: MESOS-4452
> https://issues.apache.org/jira/browse/MESOS-4452
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated role documentation.
> 
> Added information on the distinction between roles and principals.
> 
> 
> Diffs
> -
> 
>   docs/roles.md c84a483259922be01d1686befd01b7b1c4005bbd 
> 
> Diff: https://reviews.apache.org/r/43200/diff/
> 
> 
> Testing
> ---
> 
> Viewed in the mesos website container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 43200: Updated role documentation.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43200/#review118158
---



Patch looks great!

Reviews applied: [43199, 43200]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 6, 2016, 3:47 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43200/
> ---
> 
> (Updated Feb. 6, 2016, 3:47 a.m.)
> 
> 
> Review request for mesos, Neil Conway and Vinod Kone.
> 
> 
> Bugs: MESOS-4452
> https://issues.apache.org/jira/browse/MESOS-4452
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated role documentation.
> 
> Added information on the distinction between roles and principals.
> 
> 
> Diffs
> -
> 
>   docs/roles.md c84a483259922be01d1686befd01b7b1c4005bbd 
> 
> Diff: https://reviews.apache.org/r/43200/diff/
> 
> 
> Testing
> ---
> 
> Viewed in the mesos website container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 43200: Updated role documentation.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43200/#review117993
---



Patch looks great!

Reviews applied: [43199, 43200]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 4, 2016, 7:55 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43200/
> ---
> 
> (Updated Feb. 4, 2016, 7:55 p.m.)
> 
> 
> Review request for mesos, Neil Conway and Vinod Kone.
> 
> 
> Bugs: MESOS-4452
> https://issues.apache.org/jira/browse/MESOS-4452
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated role documentation.
> 
> Added information on the distinction between roles and principals.
> 
> 
> Diffs
> -
> 
>   docs/roles.md c84a483259922be01d1686befd01b7b1c4005bbd 
> 
> Diff: https://reviews.apache.org/r/43200/diff/
> 
> 
> Testing
> ---
> 
> Viewed in the mesos website container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 43200: Updated role documentation.

[Greg Mann]

> On Feb. 5, 2016, 7:07 a.m., Guangya Liu wrote:
> > docs/roles.md, line 21
> > 
> >
> > Maybe `Configure Mesos to provide guaranteed resource allocations for 
> > use by a role.` is better? You can refer to `home.md` to check the 
> > explanation for `quota.md`

I like using the word "guaranteed", but I don't think that saying "for use by a 
role" makes sense when we are actually trying to define what a "role" is. I 
changed the text to use "guaranteed"; let me know what you think!


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43200/#review117978
---


On Feb. 6, 2016, 2:43 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43200/
> ---
> 
> (Updated Feb. 6, 2016, 2:43 a.m.)
> 
> 
> Review request for mesos, Neil Conway and Vinod Kone.
> 
> 
> Bugs: MESOS-4452
> https://issues.apache.org/jira/browse/MESOS-4452
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated role documentation.
> 
> Added information on the distinction between roles and principals.
> 
> 
> Diffs
> -
> 
>   docs/roles.md c84a483259922be01d1686befd01b7b1c4005bbd 
> 
> Diff: https://reviews.apache.org/r/43200/diff/
> 
> 
> Testing
> ---
> 
> Viewed in the mesos website container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 43200: Updated role documentation.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43200/#review118132
---




docs/roles.md (line 22)


I saw that we actually already have `role` reference in line 16 and line 19 
in this file.

So is it possible to also hightlihgt `role` in line 22? e.g. `a group of 
frameworks in one role`?


- Guangya Liu


On 二月 6, 2016, 2:43 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43200/
> ---
> 
> (Updated 二月 6, 2016, 2:43 a.m.)
> 
> 
> Review request for mesos, Neil Conway and Vinod Kone.
> 
> 
> Bugs: MESOS-4452
> https://issues.apache.org/jira/browse/MESOS-4452
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated role documentation.
> 
> Added information on the distinction between roles and principals.
> 
> 
> Diffs
> -
> 
>   docs/roles.md c84a483259922be01d1686befd01b7b1c4005bbd 
> 
> Diff: https://reviews.apache.org/r/43200/diff/
> 
> 
> Testing
> ---
> 
> Viewed in the mesos website container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 43200: Updated role documentation.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43200/
---

(Updated Feb. 6, 2016, 2:43 a.m.)


Review request for mesos, Neil Conway and Vinod Kone.


Changes
---

Addressed comments.


Bugs: MESOS-4452
https://issues.apache.org/jira/browse/MESOS-4452


Repository: mesos


Description
---

Updated role documentation.

Added information on the distinction between roles and principals.


Diffs (updated)
-

  docs/roles.md c84a483259922be01d1686befd01b7b1c4005bbd 

Diff: https://reviews.apache.org/r/43200/diff/


Testing
---

Viewed in the mesos website container: 
https://github.com/mesosphere/mesos-website-container


Thanks,

Greg Mann

Re: Review Request 43200: Updated role documentation.

[Guangya Liu]

> On 二月 5, 2016, 7:07 a.m., Guangya Liu wrote:
> > docs/roles.md, line 21
> > 
> >
> > Maybe `Configure Mesos to provide guaranteed resource allocations for 
> > use by a role.` is better? You can refer to `home.md` to check the 
> > explanation for `quota.md`
> 
> Greg Mann wrote:
> I like using the word "guaranteed", but I don't think that saying "for 
> use by a role" makes sense when we are actually trying to define what a 
> "role" is. I changed the text to use "guaranteed"; let me know what you think!

My only concern is that the description in `roles.md` and `home.md` will have 
different explanation for `Quota`, I think that we should keep them consistent.

What about update your latest document as "for a group of frameworks in one 
role"?


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43200/#review117978
---


On 二月 6, 2016, 2:43 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43200/
> ---
> 
> (Updated 二月 6, 2016, 2:43 a.m.)
> 
> 
> Review request for mesos, Neil Conway and Vinod Kone.
> 
> 
> Bugs: MESOS-4452
> https://issues.apache.org/jira/browse/MESOS-4452
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated role documentation.
> 
> Added information on the distinction between roles and principals.
> 
> 
> Diffs
> -
> 
>   docs/roles.md c84a483259922be01d1686befd01b7b1c4005bbd 
> 
> Diff: https://reviews.apache.org/r/43200/diff/
> 
> 
> Testing
> ---
> 
> Viewed in the mesos website container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 43200: Updated role documentation.

[Greg Mann]

> On Feb. 6, 2016, 2:55 a.m., Guangya Liu wrote:
> > docs/roles.md, line 22
> > 
> >
> > I saw that we actually already have `role` reference in line 16 and 
> > line 19 in this file.
> > 
> > So is it possible to also hightlihgt `role` in line 22? e.g. `a group 
> > of frameworks in one role`?

Good point; let me know what you think of the current text :-)


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43200/#review118132
---


On Feb. 6, 2016, 3:47 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43200/
> ---
> 
> (Updated Feb. 6, 2016, 3:47 a.m.)
> 
> 
> Review request for mesos, Neil Conway and Vinod Kone.
> 
> 
> Bugs: MESOS-4452
> https://issues.apache.org/jira/browse/MESOS-4452
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated role documentation.
> 
> Added information on the distinction between roles and principals.
> 
> 
> Diffs
> -
> 
>   docs/roles.md c84a483259922be01d1686befd01b7b1c4005bbd 
> 
> Diff: https://reviews.apache.org/r/43200/diff/
> 
> 
> Testing
> ---
> 
> Viewed in the mesos website container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 43200: Updated role documentation.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43200/#review118136
---




docs/roles.md (line 132)


I think that the principals does not related to the operator of http 
endpoint?



docs/roles.md (line 140)


s/it is/it is also ?

Shall we mention that the "multiple role framework" is also under going in 
MESOS-1763?

The final goal in mesos for role and framework is one framework can map to 
multiple roles while one role can also map to multiple frameworks.


- Guangya Liu


On 二月 6, 2016, 3:47 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43200/
> ---
> 
> (Updated 二月 6, 2016, 3:47 a.m.)
> 
> 
> Review request for mesos, Neil Conway and Vinod Kone.
> 
> 
> Bugs: MESOS-4452
> https://issues.apache.org/jira/browse/MESOS-4452
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated role documentation.
> 
> Added information on the distinction between roles and principals.
> 
> 
> Diffs
> -
> 
>   docs/roles.md c84a483259922be01d1686befd01b7b1c4005bbd 
> 
> Diff: https://reviews.apache.org/r/43200/diff/
> 
> 
> Testing
> ---
> 
> Viewed in the mesos website container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 43200: Updated role documentation.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43200/#review117978
---




docs/roles.md (line 21)


Maybe `Configure Mesos to provide guaranteed resource allocations for use 
by a role.` is better? You can refer to `home.md` to check the explanation for 
`quota.md`


- Guangya Liu


On 二月 4, 2016, 7:55 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43200/
> ---
> 
> (Updated 二月 4, 2016, 7:55 p.m.)
> 
> 
> Review request for mesos, Neil Conway and Vinod Kone.
> 
> 
> Bugs: MESOS-4452
> https://issues.apache.org/jira/browse/MESOS-4452
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated role documentation.
> 
> Added information on the distinction between roles and principals.
> 
> 
> Diffs
> -
> 
>   docs/roles.md c84a483259922be01d1686befd01b7b1c4005bbd 
> 
> Diff: https://reviews.apache.org/r/43200/diff/
> 
> 
> Testing
> ---
> 
> Viewed in the mesos website container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Review Request 43200: Updated role documentation.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43200/
---

Review request for mesos, Neil Conway and Vinod Kone.


Bugs: MESOS-4452
https://issues.apache.org/jira/browse/MESOS-4452


Repository: mesos


Description
---

Updated role documentation.

Added information on the distinction between roles and principals.


Diffs
-

  docs/roles.md c84a483259922be01d1686befd01b7b1c4005bbd 

Diff: https://reviews.apache.org/r/43200/diff/


Testing
---

Viewed in the mesos website container: 
https://github.com/mesosphere/mesos-website-container


Thanks,

Greg Mann

Re: Review Request 43200: Updated role documentation.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43200/#review117868
---




docs/roles.md (line 14)


not yours, but s/assigned/reserved/ ?



docs/roles.md (line 16)


Style-wise, I think we should try to avoid link text that doesn't parse as 
an actual sentence construct -- e.g., "see the [reservation 
documentation](reservation.md)", or "resources are [reserved](reservation.md) 
for use by ..."


- Neil Conway


On Feb. 4, 2016, 7:04 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43200/
> ---
> 
> (Updated Feb. 4, 2016, 7:04 p.m.)
> 
> 
> Review request for mesos, Neil Conway and Vinod Kone.
> 
> 
> Bugs: MESOS-4452
> https://issues.apache.org/jira/browse/MESOS-4452
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated role documentation.
> 
> Added information on the distinction between roles and principals.
> 
> 
> Diffs
> -
> 
>   docs/roles.md c84a483259922be01d1686befd01b7b1c4005bbd 
> 
> Diff: https://reviews.apache.org/r/43200/diff/
> 
> 
> Testing
> ---
> 
> Viewed in the mesos website container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 43200: Updated role documentation.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43200/
---

(Updated Feb. 4, 2016, 7:55 p.m.)


Review request for mesos, Neil Conway and Vinod Kone.


Bugs: MESOS-4452
https://issues.apache.org/jira/browse/MESOS-4452


Repository: mesos


Description
---

Updated role documentation.

Added information on the distinction between roles and principals.


Diffs (updated)
-

  docs/roles.md c84a483259922be01d1686befd01b7b1c4005bbd 

Diff: https://reviews.apache.org/r/43200/diff/


Testing
---

Viewed in the mesos website container: 
https://github.com/mesosphere/mesos-website-container


Thanks,

Greg Mann