Re: Review Request 43308: Added systemd life-extension option to container logrotate module.

2016-02-10 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43308/
---

(Updated Feb. 10, 2016, 4:53 p.m.)


Review request for mesos, Benjamin Hindman and Jie Yu.


Bugs: MESOS-4640
https://issues.apache.org/jira/browse/MESOS-4640


Repository: mesos


Description
---

Added systemd life-extension option to container logrotate module.


Diffs (updated)
-

  src/slave/container_loggers/lib_logrotate.cpp 
01a3ff031b70366443214e2895803cd4b2606ad8 

Diff: https://reviews.apache.org/r/43308/diff/


Testing
---


Thanks,

Joris Van Remoortere

Re: Review Request 43308: Added systemd life-extension option to container logrotate module.

2016-02-09 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43308/
---

(Updated Feb. 9, 2016, 7:14 p.m.)


Review request for mesos, Benjamin Hindman and Jie Yu.


Repository: mesos


Description (updated)
---

Added systemd life-extension option to container logrotate module.


Diffs (updated)
-

  src/slave/container_loggers/lib_logrotate.cpp 
01a3ff031b70366443214e2895803cd4b2606ad8 

Diff: https://reviews.apache.org/r/43308/diff/


Testing
---


Thanks,

Joris Van Remoortere

Re: Review Request 43308: Added systemd life-extension option to container logrotate module.

2016-02-09 Thread Benjamin Hindman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43308/#review118572
---


Fix it, then Ship it!





src/slave/container_loggers/lib_logrotate.cpp (line 132)


`&` here as well please?


- Benjamin Hindman


On Feb. 9, 2016, 7:14 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43308/
> ---
> 
> (Updated Feb. 9, 2016, 7:14 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added systemd life-extension option to container logrotate module.
> 
> 
> Diffs
> -
> 
>   src/slave/container_loggers/lib_logrotate.cpp 
> 01a3ff031b70366443214e2895803cd4b2606ad8 
> 
> Diff: https://reviews.apache.org/r/43308/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 43308: Added systemd life-extension option to container logrotate module.

2016-02-08 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43308/#review118278
---


Ship it!




LGTM!

- Joseph Wu


On Feb. 7, 2016, 5:57 a.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43308/
> ---
> 
> (Updated Feb. 7, 2016, 5:57 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/slave/container_loggers/lib_logrotate.cpp 
> 01a3ff031b70366443214e2895803cd4b2606ad8 
> 
> Diff: https://reviews.apache.org/r/43308/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Review Request 43308: Added systemd life-extension option to container logrotate module.

2016-02-07 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43308/
---

Review request for mesos, Benjamin Hindman and Jie Yu.


Repository: mesos


Description
---

See summary.


Diffs
-

  src/slave/container_loggers/lib_logrotate.cpp 
01a3ff031b70366443214e2895803cd4b2606ad8 

Diff: https://reviews.apache.org/r/43308/diff/


Testing
---


Thanks,

Joris Van Remoortere