Re: Review Request 43309: Added systemd life-extension option to posix launcher.

2016-02-10 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43309/
---

(Updated Feb. 10, 2016, 4:54 p.m.)


Review request for mesos, Benjamin Hindman and Jie Yu.


Bugs: MESOS-4639
https://issues.apache.org/jira/browse/MESOS-4639


Repository: mesos


Description
---

Added systemd life-extension option to posix launcher.


Diffs (updated)
-

  src/slave/containerizer/mesos/launcher.cpp 
d64832477313de2ef39aa43db67486cfa4023813 

Diff: https://reviews.apache.org/r/43309/diff/


Testing
---

make check
manual testing on systemd with agent-systemd-unit `KillMode=control-group`.


Thanks,

Joris Van Remoortere

Re: Review Request 43309: Added systemd life-extension option to posix launcher.

2016-02-09 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43309/#review118459
---



Patch looks great!

Reviews applied: [43302, 43303, 43304, 43305, 43306, 43307, 43308, 43309]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 9, 2016, 7:14 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43309/
> ---
> 
> (Updated Feb. 9, 2016, 7:14 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added systemd life-extension option to posix launcher.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/launcher.cpp 
> d64832477313de2ef39aa43db67486cfa4023813 
> 
> Diff: https://reviews.apache.org/r/43309/diff/
> 
> 
> Testing
> ---
> 
> make check
> manual testing on systemd with agent-systemd-unit `KillMode=control-group`.
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 43309: Added systemd life-extension option to posix launcher.

2016-02-09 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43309/
---

(Updated Feb. 9, 2016, 7:14 p.m.)


Review request for mesos, Benjamin Hindman and Jie Yu.


Repository: mesos


Description (updated)
---

Added systemd life-extension option to posix launcher.


Diffs (updated)
-

  src/slave/containerizer/mesos/launcher.cpp 
d64832477313de2ef39aa43db67486cfa4023813 

Diff: https://reviews.apache.org/r/43309/diff/


Testing
---

make check
manual testing on systemd with agent-systemd-unit `KillMode=control-group`.


Thanks,

Joris Van Remoortere

Re: Review Request 43309: Added systemd life-extension option to posix launcher.

2016-02-09 Thread Benjamin Hindman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43309/#review118573
---


Fix it, then Ship it!





src/slave/containerizer/mesos/launcher.cpp (line 127)


`&` here as well please?


- Benjamin Hindman


On Feb. 9, 2016, 7:14 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43309/
> ---
> 
> (Updated Feb. 9, 2016, 7:14 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added systemd life-extension option to posix launcher.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/launcher.cpp 
> d64832477313de2ef39aa43db67486cfa4023813 
> 
> Diff: https://reviews.apache.org/r/43309/diff/
> 
> 
> Testing
> ---
> 
> make check
> manual testing on systemd with agent-systemd-unit `KillMode=control-group`.
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 43309: Added systemd life-extension option to posix launcher.

2016-02-07 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43309/#review118178
---



Patch looks great!

Reviews applied: [43302, 43303, 43304, 43305, 43306, 43307, 43308, 43309]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 7, 2016, 1:57 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43309/
> ---
> 
> (Updated Feb. 7, 2016, 1:57 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/launcher.cpp 
> d64832477313de2ef39aa43db67486cfa4023813 
> 
> Diff: https://reviews.apache.org/r/43309/diff/
> 
> 
> Testing
> ---
> 
> make check
> manual testing on systemd with agent-systemd-unit `KillMode=control-group`.
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Review Request 43309: Added systemd life-extension option to posix launcher.

2016-02-07 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43309/
---

Review request for mesos, Benjamin Hindman and Jie Yu.


Repository: mesos


Description
---

See summary.


Diffs
-

  src/slave/containerizer/mesos/launcher.cpp 
d64832477313de2ef39aa43db67486cfa4023813 

Diff: https://reviews.apache.org/r/43309/diff/


Testing
---

make check
manual testing on systemd with agent-systemd-unit `KillMode=control-group`.


Thanks,

Joris Van Remoortere