Re: Review Request 43616: Documented that labels should not contain duplicate key-value pairs.

2016-02-19 Thread Adam B
> On Feb. 18, 2016, 10:32 p.m., Adam B wrote: > > include/mesos/mesos.proto, line 1600 > > > > > > Is it ok for labels to contain duplicate keys even if the values are > > different? > > That sounds like

Re: Review Request 43616: Documented that labels should not contain duplicate key-value pairs.

2016-02-19 Thread Neil Conway
> On Feb. 19, 2016, 6:32 a.m., Adam B wrote: > > include/mesos/mesos.proto, line 1600 > > > > > > Is it ok for labels to contain duplicate keys even if the values are > > different? > > That sounds like

Re: Review Request 43616: Documented that labels should not contain duplicate key-value pairs.

2016-02-18 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43616/#review119822 --- Thanks for putting this together. Just a couple of questions.

Re: Review Request 43616: Documented that labels should not contain duplicate key-value pairs.

2016-02-17 Thread Guangya Liu
> On 二月 17, 2016, 1:57 a.m., Guangya Liu wrote: > > include/mesos/mesos.proto, line 598 > > > > > > s/Labels/One label? > > > > I think that here we should use `one label` but not `labels`, becauase > >

Re: Review Request 43616: Documented that labels should not contain duplicate key-value pairs.

2016-02-17 Thread Neil Conway
> On Feb. 17, 2016, 1:57 a.m., Guangya Liu wrote: > > include/mesos/mesos.proto, line 598 > > > > > > s/Labels/One label? > > > > I think that here we should use `one label` but not `labels`, becauase > >

Re: Review Request 43616: Documented that labels should not contain duplicate key-value pairs.

2016-02-17 Thread Guangya Liu
> On 二月 17, 2016, 1:57 a.m., Guangya Liu wrote: > > include/mesos/mesos.proto, line 598 > > > > > > s/Labels/One label? > > > > I think that here we should use `one label` but not `labels`, becauase > >

Re: Review Request 43616: Documented that labels should not contain duplicate key-value pairs.

2016-02-17 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43616/#review119520 --- Patch looks great! Reviews applied: [43616] Passed command:

Re: Review Request 43616: Documented that labels should not contain duplicate key-value pairs.

2016-02-17 Thread Neil Conway
> On Feb. 17, 2016, 1:57 a.m., Guangya Liu wrote: > > include/mesos/mesos.proto, line 598 > > > > > > s/Labels/One label? > > > > I think that here we should use `one label` but not `labels`, becauase > >

Re: Review Request 43616: Documented that labels should not contain duplicate key-value pairs.

2016-02-16 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43616/#review119399 --- include/mesos/mesos.proto (line 598)

Re: Review Request 43616: Documented that labels should not contain duplicate key-value pairs.

2016-02-16 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43616/#review119378 --- Bad patch! Reviews applied: [43616] Failed command:

Review Request 43616: Documented that labels should not contain duplicate key-value pairs.

2016-02-16 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43616/ --- Review request for mesos and Michael Park. Repository: mesos Description