Re: Review Request 44500: Implemented passing image and user env var to command task.

2016-06-14 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44500/#review137471 --- Patch looks great! Reviews applied: [44498, 44499, 44500] Passed

Re: Review Request 44500: Implemented passing image and user env var to command task.

2016-06-14 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44500/ --- (Updated June 14, 2016, 1:04 a.m.) Review request for mesos, Guangya Liu, Artem

Re: Review Request 44500: Implemented passing image and user env var to command task.

2016-03-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44500/#review125413 --- Patch looks great! Reviews applied: [44498, 44499, 44500] Passed

Re: Review Request 44500: Implemented passing image and user env var to command task.

2016-03-24 Thread Gilbert Song
> On March 16, 2016, 4:22 a.m., Benjamin Bannier wrote: > > src/slave/containerizer/mesos/isolators/docker/runtime.cpp, line 160 > > > > > > Does it makes sense to distinguish the sources of overwriting here and > >

Re: Review Request 44500: Implemented passing image and user env var to command task.

2016-03-24 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44500/ --- (Updated March 24, 2016, 3:01 p.m.) Review request for mesos, Guangya Liu, Arte