Re: Review Request 44843: Replace NULL with nullptr.

2016-06-04 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44843/#review136187 --- Ship it! Ship It! - Michael Park On June 4, 2016, 12:59

Re: Review Request 44843: Replace NULL with nullptr.

2016-06-04 Thread Michael Park
> On June 4, 2016, 7:14 p.m., Michael Park wrote: > > Could you please split this up into `clang-tidy` and `sed`? > > > > This only touches mesos, not libprocess and stout. Is that correct? > > > > Are https://reviews.apache.org/r/45482/ and > > https://reviews.apache.org/r/45480/ meant to be

Re: Review Request 44843: Replace NULL with nullptr.

2016-06-04 Thread Tomasz Janiszewski
> On Cze 4, 2016, 7:14 po południu, Michael Park wrote: > > Could you please split this up into `clang-tidy` and `sed`? > > > > This only touches mesos, not libprocess and stout. Is that correct? > > > > Are https://reviews.apache.org/r/45482/ and > > https://reviews.apache.org/r/45480/ meant

Re: Review Request 44843: Replace NULL with nullptr.

2016-06-04 Thread Michael Park
> On June 4, 2016, 7:14 p.m., Michael Park wrote: > > Could you please split this up into `clang-tidy` and `sed`? > > > > This only touches mesos, not libprocess and stout. Is that correct? > > > > Are https://reviews.apache.org/r/45482/ and > > https://reviews.apache.org/r/45480/ meant to be

Re: Review Request 44843: Replace NULL with nullptr.

2016-06-04 Thread Tomasz Janiszewski
> On Cze 4, 2016, 7:14 po południu, Michael Park wrote: > > Could you please split this up into `clang-tidy` and `sed`? > > > > This only touches mesos, not libprocess and stout. Is that correct? > > > > Are https://reviews.apache.org/r/45482/ and > > https://reviews.apache.org/r/45480/ meant

Re: Review Request 44843: Replace NULL with nullptr.

2016-06-04 Thread Michael Park
> On June 4, 2016, 7:14 p.m., Michael Park wrote: > > Could you please split this up into `clang-tidy` and `sed`? > > > > This only touches mesos, not libprocess and stout. Is that correct? > > > > Are https://reviews.apache.org/r/45482/ and > > https://reviews.apache.org/r/45480/ meant to be

Re: Review Request 44843: Replace NULL with nullptr.

2016-06-04 Thread Tomasz Janiszewski
> On Cze 4, 2016, 7:14 po południu, Michael Park wrote: > > Could you please split this up into `clang-tidy` and `sed`? > > > > This only touches mesos, not libprocess and stout. Is that correct? > > > > Are https://reviews.apache.org/r/45482/ and > > https://reviews.apache.org/r/45480/ meant

Re: Review Request 44843: Replace NULL with nullptr.

2016-06-04 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44843/#review136178 --- Could you please split this up into `clang-tidy` and `sed`? This

Re: Review Request 44843: Replace NULL with nullptr.

2016-06-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44843/#review136167 --- Patch looks great! Reviews applied: [44843] Passed command:

Re: Review Request 44843: Replace NULL with nullptr.

2016-06-04 Thread Tomasz Janiszewski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44843/ --- (Updated June 4, 2016, 12:59 p.m.) Review request for mesos and Michael Park.

Re: Review Request 44843: Replace NULL with nullptr.

2016-06-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44843/#review136159 --- Bad patch! Reviews applied: [44843] Failed command:

Re: Review Request 44843: Replace NULL with nullptr.

2016-06-04 Thread Tomasz Janiszewski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44843/ --- (Updated June 4, 2016, 10:15 a.m.) Review request for mesos and Michael Park.

Re: Review Request 44843: Replace NULL with nullptr.

2016-03-28 Thread Tomasz Janiszewski
> On March 26, 2016, 7:10 p.m., Michael Park wrote: > > src/exec/exec.cpp, lines 637-638 > > > > > > This is clearly beyond just a `s/NULL/nullptr`. I assume this is > > `clang-tidy` magic, right? Exactly -

Re: Review Request 44843: Replace NULL with nullptr.

2016-03-28 Thread Tomasz Janiszewski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44843/ --- (Updated March 28, 2016, 8:42 p.m.) Review request for mesos and Michael Park.

Re: Review Request 44843: Replace NULL with nullptr.

2016-03-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44843/#review125551 --- Bad patch! Reviews applied: [44843] Failed command:

Re: Review Request 44843: Replace NULL with nullptr.

2016-03-26 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44843/#review125535 --- src/exec/exec.cpp (lines 637 - 638)

Review Request 44843: Replace NULL with nullptr.

2016-03-15 Thread Tomasz Janiszewski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44843/ --- Review request for mesos and Michael Park. Bugs: MESOS-3243