Re: Review Request 45358: Improved overlay backend to make the rootfs writable.

2016-04-11 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45358/ --- (Updated April 11, 2016, 10:28 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 45358: Improved overlay backend to make the rootfs writable.

2016-04-11 Thread Shuai Lin
> On April 10, 2016, 1:37 p.m., Guangya Liu wrote: > > docs/container-image.md, lines 290-291 > > > > > > It is better update the document here to highlight that the overlay > > backend also support one layer image

Re: Review Request 45358: Improved overlay backend to make the rootfs writable.

2016-04-10 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45358/#review128043 --- Fix it, then Ship it!

Re: Review Request 45358: Improved overlay backend to make the rootfs writable.

2016-04-10 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45358/#review128033 --- docs/container-image.md (lines 290 - 291)

Re: Review Request 45358: Improved overlay backend to make the rootfs writable.

2016-04-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45358/#review128031 --- Patch looks great! Reviews applied: [45358] Passed command:

Re: Review Request 45358: Improved overlay backend to make the rootfs writable.

2016-04-10 Thread Shuai Lin
> On April 7, 2016, 11:54 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/provisioner/provisioner.cpp, line 296 > > > > > > since scatch space is specific to overlay backend. I would simply pass > >

Re: Review Request 45358: Improved overlay backend to make the rootfs writable.

2016-04-10 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45358/ --- (Updated April 10, 2016, 8:09 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 45358: Improved overlay backend to make the rootfs writable.

2016-04-07 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45358/#review127696 --- src/slave/containerizer/mesos/provisioner/paths.hpp (lines 43 -

Re: Review Request 45358: Improved overlay backend to make the rootfs writable.

2016-04-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45358/#review127448 --- Patch looks great! Reviews applied: [45358] Passed command:

Re: Review Request 45358: Improved overlay backend to make the rootfs writable.

2016-04-06 Thread Jie Yu
> On April 6, 2016, 12:23 p.m., Shuai Lin wrote: > > @jieyu updated according to your suggestions. yep, will look at it today. - Jie --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 45358: Improved overlay backend to make the rootfs writable.

2016-04-06 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45358/#review127315 --- @jieyu updated according to your suggestions. - Shuai Lin On

Re: Review Request 45358: Improved overlay backend to make the rootfs writable.

2016-04-06 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45358/ --- (Updated April 6, 2016, 12:12 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 45358: Improved overlay backend to make the rootfs writable.

2016-04-06 Thread Shuai Lin
> On March 29, 2016, 3:32 a.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/provisioner/backends/overlay.cpp, lines > > 153-155 > > > > > > 1 layer was also supportted for now, can you update the comments

Re: Review Request 45358: Improved overlay backend to make the rootfs writable.

2016-04-06 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45358/ --- (Updated April 6, 2016, 12:05 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 45358: Improved overlay backend to make the rootfs writable.

2016-04-04 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45358/#review126907 --- I don't like the fact that we use 'sandbox' for scratch space.

Re: Review Request 45358: Improved overlay backend to make the rootfs writable.

2016-03-28 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45358/#review125804 --- The document here

Re: Review Request 45358: Improved overlay backend to make the rootfs writable.

2016-03-28 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45358/#review125803 --- src/slave/containerizer/mesos/provisioner/backends/overlay.cpp

Re: Review Request 45358: Improved overlay backend to make the rootfs writable.

2016-03-28 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45358/#review125799 --- src/slave/containerizer/mesos/containerizer.cpp (line 786)

Re: Review Request 45358: Improved overlay backend to make the rootfs writable.

2016-03-28 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45358/#review125670 --- src/slave/containerizer/mesos/provisioner/backends/overlay.cpp

Re: Review Request 45358: Improved overlay backend to make the rootfs writable.

2016-03-27 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45358/#review125566 --- Patch looks great! Reviews applied: [45358] Passed command:

Re: Review Request 45358: Improved overlay backend to make the rootfs writable.

2016-03-27 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45358/ --- (Updated March 27, 2016, 2:41 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 45358: Improved overlay backend to make the rootfs writable.

2016-03-27 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45358/ --- (Updated March 27, 2016, 2:40 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 45358: Improved overlay backend to make the rootfs writable.

2016-03-27 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45358/ --- (Updated March 27, 2016, 2:39 p.m.) Review request for mesos, Gilbert Song,

Review Request 45358: Improved overlay backend to make the rootfs writable.

2016-03-27 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45358/ --- Review request for mesos, Gilbert Song, Guangya Liu, and Jie Yu. Repository: