Re: Review Request 45377: Ignored docker volume when updating container volume path.

2016-04-24 Thread Guangya Liu
> On 四月 24, 2016, 5:29 a.m., Jie Yu wrote: > > src/slave/slave.cpp, lines 3826-3831 > > > > > > Can you adjust the comments here? It's not just for docker volumes. For > > other volume source types we'll add in

Re: Review Request 45377: Ignored docker volume when updating container volume path.

2016-04-24 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45377/ --- (Updated 四月 24, 2016, 8:08 a.m.) Review request for mesos, David vonThenen,

Re: Review Request 45377: Ignored docker volume when updating container volume path.

2016-04-24 Thread Guangya Liu
> On 四月 24, 2016, 5:29 a.m., Jie Yu wrote: > > src/slave/slave.cpp, lines 3826-3831 > > > > > > Can you adjust the comments here? It's not just for docker volumes. For > > other volume source types we'll add in

Re: Review Request 45377: Ignored docker volume when updating container volume path.

2016-04-23 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45377/#review130284 --- src/slave/slave.cpp (lines 3826 - 3831)

Re: Review Request 45377: Ignored docker volume when updating container volume path.

2016-04-23 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45377/ --- (Updated 四月 24, 2016, 3:44 a.m.) Review request for mesos, David vonThenen,

Re: Review Request 45377: Ignored docker volume when updating container volume path.

2016-04-23 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45377/#review130282 --- Fix it, then Ship it! src/slave/slave.cpp (line 3825)

Re: Review Request 45377: Ignored docker volume when updating container volume path.

2016-04-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45377/#review130245 --- Patch looks great! Reviews applied: [45377] Passed command:

Re: Review Request 45377: Ignored docker volume when updating container volume path.

2016-04-22 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45377/ --- (Updated 四月 23, 2016, 2:03 a.m.) Review request for mesos, David vonThenen,