> On 四月 24, 2016, 5:29 a.m., Jie Yu wrote: > > src/slave/slave.cpp, lines 3826-3831 > > <https://reviews.apache.org/r/45377/diff/7/?file=1358660#file1358660line3826> > > > > Can you adjust the comments here? It's not just for docker volumes. For > > other volume source types we'll add in the future, it also applies, right? > > Guangya Liu wrote: > Yes, may apply to other volume source types, what about adding a TODO > here but keep the current comments unchanged, as currently, only docker > volume is supported. what about adding a TODO here as `TODO(gyliu513): revist > this part when introducing new volume source types.`
We may have another two sources as `HOST_PATH` and `IMAGE` but they may not fit into the case here as the `IMAGE` source will be provisioned and then set the rootfs as the container host path. https://github.com/apache/mesos/blob/master/src/slave/containerizer/mesos/containerizer.cpp#L811-L835 - Guangya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45377/#review130284 ----------------------------------------------------------- On 四月 24, 2016, 3:44 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45377/ > ----------------------------------------------------------- > > (Updated 四月 24, 2016, 3:44 a.m.) > > > Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and > Jie Yu. > > > Bugs: MESOS-5013 > https://issues.apache.org/jira/browse/MESOS-5013 > > > Repository: mesos > > > Description > ------- > > Ignored docker volume when updating container volume path. > > > Diffs > ----- > > src/slave/slave.cpp ebf26065326be67db435f1b097964c8ff2e1dbe0 > > Diff: https://reviews.apache.org/r/45377/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > Guangya Liu > >
