Re: Review Request 45381: Migrate /monitor/statistics and /monitor/statistics.json to slave.

> On April 12, 2016, 1:38 p.m., Joerg Schad wrote: > > src/slave/slave.cpp, line 748 > > > > > > I believe you should have moved the deprecation comment as well. I > > added it back with https://reviews.apache.org/r

Re: Review Request 45381: Migrate /monitor/statistics and /monitor/statistics.json to slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45381/#review128388 --- src/slave/slave.cpp (line 747)

Re: Review Request 45381: Migrate /monitor/statistics and /monitor/statistics.json to slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45381/ --- (Updated April 6, 2016, 6:16 p.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 45381: Migrate /monitor/statistics and /monitor/statistics.json to slave.

> On April 6, 2016, 4:16 p.m., Jie Yu wrote: > > have you tested in this patch? The compile does not pass on all platforms > > in our CI. NVM, i didn't see the new dependent patch :( - Jie --- This is an automatically generated e-mail.

Re: Review Request 45381: Migrate /monitor/statistics and /monitor/statistics.json to slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45381/#review127357 --- have you tested in this patch? The compile does not pass on all pl

Re: Review Request 45381: Migrate /monitor/statistics and /monitor/statistics.json to slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45381/#review127307 --- Patch looks great! Reviews applied: [45794, 45381] Passed comman

Re: Review Request 45381: Migrate /monitor/statistics and /monitor/statistics.json to slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45381/ --- (Updated April 6, 2016, 5:33 a.m.) Review request for mesos and Jie Yu. Repos

Re: Review Request 45381: Migrate /monitor/statistics and /monitor/statistics.json to slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45381/#review127281 --- Bad review! Reviews applied: [45381] Error: No reviewers specifi

Re: Review Request 45381: Migrate /monitor/statistics and /monitor/statistics.json to slave.

> On March 31, 2016, 7:14 p.m., Jie Yu wrote: > > src/slave/slave.hpp, line 550 > > > > > > Can you move this field to Http class because this is a limiter for the > > http endpoint. Also, `limiter` sounds too gener

Re: Review Request 45381: Migrate /monitor/statistics and /monitor/statistics.json to slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45381/ --- (Updated April 6, 2016, 3:28 a.m.) Review request for mesos and Jie Yu. Chang

Re: Review Request 45381: Migrate /monitor/statistics and /monitor/statistics.json to slave.

> On March 31, 2016, 7:14 p.m., Jie Yu wrote: > > src/slave/slave.hpp, line 550 > > > > > > Can you move this field to Http class because this is a limiter for the > > http endpoint. Also, `limiter` sounds too gener

Re: Review Request 45381: Migrate /monitor/statistics and /monitor/statistics.json to slave.

> On March 31, 2016, 7:14 p.m., Jie Yu wrote: > > src/slave/slave.hpp, line 550 > > > > > > Can you move this field to Http class because this is a limiter for the > > http endpoint. Also, `limiter` sounds too gener

Re: Review Request 45381: Migrate /monitor/statistics and /monitor/statistics.json to slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45381/#review126959 --- Patch looks great! Reviews applied: [45381] Passed command: expo

Re: Review Request 45381: Migrate /monitor/statistics and /monitor/statistics.json to slave.

> On March 31, 2016, 7:14 p.m., Jie Yu wrote: > > src/slave/slave.hpp, line 550 > > > > > > Can you move this field to Http class because this is a limiter for the > > http endpoint. Also, `limiter` sounds too gener

Re: Review Request 45381: Migrate /monitor/statistics and /monitor/statistics.json to slave.

> On March 31, 2016, 7:14 p.m., Jie Yu wrote: > > src/slave/slave.hpp, line 550 > > > > > > Can you move this field to Http class because this is a limiter for the > > http endpoint. Also, `limiter` sounds too gener

Re: Review Request 45381: Migrate /monitor/statistics and /monitor/statistics.json to slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45381/ --- (Updated April 2, 2016, 10:31 a.m.) Review request for mesos and Jie Yu. Chan

Re: Review Request 45381: Migrate /monitor/statistics and /monitor/statistics.json to slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45381/#review126360 --- src/Makefile.am

Re: Review Request 45381: Migrate /monitor/statistics and /monitor/statistics.json to slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45381/#review126197 --- Patch looks great! Reviews applied: [45381] Passed command: expo

Re: Review Request 45381: Migrate /monitor/statistics and /monitor/statistics.json to slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45381/ --- (Updated March 30, 2016, 5:30 p.m.) Review request for mesos and Jie Yu. Chan