Re: Review Request 45536: Cleaned up temporary directories in `PersistentVolumeTest`.

2016-04-04 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45536/
---

(Updated April 4, 2016, 10:50 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.


Changes
---

Fixed the root issue, which is that disks were not being created as 
subdirectories correctly.


Bugs: MESOS-5044
https://issues.apache.org/jira/browse/MESOS-5044


Repository: mesos


Description (updated)
---

Added missing `path::join()` call.


Diffs (updated)
-

  src/tests/persistent_volume_tests.cpp 
7cb153cc6c0a8ca25cd31096686c63e829f746cf 

Diff: https://reviews.apache.org/r/45536/diff/


Testing
---

Vverified all temporary directories are accounted for by `Environment`.


Thanks,

Joris Van Remoortere

Re: Review Request 45536: Cleaned up temporary directories in `PersistentVolumeTest`.

2016-03-31 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45536/#review126346
---


Ship it!




Ship It!

- Jie Yu


On March 31, 2016, 12:16 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45536/
> ---
> 
> (Updated March 31, 2016, 12:16 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-5044
> https://issues.apache.org/jira/browse/MESOS-5044
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Used Environment `mkdtemp` for temporary mounts.
> 
> 
> Diffs
> -
> 
>   src/tests/persistent_volume_tests.cpp 
> 7cb153cc6c0a8ca25cd31096686c63e829f746cf 
> 
> Diff: https://reviews.apache.org/r/45536/diff/
> 
> 
> Testing
> ---
> 
> Vverified all temporary directories are accounted for by `Environment`.
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 45536: Cleaned up temporary directories in `PersistentVolumeTest`.

2016-03-31 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45536/#review126315
---



LGTM. I'll let Jie give the final ship it.


src/tests/persistent_volume_tests.cpp (line 94)


Any specific reason why you are creating a temp directory per disk instead 
of a top level temp directory and well known disk directories underneath? Just 
curious.


- Vinod Kone


On March 31, 2016, 12:16 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45536/
> ---
> 
> (Updated March 31, 2016, 12:16 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-5044
> https://issues.apache.org/jira/browse/MESOS-5044
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Used Environment `mkdtemp` for temporary mounts.
> 
> 
> Diffs
> -
> 
>   src/tests/persistent_volume_tests.cpp 
> 7cb153cc6c0a8ca25cd31096686c63e829f746cf 
> 
> Diff: https://reviews.apache.org/r/45536/diff/
> 
> 
> Testing
> ---
> 
> Vverified all temporary directories are accounted for by `Environment`.
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Review Request 45536: Cleaned up temporary directories in `PersistentVolumeTest`.

2016-03-31 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45536/
---

Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.


Bugs: MESOS-5044
https://issues.apache.org/jira/browse/MESOS-5044


Repository: mesos


Description
---

Used Environment `mkdtemp` for temporary mounts.


Diffs
-

  src/tests/persistent_volume_tests.cpp 
7cb153cc6c0a8ca25cd31096686c63e829f746cf 

Diff: https://reviews.apache.org/r/45536/diff/


Testing
---

Vverified all temporary directories are accounted for by `Environment`.


Thanks,

Joris Van Remoortere