Re: Review Request 46134: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries(2).

2016-04-13 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46134/#review128841 --- Patch looks great! Reviews applied: [45806, 46134] Passed comman

Re: Review Request 46134: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries(2).

2016-04-13 Thread zhou xing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46134/ --- (Updated 四月 14, 2016, 5 a.m.) Review request for mesos, Kevin Klues and Vinod K

Re: Review Request 46134: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries(2).

2016-04-13 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46134/#review128835 --- Ship it! It looks like the ReviewBot ran between the two most r

Re: Review Request 46134: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries(2).

2016-04-13 Thread zhou xing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46134/ --- (Updated 四月 14, 2016, 4:24 a.m.) Review request for mesos, Kevin Klues and Vino

Re: Review Request 46134: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries(2).

2016-04-13 Thread zhou xing
> On 四月 13, 2016, 11:25 p.m., Vinod Kone wrote: > > Looks like ReviewBot failed. Can you make sure to fix that issue? Otherwise > > LGTM. > > Kevin Klues wrote: > It looks like it's failing on this step: > ``` > make[5]: Entering directory `/mesos/mesos-0.29.0/_build/src' > cp /

Re: Review Request 46134: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries(2).

2016-04-13 Thread zhou xing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46134/ --- (Updated 四月 14, 2016, 3:24 a.m.) Review request for mesos, Kevin Klues and Vino

Re: Review Request 46134: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries(2).

2016-04-13 Thread Kevin Klues
> On April 13, 2016, 11:25 p.m., Vinod Kone wrote: > > Looks like ReviewBot failed. Can you make sure to fix that issue? Otherwise > > LGTM. It looks like it's failing on this step: ``` make[5]: Entering directory `/mesos/mesos-0.29.0/_build/src' cp /mesos/mesos-0.29.0/_inst/etc/mesos/mesos-age

Re: Review Request 46134: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries(2).

2016-04-13 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46134/#review128798 --- Looks like ReviewBot failed. Can you make sure to fix that issue?

Re: Review Request 46134: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries(2).

2016-04-13 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46134/#review128708 --- Ship it! Looks good! Only thing I'd add is to fill in the bugs

Review Request 46134: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries(2).

2016-04-12 Thread zhou xing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46134/ --- Review request for mesos. Repository: mesos Description --- [#mesos-3782