Re: Review Request 46341: Stout:[2/2] Transitioned reap.cpp to `os::waitpid`.

2016-04-22 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46341/#review130183 --- Ship it! Ship It! - Joris Van Remoortere On April 20, 2016,

Re: Review Request 46341: Stout:[2/2] Transitioned reap.cpp to `os::waitpid`.

2016-04-20 Thread Alex Clemmer
> On April 20, 2016, 7:05 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/src/reap.cpp, lines 98-106 > > > > > > Does this logic still work the same way, now that we are using `Result`? > > Are we handli

Re: Review Request 46341: Stout:[2/2] Transitioned reap.cpp to `os::waitpid`.

2016-04-20 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46341/#review129780 --- 3rdparty/libprocess/src/reap.cpp (lines 98 - 106)

Re: Review Request 46341: Stout:[2/2] Transitioned reap.cpp to `os::waitpid`.

2016-04-20 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46341/ --- (Updated April 20, 2016, 4:37 p.m.) Review request for mesos, Alex Naparu, Dani

Review Request 46341: Stout:[2/2] Transitioned reap.cpp to `os::waitpid`.

2016-04-18 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46341/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris V