-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46341/#review129780
-----------------------------------------------------------




3rdparty/libprocess/src/reap.cpp (lines 98 - 106)
<https://reviews.apache.org/r/46341/#comment193337>

    Does this logic still work the same way, now that we are using `Result`?
    Are we handling the `Error` and `None` states the same?


- Joris Van Remoortere


On April 20, 2016, 4:37 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46341/
> -----------------------------------------------------------
> 
> (Updated April 20, 2016, 4:37 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-4466
>     https://issues.apache.org/jira/browse/MESOS-4466
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Stout:[2/2] Transitioned reap.cpp to `os::waitpid`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/reap.cpp 110386842d5eeccfbc4e48bfca88d79a9d087fb0 
> 
> Diff: https://reviews.apache.org/r/46341/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Reply via email to