Re: Review Request 46779: Clarified and improved maintenance docs.

2016-05-05 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46779/#review131940
---


Ship it!




Ship It!

- Jie Yu


On May 1, 2016, 8:49 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46779/
> ---
> 
> (Updated May 1, 2016, 8:49 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Clarified and improved maintenance docs.
> 
> 
> Diffs
> -
> 
>   docs/maintenance.md 1f2b14fcbe86b0a2dc1ad59ce1b17d9d07409930 
> 
> Diff: https://reviews.apache.org/r/46779/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 46779: Clarified and improved maintenance docs.

2016-05-01 Thread Neil Conway 


> On April 29, 2016, 10:02 p.m., Joseph Wu wrote:
> > docs/maintenance.md, lines 269-273
> > 
> >
> > I would put this paragraph in a `>NOTE:`

Personally I'd opt to keep this as-is: other paragraphs in the same section 
(e.g., Draining -> Deactivated transition) are similarly parenthetical 
comments, but I don't think we need to make one paragraph more prominent than 
another.


- Neil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46779/#review131187
---


On April 28, 2016, 2:53 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46779/
> ---
> 
> (Updated April 28, 2016, 2:53 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Clarified and improved maintenance docs.
> 
> 
> Diffs
> -
> 
>   docs/maintenance.md 1f2b14fcbe86b0a2dc1ad59ce1b17d9d07409930 
> 
> Diff: https://reviews.apache.org/r/46779/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 46779: Clarified and improved maintenance docs.

2016-05-01 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46779/
---

(Updated May 1, 2016, 8:49 a.m.)


Review request for mesos and Jie Yu.


Changes
---

Address comments.


Repository: mesos


Description
---

Clarified and improved maintenance docs.


Diffs (updated)
-

  docs/maintenance.md 1f2b14fcbe86b0a2dc1ad59ce1b17d9d07409930 

Diff: https://reviews.apache.org/r/46779/diff/


Testing
---


Thanks,

Neil Conway

Re: Review Request 46779: Clarified and improved maintenance docs.

2016-04-29 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46779/#review131187
---


Fix it, then Ship it!




Some suggestions below:


docs/maintenance.md (line 184)


s/their/the machine's/



docs/maintenance.md (line 188)


s/Inverse offers/Inverse offers are also used to/



docs/maintenance.md (lines 260 - 264)


I would put this paragraph in a `>NOTE:`


- Joseph Wu


On April 28, 2016, 7:53 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46779/
> ---
> 
> (Updated April 28, 2016, 7:53 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Clarified and improved maintenance docs.
> 
> 
> Diffs
> -
> 
>   docs/maintenance.md 1f2b14fcbe86b0a2dc1ad59ce1b17d9d07409930 
> 
> Diff: https://reviews.apache.org/r/46779/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Review Request 46779: Clarified and improved maintenance docs.

2016-04-28 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46779/
---

Review request for mesos and Jie Yu.


Repository: mesos


Description
---

Clarified and improved maintenance docs.


Diffs
-

  docs/maintenance.md 1f2b14fcbe86b0a2dc1ad59ce1b17d9d07409930 

Diff: https://reviews.apache.org/r/46779/diff/


Testing
---


Thanks,

Neil Conway