Re: Review Request 47082: LostSlaveMessage should be sent to affected frameworks only.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47082/#review167322 --- Closing this review due to inactivity. Please see our

Re: Review Request 47082: LostSlaveMessage should be sent to affected frameworks only.

> On June 10, 2016, 5:47 a.m., Neil Conway wrote: > > Something else to consider here: this change means that frameworks will > > miss a `slaveLost()` signal that they care about in some circumstances. For > > example, suppose an agent has a persistent volume on an agent; the master > > fails

Re: Review Request 47082: LostSlaveMessage should be sent to affected frameworks only.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47082/#review136992 --- Something else to consider here: this change means that

Re: Review Request 47082: LostSlaveMessage should be sent to affected frameworks only.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47082/#review136774 --- src/master/master.cpp (line 6858)

Re: Review Request 47082: LostSlaveMessage should be sent to affected frameworks only.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47082/#review136759 --- Patch looks great! Reviews applied: [48453, 47082] Passed

Re: Review Request 47082: LostSlaveMessage should be sent to affected frameworks only.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47082/ --- (Updated June 9, 2016, 1:08 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 47082: LostSlaveMessage should be sent to affected frameworks only.

> On June 6, 2016, 5:43 a.m., Jiang Yan Xu wrote: > > src/tests/master_tests.cpp, line 1760 > > > > > > So the following two tests actually caught something we didn't > > anticipate, so instead of "fixing" the

Re: Review Request 47082: LostSlaveMessage should be sent to affected frameworks only.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47082/#review135384 --- See the comment I had on the tests: I think we should revisit the

Re: Review Request 47082: LostSlaveMessage should be sent to affected frameworks only.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47082/#review135132 --- Patch looks great! Reviews applied: [47082] Passed command:

Re: Review Request 47082: LostSlaveMessage should be sent to affected frameworks only.

> On May 25, 2016, 6:27 p.m., Jiang Yan Xu wrote: > > src/master/master.cpp, line 6551 > > > > > > I don't feel that this boolean is necessary, we can easily check if a > > framework is added by checking if it's

Re: Review Request 47082: LostSlaveMessage should be sent to affected frameworks only.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47082/ --- (Updated May 26, 2016, 11:56 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 47082: LostSlaveMessage should be sent to affected frameworks only.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47082/#review134535 --- I think for this patch we should at least have one test case

Re: Review Request 47082: LostSlaveMessage should be sent to affected frameworks only.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47082/#review132122 --- Patch looks great! Reviews applied: [47082] Passed command:

Review Request 47082: LostSlaveMessage should be sent to affected frameworks only.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47082/ --- Review request for mesos and Jiang Yan Xu. Bugs: MESOS-5143