Re: Review Request 47123: Added --modules_dir flag to read module manifests from a directory.

2016-05-30 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47123/ --- (Updated May 30, 2016, 11:54 a.m.) Review request for mesos, Cody Maloney and T

Re: Review Request 47123: Added --modules_dir flag to read module manifests from a directory.

2016-05-30 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47123/ --- (Updated May 30, 2016, 11:22 a.m.) Review request for mesos, Cody Maloney and T

Re: Review Request 47123: Added --modules_dir flag to read module manifests from a directory.

2016-05-30 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47123/ --- (Updated May 30, 2016, 11:19 a.m.) Review request for mesos, Cody Maloney and T

Re: Review Request 47123: Added --modules_dir flag to read module manifests from a directory.

2016-05-30 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47123/#review135516 --- Fix it, then Ship it! src/module/manager.hpp (line 37)

Re: Review Request 47123: Added --modules_dir flag to read module manifests from a directory.

2016-05-26 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47123/ --- (Updated May 26, 2016, 1:04 p.m.) Review request for mesos, Cody Maloney and Ti

Re: Review Request 47123: Added --modules_dir flag to read module manifests from a directory.

2016-05-23 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47123/#review134342 --- Looks good Kapil! I would like to have tests and documentation up

Re: Review Request 47123: Added --modules_dir flag to read module manifests from a directory.

2016-05-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47123/#review134106 --- Patch looks great! Reviews applied: [47123] Passed command: expo

Re: Review Request 47123: Added --modules_dir flag to read module manifests from a directory.

2016-05-19 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47123/ --- (Updated May 19, 2016, 10:40 p.m.) Review request for mesos, Cody Maloney and T

Re: Review Request 47123: Added --modules_dir flag to read module manifests from a directory.

2016-05-19 Thread Kapil Arya
> On May 10, 2016, 1:27 a.m., Cody Maloney wrote: > > src/module/manager.cpp, line 377 > > > > > > Is there a semantic difference between loading modules one at a time > > vs. just passing them all at once to loadMa

Re: Review Request 47123: Added --modules_dir flag to read module manifests from a directory.

2016-05-19 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47123/ --- (Updated May 19, 2016, 5:51 p.m.) Review request for mesos, Cody Maloney and Ti

Re: Review Request 47123: Added --modules_dir flag to read module manifests from a directory.

2016-05-09 Thread Cody Maloney
> On May 10, 2016, 5:27 a.m., Cody Maloney wrote: > > I believe this covers the use cases we need. Be great to have a demo PR of it in action for: https://github.com/dcos/dcos to validate that it does. - Cody --- This is an automatica

Re: Review Request 47123: Added --modules_dir flag to read module manifests from a directory.

2016-05-09 Thread Cody Maloney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47123/#review132372 --- src/module/manager.cpp (line 357)

Re: Review Request 47123: Added --modules_dir flag to read module manifests from a directory.

2016-05-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47123/#review132307 --- Patch looks great! Reviews applied: [47123] Passed command: expo

Re: Review Request 47123: Added --modules_dir flag to read module manifests from a directory.

2016-05-09 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47123/ --- (Updated May 9, 2016, 1:10 p.m.) Review request for mesos, Cody Maloney and Til

Re: Review Request 47123: Added --modules_dir flag to read module manifests from a directory.

2016-05-09 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47123/ --- (Updated May 9, 2016, 1:05 p.m.) Review request for mesos, Cody Maloney and Til

Review Request 47123: Added --modules_dir flag to read module manifests from a directory.

2016-05-09 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47123/ --- Review request for mesos, Cody Maloney and Till Toenshoff. Bugs: MESOS-5173