Re: Review Request 47259: CHECK if DRFSorter::add() would introduce a duplicate.

2016-06-07 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47259/#review136557 --- Ship it! Ship It! - Joris Van Remoortere On May 19, 2016,

Re: Review Request 47259: CHECK if DRFSorter::add() would introduce a duplicate.

2016-05-26 Thread Jiang Yan Xu
> On May 25, 2016, 1:28 p.m., Joris Van Remoortere wrote: > > src/master/allocator/sorter/drf/sorter.cpp, line 50 > > > > > > Why can this be a `CHECK` if the previous review can't? > > What is the standard we're

Re: Review Request 47259: CHECK if DRFSorter::add() would introduce a duplicate.

2016-05-25 Thread Jiang Yan Xu
> On May 25, 2016, 1:28 p.m., Joris Van Remoortere wrote: > > src/master/allocator/sorter/drf/sorter.cpp, line 50 > > > > > > Why can this be a `CHECK` if the previous review can't? > > What is the standard we're

Re: Review Request 47259: CHECK if DRFSorter::add() would introduce a duplicate.

2016-05-25 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47259/#review134829 --- src/master/allocator/sorter/drf/sorter.cpp (line 50)

Re: Review Request 47259: CHECK if DRFSorter::add() would introduce a duplicate.

2016-05-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47259/#review133010 --- Patch looks great! Reviews applied: [47258, 47259] Passed

Review Request 47259: CHECK if DRFSorter::add() would introduce a duplicate.

2016-05-12 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47259/ --- Review request for mesos and Dario Rexin. Bugs: MESOS-5279