Re: Review Request 47482: Added preliminary support for parsing ELF files in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47482/#review133838 --- Fix it, then Ship it! 3rdparty/stout/configure.ac (line 154)

Re: Review Request 47482: Added preliminary support for parsing ELF files in stout.

> On May 18, 2016, 5:35 p.m., Jojy Varghese wrote: > > 3rdparty/stout/include/stout/elf.hpp, line 56 > > > > > > Wondering why the implementation is in the header file. For better or worse, stout is a header-only

Re: Review Request 47482: Added preliminary support for parsing ELF files in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47482/#review133770 --- 3rdparty/stout/include/stout/elf.hpp (line 56)

Re: Review Request 47482: Added preliminary support for parsing ELF files in stout.

> On May 17, 2016, 10:23 p.m., Jojy Varghese wrote: > > 3rdparty/stout/include/stout/elf.hpp, line 77 > > > > > > Dont we have to close the open file in error cases? What I actually needed to be doing was deleting

Re: Review Request 47482: Added preliminary support for parsing ELF files in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47482/ --- (Updated May 18, 2016, 3:16 a.m.) Review request for mesos and Benjamin

Re: Review Request 47482: Added preliminary support for parsing ELF files in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47482/#review133647 --- 3rdparty/stout/include/stout/elf.hpp (line 77)