Re: Review Request 48400: Extract task collection logic to helper function.

2016-06-28 Thread Jay Guo
> On June 27, 2016, 8:29 p.m., Vinod Kone wrote: > > src/master/http.cpp, line 2706 > > > > > > I was looking at this code today and realized this might not be safe? > > What's the guarantee that a given `Task*`

Re: Review Request 48400: Extract task collection logic to helper function.

2016-06-27 Thread Vinod Kone
> On June 27, 2016, 8:29 p.m., Vinod Kone wrote: > > src/master/http.cpp, line 2706 > > > > > > I was looking at this code today and realized this might not be safe? > > What's the guarantee that a given `Task*`

Re: Review Request 48400: Extract task collection logic to helper function.

2016-06-27 Thread Anand Mazumdar
> On June 27, 2016, 8:29 p.m., Vinod Kone wrote: > > src/master/http.cpp, line 2706 > > > > > > I was looking at this code today and realized this might not be safe? > > What's the guarantee that a given `Task*`

Re: Review Request 48400: Extract task collection logic to helper function.

2016-06-27 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48400/#review139640 --- src/master/http.cpp (line 2706)

Re: Review Request 48400: Extract task collection logic to helper function.

2016-06-17 Thread Jay Guo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48400/ --- (Updated June 18, 2016, 2:33 a.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 48400: Extract task collection logic to helper function.

2016-06-09 Thread Jay Guo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48400/ --- (Updated June 9, 2016, 11:13 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 48400: Extract task collection logic to helper function.

2016-06-09 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48400/#review136820 --- Ship it! Ship It! - Vinod Kone On June 9, 2016, midnight,

Re: Review Request 48400: Extract task collection logic to helper function.

2016-06-08 Thread Jay Guo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48400/ --- (Updated June 9, 2016, midnight) Review request for mesos, Anand Mazumdar and

Re: Review Request 48400: Extract task collection logic to helper function.

2016-06-08 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48400/#review136655 --- src/master/master.hpp (lines 1245 - 1246)

Review Request 48400: Extract task collection logic to helper function.

2016-06-08 Thread Jay Guo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48400/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Bugs: MESOS-5493