----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48400/#review136655 -----------------------------------------------------------
src/master/master.hpp (lines 1245 - 1246) <https://reviews.apache.org/r/48400/#comment201747> no need to take refs for these primitive types. just take them by value. ... size_t limit, size_t offset, .... also see my comments in the last review in this chain. i think this function's responsiblity can be little different than what you have here. - Vinod Kone On June 8, 2016, 7:17 a.m., Jay Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48400/ > ----------------------------------------------------------- > > (Updated June 8, 2016, 7:17 a.m.) > > > Review request for mesos, Anand Mazumdar and Vinod Kone. > > > Bugs: MESOS-5493 > https://issues.apache.org/jira/browse/MESOS-5493 > > > Repository: mesos > > > Description > ------- > > Add a helper function _tasks() to collect tasks. This is > to be used by both tasks() and getTasks() in operator API. > > > Diffs > ----- > > src/master/http.cpp 4b2d1386e1ecb447b597a432f9df9adaa5c3aa37 > src/master/master.hpp 790da3ce686401c378ad9c62d497d60893c4ce41 > > Diff: https://reviews.apache.org/r/48400/diff/ > > > Testing > ------- > > make check on ubuntu 14.04 > > > Thanks, > > Jay Guo > >
