Re: Review Request 48450: Add unit test for master /tasks endpoint.

2016-06-17 Thread Jay Guo 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48450/
---

(Updated June 18, 2016, 2:33 a.m.)


Review request for mesos and Vinod Kone.


Changes
---

rebase


Repository: mesos


Description
---

Add unit test for master /tasks endpoint.


Diffs (updated)
-

  src/tests/master_tests.cpp ad05437d67a18ff1f323203fc6f43eca807ee84c 

Diff: https://reviews.apache.org/r/48450/diff/


Testing
---

make check on Ubuntu 14.04 & OSX

I didn't find unit test for this endpoint, therefore adding it.


Thanks,

Jay Guo

Re: Review Request 48450: Add unit test for master /tasks endpoint.

2016-06-17 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48450/#review138339
---



can you rebase this chain?

- Vinod Kone


On June 9, 2016, 11:13 p.m., Jay Guo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48450/
> ---
> 
> (Updated June 9, 2016, 11:13 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add unit test for master /tasks endpoint.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp 0d64e353f0682017953b524a5f5246d76f52fa2e 
> 
> Diff: https://reviews.apache.org/r/48450/diff/
> 
> 
> Testing
> ---
> 
> make check on Ubuntu 14.04 & OSX
> 
> I didn't find unit test for this endpoint, therefore adding it.
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Re: Review Request 48450: Add unit test for master /tasks endpoint.

2016-06-17 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48450/#review138338
---


Ship it!




Ship It!

- Vinod Kone


On June 9, 2016, 11:13 p.m., Jay Guo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48450/
> ---
> 
> (Updated June 9, 2016, 11:13 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add unit test for master /tasks endpoint.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp 0d64e353f0682017953b524a5f5246d76f52fa2e 
> 
> Diff: https://reviews.apache.org/r/48450/diff/
> 
> 
> Testing
> ---
> 
> make check on Ubuntu 14.04 & OSX
> 
> I didn't find unit test for this endpoint, therefore adding it.
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Re: Review Request 48450: Add unit test for master /tasks endpoint.

2016-06-17 Thread haosdent huang 


> On June 17, 2016, 6:20 a.m., haosdent huang wrote:
> > src/tests/master_tests.cpp, line 2510
> > 
> >
> > Should we add
> > ```
> > .WillRepeatedly(Return());
> > ```
> > here, may receive statusUpdate multiple times, right?
> 
> Jay Guo wrote:
> AFAIK, a successfully launched mock task only invokes statusUpdate once, 
> hence we shouldn't really expect multiple calls in this case.

I think we may receive TASK_RUNNING multiple tasks and TASK_FINISHED one time 
refer to 
https://github.com/apache/mesos/blob/master/src/tests/disk_quota_tests.cpp#L398-L400
But it looks OK for me because this test case passed in my local env. Let me 
drop this.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48450/#review138168
---


On June 9, 2016, 11:13 p.m., Jay Guo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48450/
> ---
> 
> (Updated June 9, 2016, 11:13 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add unit test for master /tasks endpoint.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp 0d64e353f0682017953b524a5f5246d76f52fa2e 
> 
> Diff: https://reviews.apache.org/r/48450/diff/
> 
> 
> Testing
> ---
> 
> make check on Ubuntu 14.04 & OSX
> 
> I didn't find unit test for this endpoint, therefore adding it.
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Re: Review Request 48450: Add unit test for master /tasks endpoint.

2016-06-17 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48450/#review138265
---


Ship it!




Ship It!

- haosdent huang


On June 9, 2016, 11:13 p.m., Jay Guo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48450/
> ---
> 
> (Updated June 9, 2016, 11:13 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add unit test for master /tasks endpoint.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp 0d64e353f0682017953b524a5f5246d76f52fa2e 
> 
> Diff: https://reviews.apache.org/r/48450/diff/
> 
> 
> Testing
> ---
> 
> make check on Ubuntu 14.04 & OSX
> 
> I didn't find unit test for this endpoint, therefore adding it.
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Re: Review Request 48450: Add unit test for master /tasks endpoint.

2016-06-17 Thread Jay Guo 


> On June 17, 2016, 6:20 a.m., haosdent huang wrote:
> > src/tests/master_tests.cpp, line 2510
> > 
> >
> > Should we add
> > ```
> > .WillRepeatedly(Return());
> > ```
> > here, may receive statusUpdate multiple times, right?

AFAIK, a successfully launched mock task only invokes statusUpdate once, hence 
we shouldn't really expect multiple calls in this case.


- Jay


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48450/#review138168
---


On June 9, 2016, 11:13 p.m., Jay Guo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48450/
> ---
> 
> (Updated June 9, 2016, 11:13 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add unit test for master /tasks endpoint.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp 0d64e353f0682017953b524a5f5246d76f52fa2e 
> 
> Diff: https://reviews.apache.org/r/48450/diff/
> 
> 
> Testing
> ---
> 
> make check on Ubuntu 14.04 & OSX
> 
> I didn't find unit test for this endpoint, therefore adding it.
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Re: Review Request 48450: Add unit test for master /tasks endpoint.

2016-06-17 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48450/#review138168
---




src/tests/master_tests.cpp (line 2510)


Should we add
```
.WillRepeatedly(Return());
```
here, may receive statusUpdate multiple times, right?


- haosdent huang


On June 9, 2016, 11:13 p.m., Jay Guo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48450/
> ---
> 
> (Updated June 9, 2016, 11:13 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add unit test for master /tasks endpoint.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp 0d64e353f0682017953b524a5f5246d76f52fa2e 
> 
> Diff: https://reviews.apache.org/r/48450/diff/
> 
> 
> Testing
> ---
> 
> make check on Ubuntu 14.04 & OSX
> 
> I didn't find unit test for this endpoint, therefore adding it.
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Re: Review Request 48450: Add unit test for master /tasks endpoint.

2016-06-16 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48450/#review138139
---


Ship it!




Ship It!

- Vinod Kone


On June 9, 2016, 11:13 p.m., Jay Guo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48450/
> ---
> 
> (Updated June 9, 2016, 11:13 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add unit test for master /tasks endpoint.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp 0d64e353f0682017953b524a5f5246d76f52fa2e 
> 
> Diff: https://reviews.apache.org/r/48450/diff/
> 
> 
> Testing
> ---
> 
> make check on Ubuntu 14.04 & OSX
> 
> I didn't find unit test for this endpoint, therefore adding it.
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Re: Review Request 48450: Add unit test for master /tasks endpoint.

2016-06-09 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48450/#review136940
---



Patch looks great!

Reviews applied: [48400, 48401, 48449, 48046, 48450]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On June 9, 2016, 11:13 p.m., Jay Guo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48450/
> ---
> 
> (Updated June 9, 2016, 11:13 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add unit test for master /tasks endpoint.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp 0d64e353f0682017953b524a5f5246d76f52fa2e 
> 
> Diff: https://reviews.apache.org/r/48450/diff/
> 
> 
> Testing
> ---
> 
> make check on Ubuntu 14.04 & OSX
> 
> I didn't find unit test for this endpoint, therefore adding it.
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Re: Review Request 48450: Add unit test for master /tasks endpoint.

2016-06-09 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48450/#review136898
---




src/tests/master_tests.cpp (lines 2495 - 2518)


same comments apply as in the previous review.



src/tests/master_tests.cpp (line 2558)


this is awesome. thanks for going the extra mile to write this test!!


- Vinod Kone


On June 9, 2016, midnight, Jay Guo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48450/
> ---
> 
> (Updated June 9, 2016, midnight)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add unit test for master /tasks endpoint.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp 34be015aa314a7574e9065efb7b1bb8e1570c5b7 
> 
> Diff: https://reviews.apache.org/r/48450/diff/
> 
> 
> Testing
> ---
> 
> make check on Ubuntu 14.04 & OSX
> 
> I didn't find unit test for this endpoint, therefore adding it.
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Re: Review Request 48450: Add unit test for master /tasks endpoint.

2016-06-08 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48450/#review136746
---



Patch looks great!

Reviews applied: [48400, 48401, 48449, 48046, 48450]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On June 9, 2016, midnight, Jay Guo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48450/
> ---
> 
> (Updated June 9, 2016, midnight)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add unit test for master /tasks endpoint.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp 34be015aa314a7574e9065efb7b1bb8e1570c5b7 
> 
> Diff: https://reviews.apache.org/r/48450/diff/
> 
> 
> Testing
> ---
> 
> make check on Ubuntu 14.04 & OSX
> 
> I didn't find unit test for this endpoint, therefore adding it.
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Review Request 48450: Add unit test for master /tasks endpoint.

2016-06-08 Thread Jay Guo 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48450/
---

Review request for mesos and Vinod Kone.


Repository: mesos


Description
---

Add unit test for master /tasks endpoint.


Diffs
-

  src/tests/master_tests.cpp 34be015aa314a7574e9065efb7b1bb8e1570c5b7 

Diff: https://reviews.apache.org/r/48450/diff/


Testing
---

make check on Ubuntu 14.04 & OSX

I didn't find unit test for this endpoint, therefore adding it.


Thanks,

Jay Guo