Re: Review Request 48669: Modified os user test for user switching.

2016-06-15 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48669/
---

(Updated June 15, 2016, 2:56 p.m.)


Review request for mesos, Artem Harutyunyan, Jie Yu, James Peach, Kevin Klues, 
and Timothy Chen.


Bugs: MESOS-4757
https://issues.apache.org/jira/browse/MESOS-4757


Repository: mesos


Description
---

This test verifies 'setuid', 'setgid', 'getgrouplist' and
'setgroups' work properly on both linux and os x.


Diffs (updated)
-

  3rdparty/stout/tests/os_tests.cpp af1a76c3d950cf9062a985c6040d92bd8be14cb8 

Diff: https://reviews.apache.org/r/48669/diff/


Testing
---

make check


Thanks,

Gilbert Song

Re: Review Request 48669: Modified os user test for user switching.

2016-06-15 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48669/
---

(Updated June 15, 2016, 10:46 a.m.)


Review request for mesos, Artem Harutyunyan, Jie Yu, James Peach, Kevin Klues, 
and Timothy Chen.


Bugs: MESOS-4757
https://issues.apache.org/jira/browse/MESOS-4757


Repository: mesos


Description
---

This test verifies 'setuid', 'setgid', 'getgrouplist' and
'setgroups' work properly on both linux and os x.


Diffs (updated)
-

  3rdparty/stout/tests/os_tests.cpp af1a76c3d950cf9062a985c6040d92bd8be14cb8 

Diff: https://reviews.apache.org/r/48669/diff/


Testing
---

make check


Thanks,

Gilbert Song

Re: Review Request 48669: Modified os user test for user switching.

2016-06-14 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48669/
---

(Updated June 14, 2016, 4:29 p.m.)


Review request for mesos, Artem Harutyunyan, Jie Yu, James Peach, Kevin Klues, 
and Timothy Chen.


Bugs: MESOS-4757
https://issues.apache.org/jira/browse/MESOS-4757


Repository: mesos


Description
---

This test verifies 'setuid', 'setgid', 'getgrouplist' and
'setgroups' work properly on both linux and os x.


Diffs (updated)
-

  3rdparty/stout/tests/os_tests.cpp af1a76c3d950cf9062a985c6040d92bd8be14cb8 

Diff: https://reviews.apache.org/r/48669/diff/


Testing
---

make check


Thanks,

Gilbert Song

Re: Review Request 48669: Modified os user test for user switching.

2016-06-14 Thread Gilbert Song 


> On June 13, 2016, 6:07 p.m., James Peach wrote:
> > 3rdparty/stout/tests/os_tests.cpp, line 685
> > 
> >
> > Since you need root, consider making this a separate test using the 
> > "ROOT_" filter.

stout test does not support filtering for now. That is the reason we check root 
in this way. You can find other example in os_tests.cpp


> On June 13, 2016, 6:07 p.m., James Peach wrote:
> > 3rdparty/stout/tests/os_tests.cpp, line 689
> > 
> >
> > In general, this kind of stuff is hard to validate in unit tests. 
> > Ideally you would find a user account with > 16 groups, then create a 
> > resource that only allows access to the high groups and verify that you 
> > have access when you impersonate that use. That's pretty involved, so just 
> > mentioning it for the future :)

Good to know that! thanks, James!


- Gilbert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48669/#review137433
---


On June 13, 2016, 4:51 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48669/
> ---
> 
> (Updated June 13, 2016, 4:51 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, James Peach, Kevin 
> Klues, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This test verifies 'setuid', 'setgid', 'getgrouplist' and
> 'setgroups' work properly on both linux and os x.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/tests/os_tests.cpp af1a76c3d950cf9062a985c6040d92bd8be14cb8 
> 
> Diff: https://reviews.apache.org/r/48669/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 48669: Modified os user test for user switching.

2016-06-13 Thread James Peach 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48669/#review137433
---




3rdparty/stout/tests/os_tests.cpp (line 685)


Since you need root, consider making this a separate test using the "ROOT_" 
filter.



3rdparty/stout/tests/os_tests.cpp (line 689)


In general, this kind of stuff is hard to validate in unit tests. Ideally 
you would find a user account with > 16 groups, then create a resource that 
only allows access to the high groups and verify that you have access when you 
impersonate that use. That's pretty involved, so just mentioning it for the 
future :)


- James Peach


On June 13, 2016, 11:51 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48669/
> ---
> 
> (Updated June 13, 2016, 11:51 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, James Peach, Kevin 
> Klues, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This test verifies 'setuid', 'setgid', 'getgrouplist' and
> 'setgroups' work properly on both linux and os x.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/tests/os_tests.cpp af1a76c3d950cf9062a985c6040d92bd8be14cb8 
> 
> Diff: https://reviews.apache.org/r/48669/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Review Request 48669: Modified os user test for user switching.

2016-06-13 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48669/
---

Review request for mesos, Artem Harutyunyan, Jie Yu, James Peach, Kevin Klues, 
and Timothy Chen.


Repository: mesos


Description
---

This test verifies 'setuid', 'setgid', 'getgrouplist' and
'setgroups' work properly on both linux and os x.


Diffs
-

  3rdparty/stout/tests/os_tests.cpp af1a76c3d950cf9062a985c6040d92bd8be14cb8 

Diff: https://reviews.apache.org/r/48669/diff/


Testing
---

make check


Thanks,

Gilbert Song