Re: Review Request 49206: Implemented GET_QUOTA Call in v1 master API.

2016-06-28 Thread Anand Mazumdar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49206/#review139815
---


Ship it!




Ship It!

- Anand Mazumdar


On June 28, 2016, 4:48 p.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49206/
> ---
> 
> (Updated June 28, 2016, 4:48 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.
> 
> 
> Bugs: MESOS-5508
> https://issues.apache.org/jira/browse/MESOS-5508
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented GET_QUOTA Call in v1 master API.
> 
> 
> Diffs
> -
> 
>   include/mesos/master/master.proto 332261918a069f4e581bfc4d0fc14ce8c86c2617 
>   include/mesos/v1/master/master.proto 
> 681ea1e638777059a6bf792435cbe526bc252f7a 
>   src/master/http.cpp 9e6d291aff77bb39462375dfed5dc75f3719806f 
>   src/master/master.hpp f16bccd0b72a8785d03290d11cd9b28d2990fd24 
>   src/master/quota_handler.cpp 4fa7533cb6a109fd060050c7814de440bd34c8ed 
>   src/tests/api_tests.cpp 7eb179f300f7a7dc6bdc3425268e7cd2fc8299fe 
> 
> Diff: https://reviews.apache.org/r/49206/diff/
> 
> 
> Testing
> ---
> 
> On Ubuntu 16.04 :
> 
> sudo GTEST_FILTER="*MasterAPITest.GetQuota*" make -j4 check
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Re: Review Request 49206: Implemented GET_QUOTA Call in v1 master API.

2016-06-28 Thread Abhishek Dasgupta 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49206/
---

(Updated June 28, 2016, 4:48 p.m.)


Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.


Bugs: MESOS-5508
https://issues.apache.org/jira/browse/MESOS-5508


Repository: mesos


Description
---

Implemented GET_QUOTA Call in v1 master API.


Diffs (updated)
-

  include/mesos/master/master.proto 332261918a069f4e581bfc4d0fc14ce8c86c2617 
  include/mesos/v1/master/master.proto 681ea1e638777059a6bf792435cbe526bc252f7a 
  src/master/http.cpp 9e6d291aff77bb39462375dfed5dc75f3719806f 
  src/master/master.hpp f16bccd0b72a8785d03290d11cd9b28d2990fd24 
  src/master/quota_handler.cpp 4fa7533cb6a109fd060050c7814de440bd34c8ed 
  src/tests/api_tests.cpp 7eb179f300f7a7dc6bdc3425268e7cd2fc8299fe 

Diff: https://reviews.apache.org/r/49206/diff/


Testing
---

On Ubuntu 16.04 :

sudo GTEST_FILTER="*MasterAPITest.GetQuota*" make -j4 check


Thanks,

Abhishek Dasgupta

Re: Review Request 49206: Implemented GET_QUOTA Call in v1 master API.

2016-06-28 Thread Abhishek Dasgupta 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49206/
---

(Updated June 28, 2016, 3:58 p.m.)


Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.


Bugs: MESOS-5508
https://issues.apache.org/jira/browse/MESOS-5508


Repository: mesos


Description
---

Implemented GET_QUOTA Call in v1 master API.


Diffs (updated)
-

  include/mesos/master/master.proto 332261918a069f4e581bfc4d0fc14ce8c86c2617 
  include/mesos/v1/master/master.proto 681ea1e638777059a6bf792435cbe526bc252f7a 
  src/master/http.cpp 9e6d291aff77bb39462375dfed5dc75f3719806f 
  src/master/master.hpp f16bccd0b72a8785d03290d11cd9b28d2990fd24 
  src/master/quota_handler.cpp 4fa7533cb6a109fd060050c7814de440bd34c8ed 
  src/tests/api_tests.cpp 7eb179f300f7a7dc6bdc3425268e7cd2fc8299fe 

Diff: https://reviews.apache.org/r/49206/diff/


Testing
---

On Ubuntu 16.04 :

sudo GTEST_FILTER="*MasterAPITest.GetQuota*" make -j4 check


Thanks,

Abhishek Dasgupta

Re: Review Request 49206: Implemented GET_QUOTA Call in v1 master API.

2016-06-28 Thread Abhishek Dasgupta 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49206/
---

(Updated June 28, 2016, 2:23 p.m.)


Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.


Bugs: MESOS-5508
https://issues.apache.org/jira/browse/MESOS-5508


Repository: mesos


Description
---

Implemented GET_QUOTA Call in v1 master API.


Diffs (updated)
-

  include/mesos/master/master.proto 332261918a069f4e581bfc4d0fc14ce8c86c2617 
  include/mesos/v1/master/master.proto 681ea1e638777059a6bf792435cbe526bc252f7a 
  src/master/http.cpp 9e6d291aff77bb39462375dfed5dc75f3719806f 
  src/master/master.hpp f16bccd0b72a8785d03290d11cd9b28d2990fd24 
  src/master/quota_handler.cpp 4fa7533cb6a109fd060050c7814de440bd34c8ed 
  src/tests/api_tests.cpp 7eb179f300f7a7dc6bdc3425268e7cd2fc8299fe 

Diff: https://reviews.apache.org/r/49206/diff/


Testing
---

On Ubuntu 16.04 :

sudo GTEST_FILTER="*MasterAPITest.GetQuota*" make -j4 check


Thanks,

Abhishek Dasgupta

Re: Review Request 49206: Implemented GET_QUOTA Call in v1 master API.

2016-06-26 Thread Anand Mazumdar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49206/#review139505
---



Looks good minus minor comments on style/indent.


include/mesos/master/master.proto (line 334)


s/quota info/cluster's configured quotas.

Ditto for the versioned one.



src/master/quota_handler.cpp (line 222)


Indent off by 1 for `stringify`.



src/master/quota_handler.cpp (line 268)


hmm .. can we move `__status` to inside the lambda itself rather than it 
being a separate function?

- We follow a procedural programming style and have continuation functions 
only when something is waiting on a different execution context.
- In one off cases, we move things out of a lambda when it's too long and 
might impact readability. (e.g., `__set` in this file)

Neithing of the above 2 seem to hold good here.



src/tests/api_tests.cpp (line 917)


Missing backticks around set quota.



src/tests/api_tests.cpp (line 943)


Fix the indent here. (2 spaces)

Add a new line before L943



src/tests/api_tests.cpp (line 944)


Move this comment out of the block and also add backticks.



src/tests/api_tests.cpp (line 948)


Do this after L923 since it's common to both blocks.



src/tests/api_tests.cpp (line 958)


Fix the indent to be right below `quotaResources`.


- Anand Mazumdar


On June 25, 2016, 9:03 a.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49206/
> ---
> 
> (Updated June 25, 2016, 9:03 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.
> 
> 
> Bugs: MESOS-5508
> https://issues.apache.org/jira/browse/MESOS-5508
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented GET_QUOTA Call in v1 master API.
> 
> 
> Diffs
> -
> 
>   include/mesos/master/master.proto 639fbd110df4aca1cf700cb9e455eecc110a7f66 
>   include/mesos/v1/master/master.proto 
> 11dfab318eb073908a9e302afa33b274fec63a16 
>   src/master/http.cpp ad3f723ec21dd0e9f3a3f015d4de0702625cd603 
>   src/master/master.hpp e983d1ba6ebcdaf2ace419201659e53edaa2a0aa 
>   src/master/quota_handler.cpp 4fa7533cb6a109fd060050c7814de440bd34c8ed 
>   src/tests/api_tests.cpp 7f16f43c3968cd56cf93951489079032093beaeb 
> 
> Diff: https://reviews.apache.org/r/49206/diff/
> 
> 
> Testing
> ---
> 
> On Ubuntu 16.04 :
> 
> sudo GTEST_FILTER="*MasterAPITest.GetQuota*" make -j4 check
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Re: Review Request 49206: Implemented GET_QUOTA Call in v1 master API.

2016-06-25 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49206/#review139450
---



Patch looks great!

Reviews applied: [49206]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On June 25, 2016, 9:03 a.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49206/
> ---
> 
> (Updated June 25, 2016, 9:03 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.
> 
> 
> Bugs: MESOS-5508
> https://issues.apache.org/jira/browse/MESOS-5508
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented GET_QUOTA Call in v1 master API.
> 
> 
> Diffs
> -
> 
>   include/mesos/master/master.proto 639fbd110df4aca1cf700cb9e455eecc110a7f66 
>   include/mesos/v1/master/master.proto 
> 11dfab318eb073908a9e302afa33b274fec63a16 
>   src/master/http.cpp ad3f723ec21dd0e9f3a3f015d4de0702625cd603 
>   src/master/master.hpp e983d1ba6ebcdaf2ace419201659e53edaa2a0aa 
>   src/master/quota_handler.cpp 4fa7533cb6a109fd060050c7814de440bd34c8ed 
>   src/tests/api_tests.cpp 7f16f43c3968cd56cf93951489079032093beaeb 
> 
> Diff: https://reviews.apache.org/r/49206/diff/
> 
> 
> Testing
> ---
> 
> On Ubuntu 16.04 :
> 
> sudo GTEST_FILTER="*MasterAPITest.GetQuota*" make -j4 check
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Re: Review Request 49206: Implemented GET_QUOTA Call in v1 master API.

2016-06-25 Thread Abhishek Dasgupta 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49206/
---

(Updated June 25, 2016, 9:03 a.m.)


Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.


Bugs: MESOS-5508
https://issues.apache.org/jira/browse/MESOS-5508


Repository: mesos


Description (updated)
---

Implemented GET_QUOTA Call in v1 master API.


Diffs
-

  include/mesos/master/master.proto 639fbd110df4aca1cf700cb9e455eecc110a7f66 
  include/mesos/v1/master/master.proto 11dfab318eb073908a9e302afa33b274fec63a16 
  src/master/http.cpp ad3f723ec21dd0e9f3a3f015d4de0702625cd603 
  src/master/master.hpp e983d1ba6ebcdaf2ace419201659e53edaa2a0aa 
  src/master/quota_handler.cpp 4fa7533cb6a109fd060050c7814de440bd34c8ed 
  src/tests/api_tests.cpp 7f16f43c3968cd56cf93951489079032093beaeb 

Diff: https://reviews.apache.org/r/49206/diff/


Testing
---

On Ubuntu 16.04 :

sudo GTEST_FILTER="*MasterAPITest.GetQuota*" make -j4 check


Thanks,

Abhishek Dasgupta

Re: Review Request 49206: Implemented GET_QUOTA Call in v1 master API.

2016-06-25 Thread Abhishek Dasgupta 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49206/
---

(Updated June 25, 2016, 9:03 a.m.)


Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.


Summary (updated)
-

Implemented GET_QUOTA Call in v1 master API.


Bugs: MESOS-5508
https://issues.apache.org/jira/browse/MESOS-5508


Repository: mesos


Description
---

Implemented Get_Quota.


Diffs
-

  include/mesos/master/master.proto 639fbd110df4aca1cf700cb9e455eecc110a7f66 
  include/mesos/v1/master/master.proto 11dfab318eb073908a9e302afa33b274fec63a16 
  src/master/http.cpp ad3f723ec21dd0e9f3a3f015d4de0702625cd603 
  src/master/master.hpp e983d1ba6ebcdaf2ace419201659e53edaa2a0aa 
  src/master/quota_handler.cpp 4fa7533cb6a109fd060050c7814de440bd34c8ed 
  src/tests/api_tests.cpp 7f16f43c3968cd56cf93951489079032093beaeb 

Diff: https://reviews.apache.org/r/49206/diff/


Testing
---

On Ubuntu 16.04 :

sudo GTEST_FILTER="*MasterAPITest.GetQuota*" make -j4 check


Thanks,

Abhishek Dasgupta

Re: Review Request 49206: Implemented GET_QUOTA Call in v1 master API.

2016-06-24 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49206/#review139434
---



Patch looks great!

Reviews applied: [49206]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On June 24, 2016, 5 p.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49206/
> ---
> 
> (Updated June 24, 2016, 5 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.
> 
> 
> Bugs: MESOS-5508
> https://issues.apache.org/jira/browse/MESOS-5508
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented GET_QUOTA Call in v1 master API.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 70f084b84db90fde20c05d2354be190f28e72996 
>   src/master/master.hpp e983d1ba6ebcdaf2ace419201659e53edaa2a0aa 
>   src/master/quota_handler.cpp 4fa7533cb6a109fd060050c7814de440bd34c8ed 
>   src/tests/api_tests.cpp 7f16f43c3968cd56cf93951489079032093beaeb 
> 
> Diff: https://reviews.apache.org/r/49206/diff/
> 
> 
> Testing
> ---
> 
> sudo GTEST_FILTER="*MasterAPITest.GetQuota*" make -j4 check
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Re: Review Request 49206: Implemented GET_QUOTA Call in v1 master API.

2016-06-24 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49206/#review139395
---




src/master/quota_handler.cpp (lines 215 - 230)


hmm. this stuff is duplicated from the other `status` overload. can you 
factor this out into a common method (`_status`) that both overloads can use?



src/master/quota_handler.cpp (line 286)


this might have to be renamed to `__status` per the comment above.


- Vinod Kone


On June 24, 2016, 5 p.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49206/
> ---
> 
> (Updated June 24, 2016, 5 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.
> 
> 
> Bugs: MESOS-5508
> https://issues.apache.org/jira/browse/MESOS-5508
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented GET_QUOTA Call in v1 master API.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 70f084b84db90fde20c05d2354be190f28e72996 
>   src/master/master.hpp e983d1ba6ebcdaf2ace419201659e53edaa2a0aa 
>   src/master/quota_handler.cpp 4fa7533cb6a109fd060050c7814de440bd34c8ed 
>   src/tests/api_tests.cpp 7f16f43c3968cd56cf93951489079032093beaeb 
> 
> Diff: https://reviews.apache.org/r/49206/diff/
> 
> 
> Testing
> ---
> 
> sudo GTEST_FILTER="*MasterAPITest.GetQuota*" make -j4 check
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Review Request 49206: Implemented GET_QUOTA Call in v1 master API.

2016-06-24 Thread Abhishek Dasgupta 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49206/
---

Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.


Bugs: MESOS-5508
https://issues.apache.org/jira/browse/MESOS-5508


Repository: mesos


Description
---

Implemented GET_QUOTA Call in v1 master API.


Diffs
-

  src/master/http.cpp 70f084b84db90fde20c05d2354be190f28e72996 
  src/master/master.hpp e983d1ba6ebcdaf2ace419201659e53edaa2a0aa 
  src/master/quota_handler.cpp 4fa7533cb6a109fd060050c7814de440bd34c8ed 
  src/tests/api_tests.cpp 7f16f43c3968cd56cf93951489079032093beaeb 

Diff: https://reviews.apache.org/r/49206/diff/


Testing
---

sudo GTEST_FILTER="*MasterAPITest.GetQuota*" make -j4 check


Thanks,

Abhishek Dasgupta