Re: Review Request 49308: Added agent and scheduler authentication backoff.

2016-07-06 Thread Adam B
> On July 6, 2016, 11:21 a.m., Adam B wrote: > > src/sched/sched.cpp, line 483 > > > > > > Seems `failedAuthentications` is never 0 here (since you increment it > > just before), so you'll never delay by the `[0, b

Re: Review Request 49308: Added agent and scheduler authentication backoff.

2016-07-06 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49308/#review141041 --- Fix it, then Ship it! Looks great, except for the mismatch

Re: Review Request 49308: Added agent and scheduler authentication backoff.

2016-07-06 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49308/ --- (Updated July 6, 2016, 3:58 p.m.) Review request for mesos, Adam B and Vinod

Re: Review Request 49308: Added agent and scheduler authentication backoff.

2016-07-06 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49308/ --- (Updated July 6, 2016, 3:04 p.m.) Review request for mesos, Adam B and Vinod

Re: Review Request 49308: Added agent and scheduler authentication backoff.

2016-07-06 Thread Benjamin Bannier
> On July 5, 2016, 12:20 p.m., Adam B wrote: > > src/slave/slave.cpp, lines 984-987 > > > > > > Does your solution address this trickiness after a master failover? AFAICT even the existing code exhibits that tricky

Re: Review Request 49308: Added agent and scheduler authentication backoff.

2016-07-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49308/#review140807 --- Patch looks great! Reviews applied: [49308] Passed command:

Re: Review Request 49308: Added agent and scheduler authentication backoff.

2016-07-05 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49308/#review140745 --- Yes, this is more like what I had in mind. - I would like to see

Re: Review Request 49308: Added agent and scheduler authentication backoff.

2016-06-29 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49308/ --- (Updated June 29, 2016, 9:08 a.m.) Review request for mesos, Adam B and Vinod

Re: Review Request 49308: Added agent and scheduler authentication backoff.

2016-06-28 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49308/#review139906 --- Patch looks great! Reviews applied: [49308] Passed command:

Review Request 49308: Added agent and scheduler authentication backoff.

2016-06-28 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49308/ --- Review request for mesos, Adam B and Vinod Kone. Bugs: MESOS-2043