Re: Review Request 49389: Refactored HealthCheck from a binary to be a library.

2016-07-01 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49389/ --- (Updated July 1, 2016, 5 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49389: Refactored HealthCheck from a binary to be a library.

2016-07-01 Thread Gilbert Song
> On July 1, 2016, 3:24 p.m., Jie Yu wrote: > > src/launcher/executor.cpp, lines 431-432 > > > > > > Hum, if `_check.isError()`, `checker->healthCheck()` below will abort. > > you should put

Re: Review Request 49389: Refactored HealthCheck from a binary to be a library.

2016-07-01 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49389/ --- (Updated July 1, 2016, 4:33 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49389: Refactored HealthCheck from a binary to be a library.

2016-07-01 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49389/#review140444 --- Fix it, then Ship it! src/health-check/health_checker.hpp

Re: Review Request 49389: Refactored HealthCheck from a binary to be a library.

2016-07-01 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49389/ --- (Updated July 1, 2016, 2:54 p.m.) Review request for mesos, Anand Mazumdar,