Re: Review Request 51553: Changed the way `HAP::updateAllocation()` calls `Resources.apply()`.

2016-09-07 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51553/#review148047 --- Ship it! Ship It! - Anindya Sinha On Sept. 7, 2016, 5:16

Re: Review Request 51553: Changed the way `HAP::updateAllocation()` calls `Resources.apply()`.

2016-09-07 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51553/ --- (Updated Sept. 7, 2016, 10:16 a.m.) Review request for mesos and Anindya

Re: Review Request 51553: Changed the way `HAP::updateAllocation()` calls `Resources.apply()`.

2016-09-06 Thread Jiang Yan Xu
> On Sept. 2, 2016, 5:39 a.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 686-689 > > > > > > Since here you are applying the `operations` one by one, I think that > > it is better to

Re: Review Request 51553: Changed the way `HAP::updateAllocation()` calls `Resources.apply()`.

2016-09-06 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51553/ --- (Updated Sept. 6, 2016, 11:15 a.m.) Review request for mesos and Anindya

Re: Review Request 51553: Changed the way `HAP::updateAllocation()` calls `Resources.apply()`.

2016-09-02 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51553/#review147651 --- src/master/allocator/mesos/hierarchical.cpp (lines 686 - 689)

Re: Review Request 51553: Changed the way `HAP::updateAllocation()` calls `Resources.apply()`.

2016-09-01 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51553/#review147594 --- Patch looks great! Reviews applied: [51566, 51553] Passed

Re: Review Request 51553: Changed the way `HAP::updateAllocation()` calls `Resources.apply()`.

2016-09-01 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51553/ --- (Updated Sept. 1, 2016, 9:35 a.m.) Review request for mesos and Anindya Sinha.

Re: Review Request 51553: Changed the way `HAP::updateAllocation()` calls `Resources.apply()`.

2016-08-31 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51553/#review147479 --- Patch looks great! Reviews applied: [51553] Passed command:

Review Request 51553: Changed the way `HAP::updateAllocation()` calls `Resources.apply()`.

2016-08-31 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51553/ --- Review request for mesos and Anindya Sinha. Repository: mesos Description