Re: Review Request 51840: Fixed leak of task.

2016-09-19 Thread Benjamin Bannier
> On Sept. 13, 2016, 3:16 p.m., Anand Mazumdar wrote: > > Thanks for fixing this. > > > > Ideally, I would like to not create the `Task` object/delete the key from > > `queuedTasks` on L6549/L6554 but instead do it in the `else` block on > > L6569. I would take care of cleaning it up as part

Re: Review Request 51840: Fixed leak of task.

2016-09-13 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51840/#review148714 --- Ship it! Thanks for fixing this. Ideally, I would like to not

Re: Review Request 51840: Fixed leak of task.

2016-09-13 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51840/#review148707 --- Patch looks great! Reviews applied: [51840] Passed command:

Review Request 51840: Fixed leak of task.

2016-09-13 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51840/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Bugs: MESOS-6153