Re: Review Request 51850: Removed unneeded `Resources::add/remove(const Resource&)`.

2016-09-13 Thread Guangya Liu
> On 九月 14, 2016, 12:08 a.m., Guangya Liu wrote: > > include/mesos/resources.hpp, lines 511-512 > > > > > > I think that we should also mention for how to convert a `Resource` > > object to `Resource_` object in

Re: Review Request 51850: Removed unneeded `Resources::add/remove(const Resource&)`.

2016-09-13 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51850/#review148815 --- include/mesos/resources.hpp (lines 503 - 504)

Re: Review Request 51850: Removed unneeded `Resources::add/remove(const Resource&)`.

2016-09-13 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51850/#review148793 --- Patch looks great! Reviews applied: [51850] Passed command:

Re: Review Request 51850: Removed unneeded `Resources::add/remove(const Resource&)`.

2016-09-13 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51850/#review148791 --- Ship it! Ship It! - Anindya Sinha On Sept. 13, 2016, 5:04

Re: Review Request 51850: Removed unneeded `Resources::add/remove(const Resource&)`.

2016-09-13 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51850/#review148743 --- Ship it! Ship It! - haosdent huang On Sept. 13, 2016, 5:04

Review Request 51850: Removed unneeded `Resources::add/remove(const Resource&)`.

2016-09-13 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51850/ --- Review request for mesos, Anindya Sinha and Guangya Liu. Repository: mesos