Re: Review Request 51999: Refactor parsing of resources to include all valid resources.

> On Sept. 20, 2016, 3:43 a.m., Guangya Liu wrote: > > include/mesos/resources.hpp, lines 187-188 > > > > > > Why update here, I prefer > > > > ``` > > parses text in the form

Re: Review Request 51999: Refactor parsing of resources to include all valid resources.

> On Sept. 20, 2016, 5 p.m., Jiang Yan Xu wrote: > > include/mesos/resources.hpp, lines 60-64 > > > > > > We can get rid of this forward declaration if we can get rid of the > > internal convertJSON. Based on the

Re: Review Request 51999: Refactor parsing of resources to include all valid resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51999/#review149624 --- include/mesos/resources.hpp (lines 60 - 64)

Re: Review Request 51999: Refactor parsing of resources to include all valid resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51999/#review149603 --- Ditto for v1 include/mesos/resources.hpp (lines 187 - 188)

Re: Review Request 51999: Refactor parsing of resources to include all valid resources.

> On 九月 19, 2016, 6 a.m., Guangya Liu wrote: > > src/slave/containerizer/containerizer.cpp, lines 64-71 > > > > > > A question here: Does the `resources` here will include the zero value > > resource? > > > >

Re: Review Request 51999: Refactor parsing of resources to include all valid resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51999/ --- (Updated Sept. 19, 2016, 10:42 p.m.) Review request for mesos and Jiang Yan

Re: Review Request 51999: Refactor parsing of resources to include all valid resources.

> On Sept. 19, 2016, 6 a.m., Guangya Liu wrote: > > src/slave/containerizer/containerizer.cpp, lines 64-71 > > > > > > A question here: Does the `resources` here will include the zero value > > resource? > > >

Re: Review Request 51999: Refactor parsing of resources to include all valid resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51999/#review149431 --- include/mesos/resources.hpp (line 184)

Re: Review Request 51999: Refactor parsing of resources to include all valid resources.

> On 九月 19, 2016, 6 a.m., Guangya Liu wrote: > > Ditto for all v1 files. - Guangya --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51999/#review149431

Re: Review Request 51999: Refactor parsing of resources to include all valid resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51999/ --- (Updated Sept. 19, 2016, 5:01 a.m.) Review request for mesos and Jiang Yan Xu.

Review Request 51999: Refactor parsing of resources to include all valid resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51999/ --- Review request for mesos. Repository: mesos Description --- During