Re: Review Request 52083: Changed reconciliation for unregistering, reregistering agents.

2017-03-24 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52083/#review170066 --- src/master/master.hpp Lines 1726-1737 (original), 1727-1734

Re: Review Request 52083: Changed reconciliation for unregistering, reregistering agents.

2016-10-17 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52083/#review152997 --- Ship it! Ship It! - Vinod Kone On Oct. 13, 2016, 2:10 p.m.,

Re: Review Request 52083: Changed reconciliation for unregistering, reregistering agents.

2016-10-13 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52083/ --- (Updated Oct. 13, 2016, 2:10 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 52083: Changed reconciliation for unregistering, reregistering agents.

2016-10-13 Thread Neil Conway
> On Oct. 12, 2016, 12:54 a.m., Vinod Kone wrote: > > don't quite follow the second para in the description. you say agent is no > > longer in transitioning while re-registering but then you want keep it in > > recovered map which results in the `transitioning()` to return true? am i > >

Re: Review Request 52083: Changed reconciliation for unregistering, reregistering agents.

2016-10-11 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52083/#review152239 --- don't quite follow the second para in the description. you say

Re: Review Request 52083: Changed reconciliation for unregistering, reregistering agents.

2016-09-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52083/#review149695 --- Patch looks great! Reviews applied: [50235, 50416, 50417, 50418,