Re: Review Request 52190: Removed deprecated compiler warnings.

2016-12-19 Thread Daniel Pravat
> On Nov. 23, 2016, 9:27 p.m., Joseph Wu wrote: > > cmake/CompilationConfigure.cmake, lines 97-98 > > > > > > Can you add some comments above these? > > > > I presume that the first definition silences some

Re: Review Request 52190: Removed deprecated compiler warnings.

2016-11-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52190/#review156822 --- Patch looks great! Reviews applied: [52190] Passed command:

Re: Review Request 52190: Removed deprecated compiler warnings.

2016-11-23 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52190/#review156785 --- cmake/CompilationConfigure.cmake (lines 97 - 98)

Re: Review Request 52190: Removed deprecated compiler warnings.

2016-11-23 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52190/ --- (Updated Nov. 23, 2016, 5:12 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 52190: Removed deprecated compiler warnings.

2016-11-23 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52190/ --- (Updated Nov. 23, 2016, 4:12 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 52190: Removed deprecated compiler warnings.

2016-11-22 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52190/ --- (Updated Nov. 23, 2016, 6:56 a.m.) Review request for mesos, Alex Naparu,

Review Request 52190: Removed deprecated compiler warnings.

2016-11-13 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52190/ --- Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joseph